-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Migrate datafusion/sql tests to insta,sql integrations #15484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate datafusion/sql tests to insta,sql integrations #15484
Conversation
Hi @alamb , @blaginin , @xudong963 , The code changes is now done, please review carefully as the code changes is LARGE. I used multiple tools/ways to get all the place where it is appropriate migrated to There some several things to note when I was working on this migration:
enjoy the code :) |
Thank you so much @qstommyshu -- this looks epic Is there any chance you can break this PR up into several smaller ones for easier review? For example, maybe take the first 500 lines or so of diffs and make a seaparate PR for it? It is very hard for me to find enough contiguous time to review 1000s of lines carefully. |
Sure, I'll do Created another PR for the first small part of migration: #15497 |
Which issue does this PR close?
datafusion/sql
tests toinsta
#15397 , Related Migrate datafusion/sql tests to insta, part1 #15497Rationale for this change
What changes are included in this PR?
Part1 of this migration converts tests in
datafusion/sql/tests/sql_integration.rs
to useinsta
. Part2 will be for other tests underdatafusion/sql/tests/cases
.Checkout #15497 for breakdown small PR.
Are these changes tested?
Yes, I manually tested the before/after changes.
Are there any user-facing changes?
No