Migrate datafusion/sql tests to insta, part1 #15497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Mar 30, 2025
There was a problem hiding this comment.
I agree -- thank you @qstommyshu and @blaginin for the review. This is really nicely done
This was referenced Mar 30, 2025
nirnayroy
pushed a commit
to nirnayroy/datafusion
that referenced
this pull request
May 2, 2025
* Add `insta` as a dependency in Cargo.toml and Cargo.lock * WIP, migrate simple test cases to `insta` * taplo fmt * strip backtrace from errors in SQL integration tests * Use `allow_duplicates!` macro in SQL integration tests for error snapshots * remove backtrace from error in test_select_distinct_order_by * WIP: migrate all `prepare_stmt_replace_params_quick_test` to `insta`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
datafusion/sqltests toinsta#15397, this is a part of Migrate datafusion/sql tests to insta,sql integrations #15484 breaking down.Rationale for this change
What changes are included in this PR?
This is the part 1 of #15484 breakdown, as the code changes in #15484 is too large.
Are these changes tested?
Yes, I manually tested the before/after changes.
Are there any user-facing changes?
No