Skip to content

Conversation

qstommyshu
Copy link
Contributor

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

This is the part 3 of #15484 breakdown, as the code changes in #15484 is too large. Part1: #15497, Part2: #15499

Are these changes tested?

Yes, I manually tested the before/after changes.

Are there any user-facing changes?

No

@github-actions github-actions bot added the sql SQL Planner label Apr 1, 2025
@qstommyshu
Copy link
Contributor Author

qstommyshu commented Apr 1, 2025

This PR does only one thing:

  1. Migrate part of the tests done with quick_test() to insta (one more PR on migrating quick_test())

@qstommyshu
Copy link
Contributor Author

qstommyshu commented Apr 1, 2025

Humm, seems there are some issue with the CI pipeline.

image

sccache: error: Server startup failed: cache storage failed to read: Unexpected (permanent) at read => {"$id":"1","innerException":null,"message":"This legacy service is shutting down, effective April 15, 2025. Migrate to the new service ASAP. For more information: https://gh.io/gha-cache-sunset","typeName":"Microsoft.Azure.DevOps.ArtifactCache.WebApi.ArtifactCacheServiceDecommissionedException, Microsoft.Azure.DevOps.ArtifactCache.WebApi","typeKey":"ArtifactCacheServiceDecommissionedException","errorCode":0,"eventId":3000}

Looks like the pipeline is using some legacy service that is going to shutdown soon?

Update: I think this issue is resolved in #15535

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @qstommyshu -- we are so close!

FYI @blaginin

@alamb alamb merged commit 28451b5 into apache:main Apr 2, 2025
27 checks passed
nirnayroy pushed a commit to nirnayroy/datafusion that referenced this pull request May 2, 2025
* WIP: migrate more `quick_test()` cases

* Refactor test suite for improved maintainability and performance

* clean up

* retrigger CI pipeline

* retrigger CI pipeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sql SQL Planner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants