-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Migrate datafusion/sql tests to insta, part4 #15548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate datafusion/sql tests to insta, part4 #15548
Conversation
|
This PR does only one thing: Migrate part of the tests done with quick_test() to insta (This is the last PR on migrating |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this!!! 🙏 I wrote mostly nits, but spotted some places where old test is not quite the same as the new one. Fixing should be easy - could you take a look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me -- thank you @qstommyshu and @blaginin
I'll plan to wait to merge this until @blaginin has another change to review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Two small things but otherwise good from me 🚀
|
I also broke the giant series of But for many small tests that produces the exact same output like Same thing applied to test |
|
I also replaced/renamed |
|
Thanks again! This is looking really nice now |
* WIP: all `quick_test` migrated to `insta` * Remove `quick_test_with_options()` * resolve comments * Refactor SQL integration tests for decimal parsing and identifier normalization * replace `generate_logical_plan()` to `logical_plan().unwrap()` * Strip backtrace from logical plan error in SQL integration test
Which issue does this PR close?
datafusion/sqltests toinsta#15397, Migrate datafusion/sql tests to insta, part1 #15497, Migratedatafusion/sqltests to insta, part2 #15499, Migrate datafusion/sql tests to insta, part3 #15533Rationale for this change
What changes are included in this PR?
This is the part 4 of #15484 breakdown, as the code changes in #15484 is too large. Part1: #15497, Part2: #15499, Part3: #15533
Are these changes tested?
Yes, I manually tested the before/after changes.
Are there any user-facing changes?
No