[SPARK-13257] [Improvement] Scala naive Bayes example: check model after loading #11192
Conversation
| */ | ||
|
|
||
| /* | ||
| * Usage: |
There was a problem hiding this comment.
So this usage text probably isn't the format we want, its pretty specific to each Spark release. Maybe look at some of the other files in this directory and see how they do their usage?
|
Thanks for taking on this issue & fixing it across multiple languages. A super minor thing is generally we try and have separate JIRAs for separate PRs - so in this case creating a sub task on the initial PR to also update Scala might be better from a tracking point of view (since when I went to look at this PR my first thought was that the issue had already been resolved). You might also want to try running the scala linter locally on your code (e.g. |
|
Hi @movelikeriver, are you able to proceed this further? If not, maybe it'd be better closed for now. |
|
Can one of the admins verify this patch? |
## What changes were proposed in this pull request? This PR proposes to close stale PRs. What I mean by "stale" here includes that there are some review comments by reviewers but the author looks inactive without any answer to them more than a month. I left some comments roughly a week ago to ping and the author looks still inactive in these PR below These below includes some PR suggested to be closed and a PR against another branch which seems obviously inappropriate. Given the comments in the last three PRs below, they are probably worth being taken over by anyone who is interested in it. Closes apache#7963 Closes apache#8374 Closes apache#11192 Closes apache#11374 Closes apache#11692 Closes apache#12243 Closes apache#12583 Closes apache#12620 Closes apache#12675 Closes apache#12697 Closes apache#12800 Closes apache#13715 Closes apache#14266 Closes apache#15053 Closes apache#15159 Closes apache#15209 Closes apache#15264 Closes apache#15267 Closes apache#15871 Closes apache#15861 Closes apache#16319 Closes apache#16324 Closes apache#16890 Closes apache#12398 Closes apache#12933 Closes apache#14517 ## How was this patch tested? N/A Author: hyukjinkwon <gurwls223@gmail.com> Closes apache#16937 from HyukjinKwon/stale-prs-close.
4 participants
Refine naive Bayes example by checking model after loading it.
This is Java version, to be consistent with Python version in #11125