[SPARK-15024] NoClassDefFoundError in spark-examples due to Guava relocation #12800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atokhy
changed the title
atokhy
changed the title
|
Can one of the admins verify this patch? |
Member
|
(It looks the last part of the title is truncated) |
Member
|
This is opened vs 1.6 when it should be master. |
atokhy
changed the title
Author
|
This is a problem only found in the 1.6 branch (potentially in Spark 1.6.2), and it does not apply to Apache master. |
Contributor
|
@atokhy that's a little weird. The examples module should be inheriting the guava shading from the parent pom. I have a 1.6 build locally (with patches, so I'll check the official package tomorrow) and HiveFromSpark does not reference unshaded guava classes. |
Member
|
Hi @atokhy, it seems inactive without an answer to the comment above. Should this be better closed if you are not able to proceed this further? |
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 22, 2025
## What changes were proposed in this pull request? This PR proposes to close stale PRs. What I mean by "stale" here includes that there are some review comments by reviewers but the author looks inactive without any answer to them more than a month. I left some comments roughly a week ago to ping and the author looks still inactive in these PR below These below includes some PR suggested to be closed and a PR against another branch which seems obviously inappropriate. Given the comments in the last three PRs below, they are probably worth being taken over by anyone who is interested in it. Closes apache#7963 Closes apache#8374 Closes apache#11192 Closes apache#11374 Closes apache#11692 Closes apache#12243 Closes apache#12583 Closes apache#12620 Closes apache#12675 Closes apache#12697 Closes apache#12800 Closes apache#13715 Closes apache#14266 Closes apache#15053 Closes apache#15159 Closes apache#15209 Closes apache#15264 Closes apache#15267 Closes apache#15871 Closes apache#15861 Closes apache#16319 Closes apache#16324 Closes apache#16890 Closes apache#12398 Closes apache#12933 Closes apache#14517 ## How was this patch tested? N/A Author: hyukjinkwon <gurwls223@gmail.com> Closes apache#16937 from HyukjinKwon/stale-prs-close.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This change will only shade and relocate Guava in the spark-examples JAR used by the Apache Bigtop distribution (as of writing the Bigtop distribution uses the unshaded JAR). Since only Guava and Jetty are relocated, and since there are 0 references to Jetty in the spark-examples codebase, only Guava needs to be shaded. The shaded spark-assembly JAR provides the rest of the dependencies needed to get the spark-examples to run without any NoClassDefFoundErrors
How was this patch tested?
mvn package -DrecompileMode=all -Pbigtop-dist -Pyarn -Phadoop-2.6 -Phive -Phive-thriftserver -Dprotobuf.version=2.5.0
$ unzip -l target/scala-2.10/spark-examples-1.6.1-hadoop2.6.0.jar | grep org.spark-project.guava | wc -l
1602