[SPARK-14894][PySpark] Add result summary api to Gaussian Mixture #12675

GayathriMurali · 2016-04-26T00:09:55Z

What changes were proposed in this pull request?

Add summary API to Gaussian Mixture

How was this patch tested?

Added unit test case to test summary information

GayathriMurali · 2016-04-26T00:12:28Z

@wangmiao1981 @jkbradley Please help review this PR

holdenk · 2016-04-26T19:17:55Z

python/pyspark/ml/clustering.py

This PyDoc seems oddly formatted in terms of line breaks.

GayathriMurali · 2016-04-28T19:02:37Z

@jkbradley Can you please ok to test this

GayathriMurali · 2016-05-06T00:37:04Z

@holdenk I fixed the pydoc style issue. Can you please help review this?

holdenk · 2016-05-06T00:43:28Z

python/pyspark/ml/clustering.py

this also seems strangely formatted - did you mean trainingSummary is None. ?

holdenk · 2016-05-09T19:10:45Z

So did a quick look and it seems like it might not be lining up with the Scala implementation (or I just haven't had enough coffee this morning). It might be worthwhile to doublecheck against the scaladoc and also run your tests locally if you haven't done that.

GayathriMurali · 2016-05-12T05:39:01Z

@holdenk I checked the ScalaDoc and removed the evaluate method. Thanks for pointing it out. Can you please help review

GayathriMurali · 2016-06-07T21:21:12Z

@jkbradley @holdenk Can you please help review?

GayathriMurali · 2016-06-14T22:29:11Z

@jkbradley This PR has been open >30days. Can you please help review?

MLnick · 2016-06-17T12:55:19Z

ok to test

SparkQA · 2016-06-17T12:58:22Z

Test build #60707 has finished for PR 12675 at commit 2e226ce.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2016-06-18T00:58:26Z

Test build #60739 has finished for PR 12675 at commit 7d16a23.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2016-06-18T03:48:33Z

Test build #60748 has finished for PR 12675 at commit 3cf080a.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2016-06-19T21:08:33Z

Test build #60820 has finished for PR 12675 at commit c2b1aef.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2016-06-19T21:42:36Z

Test build #60821 has finished for PR 12675 at commit 3bc75a3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

GayathriMurali · 2016-06-21T21:22:56Z

python/pyspark/ml/tests.py


+    def test_gaussian_mixture_summary(self):
+        from pyspark.mllib.linalg import Vectors
+        df = self.spark.read.format("libsvm").load("data/mllib/sample_kmeans_data.txt")


Please let me know if its ok to load data from a file when all other test cases uses hard coded data values. I tried with a sparse vector and fit gave me an error for the data format.

I think its ok to load a dataset which is already used for testing else where.

GayathriMurali · 2016-06-21T21:23:37Z

@MLnick It would be great if you can help review this.

holdenk

Are you still interested in this PR @GayathriMurali ? If you've got the time to look at some of my notes around the PyDocs that would be cool - but we can also try pinging @davies & @MLnick to see if they are available to review once those comments are looked at :)

holdenk · 2016-10-07T20:58:24Z

python/pyspark/ml/clustering.py

        return self._call_java("gaussiansDF")

+    @property
+    @since("2.0.0")


Since we've shipped 2.0 we will need to update this to 2.1 (same with the versionAdded notes)

HyukjinKwon · 2017-02-09T13:21:09Z

Hi @GayathriMurali, it seems inactive for the review comments for few months. Should this be better closed for now if you are not able to proceed this further?

wangmiao1981 · 2017-02-09T17:32:03Z

@GayathriMurali If you are not able to proceed, I can take over. Thanks!

wangmiao1981 · 2017-02-15T00:32:18Z

#15777 has resolved this issue. We should close this one.

wangmiao1981 · 2017-02-15T00:33:05Z

@HyukjinKwon @srowen This should be closed. Thanks!

HyukjinKwon · 2017-02-15T00:34:24Z

@wangmiao1981 Wow, thank you for your efforts to verify it!

## What changes were proposed in this pull request? This PR proposes to close stale PRs. What I mean by "stale" here includes that there are some review comments by reviewers but the author looks inactive without any answer to them more than a month. I left some comments roughly a week ago to ping and the author looks still inactive in these PR below These below includes some PR suggested to be closed and a PR against another branch which seems obviously inappropriate. Given the comments in the last three PRs below, they are probably worth being taken over by anyone who is interested in it. Closes apache#7963 Closes apache#8374 Closes apache#11192 Closes apache#11374 Closes apache#11692 Closes apache#12243 Closes apache#12583 Closes apache#12620 Closes apache#12675 Closes apache#12697 Closes apache#12800 Closes apache#13715 Closes apache#14266 Closes apache#15053 Closes apache#15159 Closes apache#15209 Closes apache#15264 Closes apache#15267 Closes apache#15871 Closes apache#15861 Closes apache#16319 Closes apache#16324 Closes apache#16890 Closes apache#12398 Closes apache#12933 Closes apache#14517 ## How was this patch tested? N/A Author: hyukjinkwon <gurwls223@gmail.com> Closes apache#16937 from HyukjinKwon/stale-prs-close.

holdenk reviewed Apr 26, 2016
View reviewed changes

python/pyspark/ml/clustering.py Outdated

Copy link

Contributor

holdenk Apr 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PyDoc seems oddly formatted in terms of line breaks.

GayathriMurali force-pushed the SPARK-14894 branch from f3114ed to 11f0574 Compare April 26, 2016 21:30

holdenk reviewed May 6, 2016
View reviewed changes

python/pyspark/ml/clustering.py Outdated

Copy link

Contributor

holdenk May 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this also seems strangely formatted - did you mean trainingSummary is None. ?

GayathriMurali force-pushed the SPARK-14894 branch from 11f0574 to 2e226ce Compare May 12, 2016 05:35

GayathriMurali added 4 commits June 17, 2016 17:53

[SPARK-14894][PySpark] Add result summary api to Gaussian Mixture

c42f5dd

Fixed a duplication in tests.py

7db9c0d

Fixed line break in PyDoc

b19756c

Fixed python style issues

7d16a23

GayathriMurali force-pushed the SPARK-14894 branch from 2e226ce to 7d16a23 Compare June 18, 2016 00:55

Fixed python style issues

3cf080a

Fixed python unit test issues

c2b1aef

Style issue

3bc75a3

GayathriMurali reviewed Jun 21, 2016
View reviewed changes

holdenk reviewed Oct 7, 2016

View reviewed changes

HyukjinKwon mentioned this pull request Feb 15, 2017

[BUILD] Close stale PRs #16937

Closed

asfgit closed this in ed338f7 Feb 17, 2017

[SPARK-14894][PySpark] Add result summary api to Gaussian Mixture #12675

[SPARK-14894][PySpark] Add result summary api to Gaussian Mixture #12675

Uh oh!

Conversation

GayathriMurali commented Apr 26, 2016

What changes were proposed in this pull request?

How was this patch tested?

Uh oh!

GayathriMurali commented Apr 26, 2016

Uh oh!

holdenk Apr 26, 2016

Choose a reason for hiding this comment

Uh oh!

GayathriMurali commented Apr 28, 2016

Uh oh!

GayathriMurali commented May 6, 2016

Uh oh!

holdenk May 6, 2016

Choose a reason for hiding this comment

Uh oh!

holdenk commented May 9, 2016

Uh oh!

GayathriMurali commented May 12, 2016

Uh oh!

GayathriMurali commented Jun 7, 2016

Uh oh!

GayathriMurali commented Jun 14, 2016

Uh oh!

MLnick commented Jun 17, 2016

Uh oh!

SparkQA commented Jun 17, 2016

Uh oh!

SparkQA commented Jun 18, 2016

Uh oh!

SparkQA commented Jun 18, 2016

Uh oh!

SparkQA commented Jun 19, 2016

Uh oh!

SparkQA commented Jun 19, 2016

Uh oh!

GayathriMurali Jun 21, 2016

Choose a reason for hiding this comment

Uh oh!

holdenk Oct 7, 2016

Choose a reason for hiding this comment

Uh oh!

GayathriMurali commented Jun 21, 2016

Uh oh!

holdenk left a comment

Choose a reason for hiding this comment

Uh oh!

holdenk Oct 7, 2016

Choose a reason for hiding this comment

Uh oh!

HyukjinKwon commented Feb 9, 2017

Uh oh!

wangmiao1981 commented Feb 9, 2017

Uh oh!

wangmiao1981 commented Feb 15, 2017

Uh oh!

wangmiao1981 commented Feb 15, 2017

Uh oh!

HyukjinKwon commented Feb 15, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants