Make remap API compatibility checks consistent. #10253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I'm going to approve this when it passes CI, but it's a bit of shame that the macro is only available internally. We may want to consider providing the feature as TS API in the future. |
Contributor
Author
|
[approve ci] |
Member
|
Use an internal macro to make all the remap API compatibility checks consistent. For test plugins, where there's no risk of incompatibility, just assert that the API is compatible. This fixes apache#10222. Signed-off-by: James Peach <jpeach@apache.org>
jpeach
force-pushed
the
remap-version-check
branch
from
c228a1d to
6dd6f5e
Compare
maskit
approved these changes
Aug 28, 2023
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jun 3, 2024
Use an internal macro to make all the remap API compatibility checks consistent. For test plugins, where there's no risk of incompatibility, just assert that the API is compatible. This fixes apache#10222. Signed-off-by: James Peach <jpeach@apache.org>
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jun 3, 2024
* commit '01409a61bab49c81cf422cdb29a94dcd07bf3c37': (31 commits) cmake: add more executables (apache#10284) Fix a crash due to bad disks (apache#10287) ts_lua_transform: input_reader may be used uninitialized (apache#10297) CID 1508887 fix parent_select plugin stat Time of check. (apache#10260) Make remap API compatibility checks consistent. (apache#10253) remove deprecated 'NATIVE' AIO mode (apache#10269) Fix connect failure count (apache#10294) Add version range up to CMake 3.27 (apache#10259) untangle fds_limit global (apache#10288) replace net_config_poll_timeout with EThread::default_wait_interval_ms (apache#10289) suppress coverity false positive on race condition (apache#10278) initialize variable (apache#10277) Check the inet_pton return value for IP reputations (apache#10267) Fix missing virtual destructor. (apache#10293) tools/jtest: use @SWOC_LIBS@ (apache#10292) Fix m4 quoting on configure error messages. (apache#10258) build_h3_tools: explicitly chmod the destination directory (apache#10274) Fix CID 1508979: unchecked return value (apache#10281) Fix CID 1508970: Uninitialized scalar variable (apache#10282) Fix CID 1508992, 1508976, 1508972: uninitialized scalar variables (apache#10275) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use an internal macro to make all the remap API compatibility checks consistent. For test plugins, where there's no risk of incompatibility, just assert that the API is compatible.
This fixes #10222.