Skip to content

ts_lua_transform: input_reader may be used uninitialized #10297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bneradt merged 1 commit into from
Aug 29, 2023
Merged

ts_lua_transform: input_reader may be used uninitialized #10297

bneradt merged 1 commit into from
Aug 29, 2023

Conversation

@bneradt
Copy link
Contributor

@bneradt bneradt commented Aug 29, 2023

Fix:

plugins/lua/ts_lua_transform.cc: In function ‘int ts_lua_client_entry(tsapi::c::TSCont, tsapi::c::TSEvent, void*)’:
plugins/lua/ts_lua_transform.cc:136:28: error: ‘input_reader’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
  136 |     TSIOBufferReaderConsume(input_reader, input_avail);
      |     ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
plugins/lua/ts_lua_transform.cc:62:20: note: ‘input_reader’ was declared here
   62 |   TSIOBufferReader input_reader;
      |                    ^~~~~~~~~~~~
mv -f esi/.deps/esi_la-esi.Tpo esi/.deps/esi_la-esi.Plo
plugins/lua/ts_lua_transform.cc: In function ‘int ts_lua_transform_entry(tsapi::c::TSCont, tsapi::c::TSEvent, void*)’:
plugins/lua/ts_lua_transform.cc:373:28: error: ‘input_reader’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
  373 |     TSIOBufferReaderConsume(input_reader, input_avail);
      |     ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
plugins/lua/ts_lua_transform.cc:289:20: note: ‘input_reader’ was declared here
  289 |   TSIOBufferReader input_reader;
      |                    ^~~~~~~~~~~~
cc1plus: all warnings being treated as errors
make[2]: *** [Makefile:6725: lua/tslua_la-ts_lua_transform.lo] Error 1

ts_lua_transform: input_reader may be used uninitialized
d596bce 
Fix:

```
plugins/lua/ts_lua_transform.cc: In function ‘int ts_lua_client_entry(tsapi::c::TSCont, tsapi::c::TSEvent, void*)’:
plugins/lua/ts_lua_transform.cc:136:28: error: ‘input_reader’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
  136 |     TSIOBufferReaderConsume(input_reader, input_avail);
      |     ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
plugins/lua/ts_lua_transform.cc:62:20: note: ‘input_reader’ was declared here
   62 |   TSIOBufferReader input_reader;
      |                    ^~~~~~~~~~~~
mv -f esi/.deps/esi_la-esi.Tpo esi/.deps/esi_la-esi.Plo
plugins/lua/ts_lua_transform.cc: In function ‘int ts_lua_transform_entry(tsapi::c::TSCont, tsapi::c::TSEvent, void*)’:
plugins/lua/ts_lua_transform.cc:373:28: error: ‘input_reader’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
  373 |     TSIOBufferReaderConsume(input_reader, input_avail);
      |     ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
plugins/lua/ts_lua_transform.cc:289:20: note: ‘input_reader’ was declared here
  289 |   TSIOBufferReader input_reader;
      |                    ^~~~~~~~~~~~
cc1plus: all warnings being treated as errors
make[2]: *** [Makefile:6725: lua/tslua_la-ts_lua_transform.lo] Error 1
```
@bneradt bneradt added Plugins Build work related to build configuration or environment Lua labels Aug 29, 2023
@bneradt bneradt added this to the 10.0.0 milestone Aug 29, 2023
@bneradt bneradt requested a review from shukitchan August 29, 2023 03:06
@bneradt bneradt self-assigned this Aug 29, 2023
@bneradt bneradt merged commit ac8d113 into apache:master Aug 29, 2023
@bneradt bneradt deleted the fix_lua_transform_may_be_used_uninitialized branch August 29, 2023 15:24
cmcfarlen pushed a commit to cmcfarlen/trafficserver that referenced this pull request Jun 3, 2024
@bneradt @zwoop
ts_lua_transform: input_reader may be used uninitialized (apache#10297)
b4f91dc 
Fix:

```
plugins/lua/ts_lua_transform.cc: In function ‘int ts_lua_client_entry(tsapi::c::TSCont, tsapi::c::TSEvent, void*)’:
plugins/lua/ts_lua_transform.cc:136:28: error: ‘input_reader’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
  136 |     TSIOBufferReaderConsume(input_reader, input_avail);
      |     ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
plugins/lua/ts_lua_transform.cc:62:20: note: ‘input_reader’ was declared here
   62 |   TSIOBufferReader input_reader;
      |                    ^~~~~~~~~~~~
mv -f esi/.deps/esi_la-esi.Tpo esi/.deps/esi_la-esi.Plo
plugins/lua/ts_lua_transform.cc: In function ‘int ts_lua_transform_entry(tsapi::c::TSCont, tsapi::c::TSEvent, void*)’:
plugins/lua/ts_lua_transform.cc:373:28: error: ‘input_reader’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
  373 |     TSIOBufferReaderConsume(input_reader, input_avail);
      |     ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
plugins/lua/ts_lua_transform.cc:289:20: note: ‘input_reader’ was declared here
  289 |   TSIOBufferReader input_reader;
      |                    ^~~~~~~~~~~~
cc1plus: all warnings being treated as errors
make[2]: *** [Makefile:6725: lua/tslua_la-ts_lua_transform.lo] Error 1
```

Co-authored-by: bneradt <bneradt@yahooinc.com>
cmcfarlen pushed a commit to cmcfarlen/trafficserver that referenced this pull request Jun 3, 2024
@zwoop
Merge commit '01409a61bab49c81cf422cdb29a94dcd07bf3c37'
2437973 
* commit '01409a61bab49c81cf422cdb29a94dcd07bf3c37': (31 commits)
  cmake: add more executables (apache#10284)
  Fix a crash due to bad disks (apache#10287)
  ts_lua_transform: input_reader may be used uninitialized (apache#10297)
  CID 1508887 fix parent_select plugin stat Time of check. (apache#10260)
  Make remap API compatibility checks consistent. (apache#10253)
  remove deprecated 'NATIVE' AIO mode (apache#10269)
  Fix connect failure count (apache#10294)
  Add version range up to CMake 3.27 (apache#10259)
  untangle fds_limit global (apache#10288)
  replace net_config_poll_timeout with EThread::default_wait_interval_ms (apache#10289)
  suppress coverity false positive on race condition (apache#10278)
  initialize variable (apache#10277)
  Check the inet_pton return value for IP reputations (apache#10267)
  Fix missing virtual destructor. (apache#10293)
  tools/jtest: use @SWOC_LIBS@ (apache#10292)
  Fix m4 quoting on configure error messages. (apache#10258)
  build_h3_tools: explicitly chmod the destination directory (apache#10274)
  Fix CID 1508979: unchecked return value (apache#10281)
  Fix CID 1508970: Uninitialized scalar variable (apache#10282)
  Fix CID 1508992, 1508976, 1508972: uninitialized scalar variables (apache#10275)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shukitchan shukitchan shukitchan approved these changes

@ezelkow1 ezelkow1 ezelkow1 approved these changes

Assignees

@bneradt bneradt

Labels

Build work related to build configuration or environment Lua Plugins

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@bneradt @shukitchan @ezelkow1