Fix connect failure count

[maskit]

If you look at the code on 9.2.x, the code is basically:

if (time_down) {

} else {  // Clear the failure
  info->app.http_data.fail_count   = 0;
  info->app.http_data.last_failure = time_down;
}

but on master it's like

if (time_down != TS_TIME_ZERO) {
  if (++count < max_retry) {

  } else {  // Clear the failure
    info->app.http_data.fail_count   = 0;
    info->app.http_data.last_failure = time_down;
  }
}

So the counter never reaches max_retry.

The code on 9.2.x:

trafficserver/proxy/http/HttpSM.cc

Lines 5615 to 5643 in 6ffbdab

	if (time_down) {
	// Increment the fail_count
	++info->app.http_data.fail_count;
	if (info->app.http_data.fail_count >= t_state.txn_conf->connect_attempts_rr_retries) {
	if (info->app.http_data.last_failure == 0) {
	char *url_str = t_state.hdr_info.client_request.url_string_get(&t_state.arena, nullptr);
	int host_len;
	const char *host_name_ptr = t_state.unmapped_url.host_get(&host_len);
	std::string_view host_name{host_name_ptr, size_t(host_len)};
	ts::bwprint(error_bw_buffer, "CONNECT: {::s} connecting to {} for host='{}' url='{}' marking down",
	ts::bwf::Errno(t_state.current.server->connect_result), t_state.current.server->dst_addr, host_name,
	ts::bwf::FirstOf(url_str, "<none>"));
	Log::error("%s", error_bw_buffer.c_str());
	if (url_str) {
	t_state.arena.str_free(url_str);
	}
	}
	info->app.http_data.last_failure = time_down;
	SMDebug("http", "hostdb update marking IP: %s as down",
	ats_ip_nptop(&t_state.current.server->dst_addr.sa, addrbuf, sizeof(addrbuf)));
	} else {
	SMDebug("http", "hostdb increment IP failcount %s to %d",
	ats_ip_nptop(&t_state.current.server->dst_addr.sa, addrbuf, sizeof(addrbuf)), info->app.http_data.fail_count);
	}
	} else { // Clear the failure
	info->app.http_data.fail_count = 0;
	info->app.http_data.last_failure = time_down;
	}