feat(fsx): support AutoImportPolicy in LustreFilesystem #21301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
feature-request
tcutts
changed the title
TheRealAmazonKendra
changed the title
github-actions
bot
added
effort/medium
TheRealAmazonKendra
previously requested changes
Jul 28, 2022
…k/lambda-layer-awscli (#21309) Bumps [awscli](https://github.com/aws/aws-cli) from 1.25.31 to 1.25.36. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-cli/blob/develop/CHANGELOG.rst">awscli's changelog</a>.</em></p> <blockquote> <h1>1.25.36</h1> <ul> <li>api-change:<code>account</code>: This release enables customers to manage the primary contact information for their AWS accounts. For more information, see <a href="https://docs.aws.amazon.com/accounts/latest/reference/API_Operations.html">https://docs.aws.amazon.com/accounts/latest/reference/API_Operations.html</a></li> <li>api-change:<code>ec2</code>: Added support for EC2 M1 Mac instances. For more information, please visit aws.amazon.com/mac.</li> <li>api-change:<code>iotdeviceadvisor</code>: Added new service feature (Early access only) - Long Duration Test, where customers can test the IoT device to observe how it behaves when the device is in operation for longer period.</li> <li>api-change:<code>medialive</code>: Link devices now support remote rebooting. Link devices now support maintenance windows. Maintenance windows allow a Link device to install software updates without stopping the MediaLive channel. The channel will experience a brief loss of input from the device while updates are installed.</li> <li>api-change:<code>rds</code>: This release adds the "ModifyActivityStream" API with support for audit policy state locking and unlocking.</li> <li>api-change:<code>transcribe</code>: Remove unsupported language codes for StartTranscriptionJob and update VocabularyFileUri for UpdateMedicalVocabulary</li> </ul> <h1>1.25.35</h1> <ul> <li>api-change:<code>athena</code>: This feature allows customers to retrieve runtime statistics for completed queries</li> <li>api-change:<code>cloudwatch</code>: Update cloudwatch command to latest version</li> <li>api-change:<code>dms</code>: Documentation updates for Database Migration Service (DMS).</li> <li>api-change:<code>docdb</code>: Enable copy-on-write restore type</li> <li>api-change:<code>ec2-instance-connect</code>: This release includes a new exception type "EC2InstanceUnavailableException" for SendSSHPublicKey and SendSerialConsoleSSHPublicKey APIs.</li> <li>api-change:<code>frauddetector</code>: The release introduces Account Takeover Insights (ATI) model. The ATI model detects fraud relating to account takeover. This release also adds support for new variable types: ARE_CREDENTIALS_VALID and SESSION_ID and adds new structures to Model Version APIs.</li> <li>api-change:<code>iotsitewise</code>: Added asynchronous API to ingest bulk historical and current data into IoT SiteWise.</li> <li>api-change:<code>kendra</code>: Amazon Kendra now provides Oauth2 support for SharePoint Online. For more information, see <a href="https://docs.aws.amazon.com/kendra/latest/dg/data-source-sharepoint.html">https://docs.aws.amazon.com/kendra/latest/dg/data-source-sharepoint.html</a></li> <li>api-change:<code>network-firewall</code>: Network Firewall now supports referencing dynamic IP sets from stateful rule groups, for IP sets stored in Amazon VPC prefix lists.</li> <li>api-change:<code>rds</code>: Adds support for creating an RDS Proxy for an RDS for MariaDB database.</li> </ul> <h1>1.25.34</h1> <ul> <li>api-change:<code>acm-pca</code>: AWS Certificate Manager (ACM) Private Certificate Authority (PCA) documentation updates</li> <li>api-change:<code>iot</code>: GA release the ability to enable/disable IoT Fleet Indexing for Device Defender and Named Shadow information, and search them through IoT Fleet Indexing APIs. This includes Named Shadow Selection as a part of the UpdateIndexingConfiguration API.</li> </ul> <h1>1.25.33</h1> <ul> <li>api-change:<code>devops-guru</code>: Added new APIs for log anomaly detection feature.</li> <li>api-change:<code>glue</code>: Documentation updates for AWS Glue Job Timeout and Autoscaling</li> <li>api-change:<code>sagemaker-edge</code>: Amazon SageMaker Edge Manager provides lightweight model deployment feature to deploy machine learning models on requested devices.</li> <li>api-change:<code>sagemaker</code>: Fixed an issue with cross account QueryLineage</li> <li>api-change:<code>workspaces</code>: Increased the character limit of the login message from 850 to 2000 characters.</li> </ul> <h1>1.25.32</h1> <ul> <li>api-change:<code>discovery</code>: Add AWS Agentless Collector details to the GetDiscoverySummary API response</li> <li>api-change:<code>ec2</code>: Documentation updates for Amazon EC2.</li> <li>api-change:<code>elasticache</code>: Adding AutoMinorVersionUpgrade in the DescribeReplicationGroups API</li> <li>api-change:<code>kms</code>: Added support for the SM2 KeySpec in China Partition Regions</li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/aws/aws-cli/commit/bf214a8143c74d3ed8dd9c6d9652127ab895985e"><code>bf214a8</code></a> Merge branch 'release-1.25.36'</li> <li><a href="https://github.com/aws/aws-cli/commit/9adda53f1756f3a24bde091aced646f138311a44"><code>9adda53</code></a> Bumping version to 1.25.36</li> <li><a href="https://github.com/aws/aws-cli/commit/d4e0f84c2de892044d3dea250af14ffa1b38af91"><code>d4e0f84</code></a> Update changelog based on model updates</li> <li><a href="https://github.com/aws/aws-cli/commit/25516bed2ea3339ab392990d515738b921b0af01"><code>25516be</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/aws/aws-cli/issues/7118">#7118</a> from hssyoo/add-example-note-v1</li> <li><a href="https://github.com/aws/aws-cli/commit/9ee819f104f7d601c4cce8028853fc7c9c03c7f5"><code>9ee819f</code></a> Merge branch 'release-1.25.35'</li> <li><a href="https://github.com/aws/aws-cli/commit/b2008bcf8dd6ce3b8008aee10574e50ccc82779a"><code>b2008bc</code></a> Merge branch 'release-1.25.35' into develop</li> <li><a href="https://github.com/aws/aws-cli/commit/2909ce6981da926dd45ac916e443b09a509c1b97"><code>2909ce6</code></a> Bumping version to 1.25.35</li> <li><a href="https://github.com/aws/aws-cli/commit/6d31bfa4f518463d5bf53fe50c48f09edddb6077"><code>6d31bfa</code></a> Update changelog based on model updates</li> <li><a href="https://github.com/aws/aws-cli/commit/adf2c6932e264b21086209a5b5af57793dd28acc"><code>adf2c69</code></a> Merge branch 'release-1.25.34'</li> <li><a href="https://github.com/aws/aws-cli/commit/b5b956de704e91a2148945ecee9e2830f88c1154"><code>b5b956d</code></a> Merge branch 'release-1.25.34' into develop</li> <li>Additional commits viewable in <a href="https://github.com/aws/aws-cli/compare/1.25.31...1.25.36">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
We recently had an issue where a PR broke asset bundling for stacks that were created under a stage. This PR adds an integration test that deploys a Stack under a Stage that contains lambda function with an asset. ---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Today, pkglint prevents any module from depending on any experimental module, regardless of its `maturity`. This PR considers `maturity` such that `cfn-only` modules can be taken as dependencies. While writing tests for this is possible, it would be out-of-scope for this PR. ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
) ---- Closes #20934 Motivation: Customer would like to be able to set the description per deployment. From inside their pipeline, they could get the commit hash / commit message, timestamp, custom text, and other git-related metadata that they would like to set as description. Thanks to @TheRealAmazonKendra for help cleaning this PR up and providing some pointers on locally building the CDK. ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…1201) I ran into an issue when deploying a Java application on Fargate, where the container kept getting killed because of out-of-memory condition. Setting memoryLimitMiB also on container fixed the problem, based on: https://aws.amazon.com/blogs/containers/how-amazon-ecs-manages-cpu-and-memory-resources/ > [Update 12/11/2020] Some applications are container-aware and can configure themselves to take full advantage of the resources available inside the container. The latest versions of Java are a good example of this pattern. For this reason, some of these applications work best when CPU and memory resources are explicitly configured at the container level, in addition to the configuration at the task level. In other words, while containers without specific resource configurations can nominally access all task resources, aws/amazon-ecs-agent#1735. I initially asked about this in #13127 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
`FirelensOptions` should have only optional properties, but `configFileValue` was previously marked as required. This caused some confusion and incorrect configuration like `configFileValue = ''` as seen here: aws/aws-for-fluent-bit#352. This fix marks `configFileValue` as optional, and makes sure that `configFileValue` and `configFileType` are set together, or not at all. See [docs](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ecs-taskdefinition-firelensconfiguration.html#cfn-ecs-taskdefinition-firelensconfiguration-options). Signed-off-by: Wesley Pettit <wppttt@amazon.com> Needed to fix: aws/aws-for-fluent-bit#352 ---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…21230) Instead of passing the context in an environment variable, the CLI now writes the context to a temporary file and sets an environment variable only with the location. The app then uses that location to read from the file. Also tested manually on a Linux machine. Fixes #19261. ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Ran npm-check-updates and yarn upgrade to keep the `yarn.lock` file up-to-date.
Remove image scanning configuration for the staging ECR repository. - Image Scanning Configuration in the bootstrap template causes problems in regions where image scanning is not available. - Scanning configuration at the repository level has been deprecated in favor of configuration at the registry level, which also allows more configuration (basic vs. enhanced scanning). Because of a bug in the ECR CloudFormation resource, removing the configuration value does not actually turn it off. Therefore, for people who have successfully bootstrapped in the past, the scanning feature will be left as-is. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
When configuring a FunctionUrl for a Lambda function Alias, the underlying lambda function's ARN must be configured as TargetFunctionArn, and the alias name as Qualifier. This was previously not the case, as the Alias' ARN was used with no qualifier, which accidentally succeeded provisionning but did not necessarily produce the intended result. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
And introduce a pkglint rule that runs the @aws-cdk/node-bundle validations as well as automated fixes as appropriate.
When fingerprinting large assets, hashing the asset can take quite a long time - over a second for a 300MB asset, for example. This can add up, particularly when generating multiple stacks in a single build, or when running test suites that bundle assets multiple times, and is not avoidable by asset caching (since it's computing the cache key). This change caches the result of digesting individual files based on the inode, mtime, and size of the input file. This feature improved the runtime of one of our slowest tests by ~10%. closes: #21297 Note: No README entries were added, because this sub-subsystem was already not documented in the README. ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? N/A
…21344) fixes #21254 The original issue was that Currently [ManagedRuleIdentifiers](https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-config.ManagedRuleIdentifiers.html) doesn't support identifier for this managed rule - eks-cluster-supported-version([EKS_CLUSTER_SUPPORTED_VERSION](https://docs.aws.amazon.com/config/latest/developerguide/eks-cluster-supported-version.html)) - eks-cluster-oldest-version eks-cluster-oldest-supported-version([EKS_CLUSTER_OLDEST_SUPPORTED_VERSION](https://docs.aws.amazon.com/config/latest/developerguide/eks-cluster-oldest-supported-version.html)) To solve this problem, it was necessary to define identifiers and type information to L2 Constructs. - Add the following missing identifiers to `ManagedRuleIdentifiers`. - EKS_CLUSTER_OLDEST_SUPPORTED_VERSION - EKS_CLUSTER_SUPPORTED_VERSION - Add the following missing types in `ResourceType` - AWS::EKS::Cluster - and test code for these identifiers and types to work ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
AWS has changed the [ARN format for ECS](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/ecs-account-settings.html#ecs-resource-ids). Currently, CDK doesn't return the correct values/ARNs if the new ARN format is used in ECS. Changed methods: - `Ec2Service.fromEc2ServiceAttributes()` - `Ec2Service.fromEc2ServiceArn()` - `FargateService.fromFargateServiceAttributes()` - `FargateService.fromFargateServiceArn()` The logic automatically detects whether the old or new format is used. The format cannot be recognized automatically for tokenized values. Therefore the feature flag `ECS_ARN_FORMAT_INCLUDES_CLUSTER_NAME` is introduced, which controls whether the old or the new format should be used. In `Ec2Service.fromEc2ServiceAttributes()` and `FargateService.fromFargateServiceAttributes()` an ARN is created. In these methods the feature flag be considered to construct the ARN in the correct format. Closes #16634. Closes #18137. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mergify
bot
dismissed
TheRealAmazonKendra’s stale review
Pull request has been modified.
|
Sorry, I seem to have made a bit of a mess of updating the pull request with recent changes in main... I updated my fork, merged main into my branch, and then made my README change, as requested, but this now makes the PR look like it has a lot of changes in it, most of which are already present in main. What do I do? |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
I think I've managed to improve things a bit. The number of changes is back now to what I'd expect, although the commit log's a bit of a mess. I hope that doesn't matter too much and the merge does the right thing. |
TheRealAmazonKendra
approved these changes
Jul 28, 2022
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
josephedward
pushed a commit
to josephedward/aws-cdk
that referenced
this pull request
Aug 30, 2022
---- closes aws#21288 The LustreFilesystem construct already supports a backing S3 bucket, through the importPath/exportPath parameters. CloudFormation supports an AutoImportPolicy parameter, to perform this import automatically and continuously if required. Currently, the L2 construct does not allow this parameter to be set. This PR adds that capability. ### All Submissions: * [yes] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [no] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [yes] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [yes] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #21288
The LustreFilesystem construct already supports a backing S3 bucket, through the importPath/exportPath parameters.
CloudFormation supports an AutoImportPolicy parameter, to perform this import automatically and continuously if required. Currently, the L2 construct does not allow this parameter to be set. This PR adds that capability.
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license