feat(redshift-alpha): add support for RA3.large node type #31637

AsadBinImtiaz · 2024-10-03T17:40:20Z

Issue # (if applicable)

Closes #31634.

Reason for this change

add support for RA3.large node type

Description of changes

extended the NodeType enum in ClusterProps.nodeType to include RA3.large

Description of how you validated changes

ran all tests

Checklist

[ x ] My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

… type

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

ashishdhingra · 2024-10-03T21:34:17Z

The value ra3.large for NodeType is not yet available for AWS::Redshift::Cluster resource in CloudFormation per aws-redshift-cluster.json. This schema JSON file was last updated 2 months ago as of now. Please wait until the schema is updated and CloudFormation resource accepts ra3.large as valid NodeType.

…dshift node type

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

AsadBinImtiaz · 2024-10-04T13:01:57Z

Hi @ashishdhingra ,

Thank you for the feedback. I understand that the aws-redshift-cluster.json schema file has not been updated yet. However, I have successfully created an RA3.large Redshift cluster using the CDK in my integration test, which indicates that CloudFormation is indeed accepting RA3.large as a valid node type.

Here are the steps I followed:

I created a CDK stack using the changes in my PR, specifying RA3.large as the NodeType.
The stack successfully deployed in my AWS account, and the Redshift cluster was provisioned without issues.
The integration test passed, confirming that CloudFormation accepted RA3.large as a valid NodeType.

Would it be possible that the CloudFormation schema and the documentation haven't been updated yet, even though the backend already supports this new instance type?

aws-cdk-automation · 2024-10-21T00:12:21Z

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

…support-ra3-large-node-type * 'main' of github.com:AsadBinImtiaz/aws-cdk: (87 commits) feat(events): dead letter queue for an Event Bus (aws#30628) feat(rds): support local write forwarding for an aurora PostgreSQL cluster (aws#31803) fix(stepfunctions-tasks): stateMachine construct doesn't generate a valid policy for default StateMachineRole (aws#31801) feat(efs): allow AccessPoint to set client token (aws#31184) feat(s3): support `transitionDefaultMinimumObjectSize` for life cycle (aws#31778) chore: remove legacy unused job for v2 migration (aws#31809) chore(s3): add validation on required properties for lifecycle rules (aws#31806) feat: update L1 CloudFormation resource definitions (aws#31800) feat(cognito): support `emailVerified` for `AttributeMapping` interface (aws#31632) feat(kms): allow `fromLookup` method to return dummy key if target key was not found (aws#31676) feat(iam): allow creating service principal using custom name (aws#31793) chore(lambda-go-alpha): update docker base image (aws#31766) feat(kinesisfirehose-alpha): refactor sourceStream property to support multiple types of sources (aws#31723) feat(fsx): specify file system type version for the Lustre file system (aws#31136) feat(dynamodb): enable contributor insights for global secondary index (aws#30560) feat(ec2): disable api termination (aws#30620) feat(pipes-targets): add CloudWatch Logs (aws#30665) feat(pipes-enrichments): support API destination enrichment (aws#31312) chore(mergify): move deprecated parameters from `pull_request_rules` to `queue_rules` (aws#31775) chore(rds): support 11.4.3 engine version for MariaDB (aws#31769) ... # Conflicts: # packages/aws-cdk-lib/cx-api/FEATURE_FLAGS.md

tools/@aws-cdk/eslint-plugin/lib/private/import-cache.js

…support-ra3-large-node-type * 'main' of github.com:AsadBinImtiaz/aws-cdk: chore(lambda-nodejs): grammatical correction in statement reg bundleAwsSDK (aws#31839) chore(kinesisfirehose-alpha): update README with name changes and clarifications (aws#31840) docs(lambda): fix some typos in function (aws#31824) chore: update CHANGELOG.v2.md feat(iot): scheduled audit (aws#31776) chore(release): 2.163.0 feat(cli): garbage collect s3 assets (under `--unstable` flag) (aws#31611) fix(scheduler-alpha): remove `targetOverrides` prop from Schedule (aws#31799) fix(s3): add support for uppercase characters in legacy bucket names (aws#31813)

…support-ra3-large-node-type * 'main' of github.com:AsadBinImtiaz/aws-cdk: (73 commits) revert: feat(cdk): update tsconfig to more modern settings in typescript init templates (aws#31953) chore(kinesisfirehose-alpha): set module and destinations module to developer preview (aws#31952) fix(cli): ecr garbage collection hangs when repository has no images (aws#31951) feat(pipes-targets): add SageMaker (aws#30696) feat(apprunner): support vpc ingress connection (aws#30623) feat(bootstrap): delete noncurrent versions after 30 days (aws#31949) chore: fix C# build (aws#31946) chore(scheduler-alpha): minor doc updates (aws#31939) fix(location): remove base class from PlaceIndex class (aws#31287) chore: make the Amplify integration tests respect AWS region assignments (aws#31944) feat(cdk): update tsconfig to more modern settings in typescript init templates (aws#31927) chore(tools): update README for spec2cdk with an example (aws#31935) fix(assertions): throw error or warn when `synth` is called multiple times on mutated construct tree (aws#31865) chore(cdk): increase coverage limits (aws#31936) chore(cli): add image to gc docs and document race condition (aws#31925) fix(s3-assets): cannot publish a file without extension (aws#30597) chore: add Amplify integration tests (aws#31921) fix(scheduler-alpha): too many KMS permissions granted (aws#31923) fix(sqs): queue with `fifo: false` does not deploy (aws#31922) fix(scheduler-alpha): scheduler input always get transformed to string with extra double quotes (aws#31894) ...

…support-ra3-large-node-type * 'main' of github.com:AsadBinImtiaz/aws-cdk: (58 commits) feat(rds): support minor versions for RDS for SQL Server (aws#32055) feat(rds): support minor engine versions for oracle (aws#32058) feat(lambda): add Python 3.13 runtime (aws#32054) chore(codepipeline): generate stack name in codepipeline when stack name is unresolved token (aws#31967) feat(elasticloadbalancingv2): enable zonal shift for network load balancer (aws#31990) feat(service-catalog): allow Product Stack to override analytics reporting and stack descriptions (aws#31985) fix(scheduler-targets-alpha): add dlq policy to execution role instead of queue policy (aws#32032) feat(ivs): support recording configuration for channel (aws#31899) docs(core): fix typo in `Stack` (aws#32047) chore(release): 2.166.0 fix: deploy-time stack tags cause synthesis to fail (aws#32041) chore(scheduler-alpha): increase unit test coverage (aws#32033) feat(synthetics): add `artifactS3Encryption` property to the Canary Construct. (aws#30197) chore(docs): fix invalid anchor links in DESIGN_GUIDELINES (aws#31997) chore(synthetics): runtime puppeteer 9_1 (aws#32026) chore(doc): update ROADMAP.md (aws#32029) chore(scheduler-alpha): clean up readme (aws#32034) chore: add 5d to mergify and merit badger (aws#32031) chore: add saiyush to core contributors (aws#32030) chore(ec2): add missing interface VPC endpoint (aws#31991) ...

… type

AsadBinImtiaz · 2024-11-08T18:48:53Z

Waiting on PR: cdklabs/awscdk-service-spec#1421

AsadBinImtiaz · 2024-11-27T14:44:32Z

The missing value ra3.large for is now available in AWS::Redshift::Cluster

mazyu36

Thank for the contribution.
Some minor comments.

packages/@aws-cdk/aws-redshift-alpha/test/integ.cluster-nodetype.ts

...luster-nodetype.ts.snapshot/RA3LargeNodeIntegTestDefaultTestDeployAssert1EF91947.assets.json

…pe.ts Co-authored-by: Matsuda <yiyth.fcb6@gmail.com>

mazyu36

Thanks for the modifications. LGTM

codecov · 2024-12-06T11:00:53Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.67%. Comparing base (57cbd86) to head (a414361).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #31637   +/-   ##
=======================================
  Coverage   78.67%   78.67%           
=======================================
  Files         107      107           
  Lines        7237     7237           
  Branches     1329     1329           
=======================================
  Hits         5694     5694           
  Misses       1357     1357           
  Partials      186      186

Flag	Coverage Δ
suite.unit	`78.67% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	`78.67% <ø> (ø)`

gracelu0

Thanks for contributing!

mergify · 2024-12-07T00:57:56Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2024-12-07T02:32:25Z

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

🟠 AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

gracelu0 · 2024-12-09T19:24:26Z

@Mergifyio update

mergify · 2024-12-09T19:25:02Z

update

✅ Branch has been successfully updated

mergify · 2024-12-09T19:57:43Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2024-12-09T20:02:16Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2024-12-10T17:53:17Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: a414361
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2024-12-10T17:53:40Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions · 2024-12-10T17:57:41Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

feat(redshift-alpha): issue aws#31634: add support for RA3.large node…

41b2a51

… type

aws-cdk-automation requested a review from a team October 3, 2024 17:41

github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK feature-request A feature should be added or improved. p2 labels Oct 3, 2024

aws-cdk-automation previously requested changes Oct 3, 2024

View reviewed changes

feat(redshift-alpha): issue aws#31634: added integration tests for re…

a114c31

…dshift node type

feat(redshift-alpha): issue aws#31634: merge conflict resolved

9c311a3

Filtzkowski-Robert-bah approved these changes Oct 10, 2024

View reviewed changes

pahud reviewed Oct 21, 2024

View reviewed changes

tools/@aws-cdk/eslint-plugin/lib/private/import-cache.js Outdated Show resolved Hide resolved

Imtiaz Asad Bin, INI-DNA-DL added 2 commits October 22, 2024 12:56

github-actions bot mentioned this pull request Nov 1, 2024

Monthly PR metrics report #31972

Closed

AsadBinImtiaz mentioned this pull request Nov 8, 2024

feat(sources): add ra3.large to Redshift NodeType valid values cdklabs/awscdk-service-spec#1421

Open

Imtiaz Asad Bin, INI-DNA-DL added 2 commits November 8, 2024 17:31

feat(redshift-alpha): issue aws#31634: add support for RA3.large node…

5399e65

… type

Merge branch 'main' into feature/support-ra3-large-node-type

71f61f6

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 8, 2024

mazyu36 reviewed Nov 28, 2024

View reviewed changes

packages/@aws-cdk/aws-redshift-alpha/test/integ.cluster-nodetype.ts Outdated Show resolved Hide resolved

...luster-nodetype.ts.snapshot/RA3LargeNodeIntegTestDefaultTestDeployAssert1EF91947.assets.json Outdated Show resolved Hide resolved

AsadBinImtiaz and others added 3 commits November 29, 2024 09:06

Update packages/@aws-cdk/aws-redshift-alpha/test/integ.cluster-nodety…

d786bd2

…pe.ts Co-authored-by: Matsuda <yiyth.fcb6@gmail.com>

Merge branch 'main' into feature/support-ra3-large-node-type

79f899e

feat(redshift-alpha): issue aws#31634: changes based on pr comments

5682baf

AsadBinImtiaz requested a review from mazyu36 November 29, 2024 08:53

mazyu36 approved these changes Nov 29, 2024

View reviewed changes

gracelu0 changed the title ~~feat(redshift-alpha): issue #31634: add support for RA3.large node type~~ feat(redshift-alpha): add support for RA3.large node type Dec 6, 2024

github-actions bot added the effort/small Small work item – less than a day of effort label Dec 6, 2024

aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Dec 6, 2024

gracelu0 approved these changes Dec 7, 2024

View reviewed changes

gracelu0 mentioned this pull request Dec 7, 2024

fix: added a missing NodeType to Redshift cluster.ts #32408

Closed

1 task

Merge branch 'main' into feature/support-ra3-large-node-type

aa1a754

Merge branch 'main' into feature/support-ra3-large-node-type

75b9e01

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 9, 2024

Merge branch 'main' into feature/support-ra3-large-node-type

a414361

mergify bot merged commit ce0e09f into aws:main Dec 10, 2024
17 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(redshift-alpha): add support for RA3.large node type #31637

feat(redshift-alpha): add support for RA3.large node type #31637

AsadBinImtiaz commented Oct 3, 2024

aws-cdk-automation left a comment

ashishdhingra commented Oct 3, 2024

AsadBinImtiaz commented Oct 4, 2024

aws-cdk-automation commented Oct 21, 2024

AsadBinImtiaz commented Nov 8, 2024

AsadBinImtiaz commented Nov 27, 2024

mazyu36 left a comment

mazyu36 left a comment

codecov bot commented Dec 6, 2024 •

edited

Loading

gracelu0 left a comment

mergify bot commented Dec 7, 2024

mergify bot commented Dec 7, 2024

gracelu0 commented Dec 9, 2024

mergify bot commented Dec 9, 2024

mergify bot commented Dec 9, 2024

mergify bot commented Dec 9, 2024

aws-cdk-automation commented Dec 10, 2024

mergify bot commented Dec 10, 2024

github-actions bot commented Dec 10, 2024

feat(redshift-alpha): add support for RA3.large node type #31637

feat(redshift-alpha): add support for RA3.large node type #31637

Conversation

AsadBinImtiaz commented Oct 3, 2024

Issue # (if applicable)

Reason for this change

Description of changes

Description of how you validated changes

Checklist

aws-cdk-automation left a comment

Choose a reason for hiding this comment

ashishdhingra commented Oct 3, 2024

AsadBinImtiaz commented Oct 4, 2024

aws-cdk-automation commented Oct 21, 2024

AsadBinImtiaz commented Nov 8, 2024

AsadBinImtiaz commented Nov 27, 2024

mazyu36 left a comment

Choose a reason for hiding this comment

mazyu36 left a comment

Choose a reason for hiding this comment

codecov bot commented Dec 6, 2024 • edited Loading

Codecov Report

gracelu0 left a comment

Choose a reason for hiding this comment

mergify bot commented Dec 7, 2024

mergify bot commented Dec 7, 2024

gracelu0 commented Dec 9, 2024

mergify bot commented Dec 9, 2024

✅ Branch has been successfully updated

mergify bot commented Dec 9, 2024

mergify bot commented Dec 9, 2024

aws-cdk-automation commented Dec 10, 2024

AWS CodeBuild CI Report

mergify bot commented Dec 10, 2024

github-actions bot commented Dec 10, 2024

codecov bot commented Dec 6, 2024 •

edited

Loading