Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added AWS logo with min retina size #461

Merged
merged 1 commit into from
Apr 19, 2019
Merged

Added AWS logo with min retina size #461

merged 1 commit into from
Apr 19, 2019

Conversation

arebee
Copy link

@arebee arebee commented Apr 4, 2019

Size meets brand guidelines.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Infrastructure (change which improves the lifecycle management (CI/CD, build, package, deploy, lint, etc) of the application, but does not change functionality.)
  • Technical debt (change which improves the maintainability of the codebase, but does not change functionality)
  • Testing (change which modifies or adds test coverage, but does not change functionality)
  • Documentation (change which modifies or adds documentation, but does not change functionality)

Description

Added a logo file and updated the package manifest to add a reference to the icon path.

Motivation and Context

Make it pretty when browsing for this extension in the gallery.

Related Issue(s)

Testing

None

Screenshots (if appropriate)

Checklist

  • I have read the README document
  • I have read the CONTRIBUTING document
  • My code follows the code style of this project
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Added AWS logo with min retina size
d2c3e9a 
Size meets brand guidelines.
awschristou
awschristou requested changes Apr 4, 2019
View reviewed changes
Copy link
Contributor

@awschristou awschristou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the PR @arebee - we absolutely want to get an icon into the extension page. We have to ensure our image assets are properly sourced for open source usage. I've requested the asset internally now, is it alright with you if I bring your commit into a separate branch and apply the proper image once we have it?

@arebee
Copy link
Author

arebee commented Apr 5, 2019 via email

@awschristou awschristou changed the base branch from develop to awschristou/add-icon April 19, 2019 15:08
awschristou
awschristou reviewed Apr 19, 2019
View reviewed changes
Copy link
Contributor

@awschristou awschristou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the assets now. I'll bring those in on a separate branch and spin up a new PR when it is ready.

@awschristou awschristou merged commit d16e8eb into aws:awschristou/add-icon Apr 19, 2019
awschristou pushed a commit that referenced this pull request Apr 19, 2019
@arebee @awschristou
Added AWS logo with min retina size (#461)
9e933c5 
* 128x128 and 256x256 aws logo icon have been sourced from the internal design team
@awschristou awschristou mentioned this pull request Apr 19, 2019
Merged
12 tasks
awschristou pushed a commit that referenced this pull request Apr 19, 2019
@arebee @awschristou
Added AWS logo with min retina size (#461)
81f4e4e 
* 128x128 and 256x256 aws logo icon have been sourced from the internal design team
awschristou added a commit that referenced this pull request Apr 19, 2019
@awschristou
Added AWS logo with min retina size (#461) (#498)
19ec36a 
* 128x128 and 256x256 aws logo icon have been sourced from the internal design team
mpiroc added a commit that referenced this pull request May 29, 2019
@mpiroc
Port 'Added AWS logo with min retina size (#461) (#498)' from develop.
0b34e33
mpiroc added a commit that referenced this pull request Jun 7, 2019
@mpiroc
Test PR: "Squash and Merge" with a merge commit already in the histor…
0800f31 
…y. (#599)

* Initial codelens implementation for C# (#477)

* Open sam template upon sam init (#481)

* C# run command (#488)

Added C# run command with some tests and some refactoring to the localLambdaRunner and pythonCodeRunner files. Additional work deemed out-of-scope for this feature can be found here: #507

* Prepare for .NET Core Debug implemention. (#513)

* Removing unused runtimes (#535)

* Implement "Debug Locally" code lens for .NET Core. (#552)

* Port changes from develop for eb07933..9c3d7c3.

* Fix npm audit issues.

* Port 'Switch away from Terminal to using Debug Console and Output tabs for local debug and run (#493)' from develop.

* Port 'Added AWS logo with min retina size (#461) (#498)' from develop.

* Port 'Handle port-waiting timeout; Catch Python debugging Errors (#494)' from develop.

* Python Path Mappings now provide both drive letter casings for Windows (#495)

* Port 'Explicitly show the Debug Console after each successful debugger attach (#496)' from develop.

* Port 'Prevent AWS Explorer context menu items from getting added to other extension/view menus (#506)' from develop

* Port 'Design for operations against resources attached to code pipelines (#503)' from develop.

* Port 'childProcess times out and dies if the debugger does not attach in time (#512)' from develop.

* Port 'Remove lambda views for Policy and Configuration (#505)' from develop.

* Port 'Normalizing telemetry (#534)' from develop.

* Port 'SAM calls that use AWS resources now correctly use an AWS profile (#554)' from develop.

* Port 'SAM CLI Validation Refactor (#555)' from develop.

* Port 'Fixes issue introduced in f9816c1 that caused the AWS Explorer context menu to disappear (#560)' from develop

* Port 'Added a help button to the sam init wizard's runtime selection step (#538)' from develop.

* Port 'Metrics overrides for result and duration (#562)Metrics overrides for result and duration (#562)' from develop.

* Port 'Added vs code task to run lint fixer (#561)' from develop.

* Port 'SAM CLI Validation at the start of Create New SAM App flow (#563)' from develop.

* Port 'Updated the message shown when SAM CLI is newer than valid range (#569)' from develop.

* Port 'SAM CLI Validation at the start of Deploy SAM App flow (#570)' from develop.

* Port 'Code Improvement: sam deploy calls (#571)' from develop.

* Port 'Code Improvement: sam package calls (#572)' from develop.

* Port 'Telemetry data includes active AWS account ID (if configured) (#557)' from develop.

* Port 'Code Improvement: sam deploy workflow (#573)' from develop.

* Port 'Code Improvement: Error handling on sam cli calls (#574)' from develop.

* Port 'Extension throws an error if the toolkitClientBuilder is not initialized before initial credential validation (#577)' from develop.

* Port 'addUserDataToContext throws an error if a profile's credentials are nonexistent (#579)' from develop.

* Port 'Ensure log folder exists prior to initialization (#583)' from develop.

* Port 'Adding help buttons to deploy workflow (#584)' from develop.

* Port 'Credentials are now passed to STS client correctly on validation. (#585)' from develop

* Port 'Add prettier formatter and git hook (#578)' from develop.

* Fix WAIT_FOR_DEBUGGER_MESSAGE for .NET Core.

* Disable prettier pre-commit hook, and fix linter issues introduced by prettier.

* Fix dotnet debug install issues on Mac, Linux (#592)

* Instead of installing VSDBG by manually invoking crossSpawn, use existing ChildProcess utility class.
* Simplify code by unconditionally installing debugger each time - the script is smart enough to determine if an install is needed.
* DockerContext outputs stdout to output channel
* Fix installing debugger on non-windows platforms

* Fix issue that caused templates.json to be ignored when invoking .NET Core functions. (#593)

* Address feedback from PR.
mpiroc added a commit that referenced this pull request Jun 7, 2019
@mpiroc
Merge pirocchi/dotnet/merge-develop into develop (#594)
4e43030 
Due to a series of misteps, we are squashing this entire feature branch into develop.

1. We allowed `feature/dotnet` to drift too far from `develop`, which required significant manual conflict resolution to resolve.
2. We should have squashed the conflict-resolution history *before* merging develop, but we did not. Therefore in order to squash the pre-merge commits, we would need to recreate the merge and re-resolve conflicts. This would reduce our confidence in the quality of the branch.

In the future:

1. We will regularly merge into feature branches to prevent drift.
2. If we do encounter a situation that involves manually porting, we will squash the ports *before* merging develop.

* Initial codelens implementation for C# (#477)

* Open sam template upon sam init (#481)

* C# run command (#488)

Added C# run command with some tests and some refactoring to the localLambdaRunner and pythonCodeRunner files. Additional work deemed out-of-scope for this feature can be found here: #507

* Prepare for .NET Core Debug implemention. (#513)

* Removing unused runtimes (#535)

* Implement "Debug Locally" code lens for .NET Core. (#552)

* Port changes from develop for eb07933..9c3d7c3.

* Fix npm audit issues.

* Port 'Switch away from Terminal to using Debug Console and Output tabs for local debug and run (#493)' from develop.

* Port 'Added AWS logo with min retina size (#461) (#498)' from develop.

* Port 'Handle port-waiting timeout; Catch Python debugging Errors (#494)' from develop.

* Python Path Mappings now provide both drive letter casings for Windows (#495)

* Port 'Explicitly show the Debug Console after each successful debugger attach (#496)' from develop.

* Port 'Prevent AWS Explorer context menu items from getting added to other extension/view menus (#506)' from develop

* Port 'Design for operations against resources attached to code pipelines (#503)' from develop.

* Port 'childProcess times out and dies if the debugger does not attach in time (#512)' from develop.

* Port 'Remove lambda views for Policy and Configuration (#505)' from develop.

* Port 'Normalizing telemetry (#534)' from develop.

* Port 'SAM calls that use AWS resources now correctly use an AWS profile (#554)' from develop.

* Port 'SAM CLI Validation Refactor (#555)' from develop.

* Port 'Fixes issue introduced in f9816c1 that caused the AWS Explorer context menu to disappear (#560)' from develop

* Port 'Added a help button to the sam init wizard's runtime selection step (#538)' from develop.

* Port 'Metrics overrides for result and duration (#562)Metrics overrides for result and duration (#562)' from develop.

* Port 'Added vs code task to run lint fixer (#561)' from develop.

* Port 'SAM CLI Validation at the start of Create New SAM App flow (#563)' from develop.

* Port 'Updated the message shown when SAM CLI is newer than valid range (#569)' from develop.

* Port 'SAM CLI Validation at the start of Deploy SAM App flow (#570)' from develop.

* Port 'Code Improvement: sam deploy calls (#571)' from develop.

* Port 'Code Improvement: sam package calls (#572)' from develop.

* Port 'Telemetry data includes active AWS account ID (if configured) (#557)' from develop.

* Port 'Code Improvement: sam deploy workflow (#573)' from develop.

* Port 'Code Improvement: Error handling on sam cli calls (#574)' from develop.

* Port 'Extension throws an error if the toolkitClientBuilder is not initialized before initial credential validation (#577)' from develop.

* Port 'addUserDataToContext throws an error if a profile's credentials are nonexistent (#579)' from develop.

* Port 'Ensure log folder exists prior to initialization (#583)' from develop.

* Port 'Adding help buttons to deploy workflow (#584)' from develop.

* Port 'Credentials are now passed to STS client correctly on validation. (#585)' from develop

* Port 'Add prettier formatter and git hook (#578)' from develop.

* Fix WAIT_FOR_DEBUGGER_MESSAGE for .NET Core.

* Disable prettier pre-commit hook, and fix linter issues introduced by prettier.

* Fix dotnet debug install issues on Mac, Linux (#592)

* Instead of installing VSDBG by manually invoking crossSpawn, use existing ChildProcess utility class.
* Simplify code by unconditionally installing debugger each time - the script is smart enough to determine if an install is needed.
* DockerContext outputs stdout to output channel
* Fix installing debugger on non-windows platforms

* Fix issue that caused templates.json to be ignored when invoking .NET Core functions. (#593)

* Address feedback from PR.
leigaol pushed a commit to leigaol/aws-toolkit-vscode that referenced this pull request Jun 28, 2022
@JadenSimon
Merge pull request aws#461 from aws/autoMerge/feature/vector
441078c 
Merge staging into feature/vector
leigaol added a commit to leigaol/aws-toolkit-vscode that referenced this pull request Jun 28, 2022
@leigaol @aws-toolkit-automation
@zixlin7 @fangwade007 @prateekch91 @gmeghrao
Consolas: Merge all features into feature/vector (aws#464)
19b5647 
* feat: integrate cognito idp with consolas

* fix: address pr feedback

* [Consolas][High] Consolas Security Scan UX for VSC and C9 (aws#402)

* Consolas security scan feature for VSC and C9

* Merge security scan nodes

* Update panel and commands titles

* Make re-scan for VSC in one line

* Extract activation of security scan into a function

* Webviewview panel & view title changes

* Adjust validation range in panel

* Address comments

* Use Command URI

* fix: update file name and identity pool ids

* chore: update consolas api model

* Swith to use @types/codicons (aws#414)

* feat: add consolas token input

* [Consolas][High] Add context truncation which uses dependency graph algorithm for java and python (aws#415)

* Consolas security scan feature for VSC and C9

* Merge security scan nodes

* Update panel and commands titles

* Make re-scan for VSC in one line

* Extract activation of security scan into a function

* Webviewview panel & view title changes

* Dependency graphs working solution

* Fixed working solution with java edge cases

* Integrate with StartScan command

* Clean code base and remove useless

* [Consolas][High] Consolas Security Scan UX for VSC and C9 (aws#402)

* Consolas security scan feature for VSC and C9

* Merge security scan nodes

* Update panel and commands titles

* Make re-scan for VSC in one line

* Extract activation of security scan into a function

* Webviewview panel & view title changes

* Adjust validation range in panel

* Address comments

* Use Command URI

* Swith to use @types/codicons

* Use vscode.Uri.file

* Use path.join

* Reduce property number

* Factory pattern for dependency graph

* Abstract some methods and the parent class

* Set timeout for context truncation

* feat: update UX for consolas token input

* fix: address pr feedback

* fix: throw if access token is undefined

* refactor: accountless commands and nodes

* [Consolas][High] Follow up updates for PR-415 (aws#423)

* Address additional comments from PR-415

* Handle import static ...

* Simplify raw path jon statement

* Consolas Pagination

* Paginated fully working with automatic trigger

* Fix old test cases

* Add pagination for manual trigger

* Add status bar Item for Consolas for pagination

* Exit scenerios for pagination

* ChangeRecommendationname&Exitstatefix

* NextResponsetestcase

* feat: add access token to request header

* fix: invalidate the access token on validation error

* Statusbarfix

* Minor bug fixes

* Updated inline to singleton class and fixed test cases

* resolveconflicts

* remove global var telemetry context

* fix: hide accountless for cloud9

* Bug: status bar not visible after VsCode restart

* update

* fix bug in test cases

* add package-lock.json change

* remove inline completion global variable

* Add Prod endpoint back to consolas

* [Consolas][High] CodeScan E2E working solution (with dev endpoint) (aws#431)

* Address additional comments from PR-415

* Handle import static ...

* Simplify raw path jon statement

* E2E working solution plus down-to file level truncation for Java

* Address comments

* Updated sdk model

* Use pageableToCollection for listing

* Refactor based on comments

* add hack for access token

* fix bug

* Bug fixing and one way navigation

* Testcasefix

* Update consolas client

* fix bugs

* remove unnecessary func

* update service-2

* Missingheaderconsolas.ts

* fix weird code

alpha  build

refactor

debugging typeahead

debug misc UI bug; typeahead

no concurrent auto t

fix typeahead bug

fix test cases

fix max result bug

remove max Result for ListReco

Merge code scan command to basicCommands

fix OT webview display empty reco bug

gamma endpoint

fix cfg bug

fix bug of cursor position after format

clean up

in fixing unit tests

fix unit test

update alpha/gamma endpoint

no CG in C9

prod endpoint

fix(util): update AsyncCollection with better types aws#2657

fix(stepFunctions): bump amazon-states-language-service dependency to ^1.7.2 (aws#2660)

* Bump amazon-states-language-service dependency to ^1.7.2
* Add changelog entry
fix(git): prevent users from passing additional flags to ls-remote (aws#2661)

before:
error: unknown option `test'

after:
fatal: strange pathname '--test' blocked
fix(cdk): address more C9 edge-cases aws#2662

feat(runtimes): nodejs16.x aws#2628

Merge branch 'feature/vector' into autoMerge/feature/vector
Merge pull request aws#461 from aws/autoMerge/feature/vector

Merge staging into feature/vector
Merge branch 'feature/vector' into pentesting_fixes
try fix unit test bug in cloud

Merge branch 'pentesting_fixes' of github.com:leigaol/aws-toolkit-vscode-staging into pentesting_fixes

fix perf not found bug in unit test

feat: add optout support

fix: add resume icon

add performance in recHandler

resolve conflict

fix: fix input value when re-enter

Fix standalone python file use case

fix(performance): Explicitly include items in the vsix aws#2669

closes aws#1899
Merge staging into feature/vector

Merge branch 'feature/vector' into pentesting_fixes
Skip build/ symbolic link for python project

Telemetry pagination (#4)

* Adding Pagination Telemetry changes

* pagination SuggestionIndex change

* Paginationprogress change
fix weird code

alpha  build

no concurrent auto t

fix typeahead bug

fix test cases

fix max result bug

remove max Result for ListReco

Merge code scan command to basicCommands

fix OT webview display empty reco bug

update alpha/gamma endpoint

no CG in C9

fix(util): update AsyncCollection with better types aws#2657

fix(stepFunctions): bump amazon-states-language-service dependency to ^1.7.2 (aws#2660)

* Bump amazon-states-language-service dependency to ^1.7.2
* Add changelog entry
fix(git): prevent users from passing additional flags to ls-remote (aws#2661)

before:
error: unknown option `test'

after:
fatal: strange pathname '--test' blocked
fix(cdk): address more C9 edge-cases aws#2662

feat(runtimes): nodejs16.x aws#2628

Merge branch 'feature/vector' into autoMerge/feature/vector
Merge pull request aws#461 from aws/autoMerge/feature/vector

Merge staging into feature/vector
prod endpoint

Merge branch 'feature/vector' into pentesting_fixes
try fix unit test bug in cloud

Merge branch 'pentesting_fixes' of github.com:leigaol/aws-toolkit-vscode-staging into pentesting_fixes

fix perf not found bug in unit test

fix: add resume icon

add performance in recHandler

resolve conflict

fix: fix input value when re-enter

Fix standalone python file use case

fix(performance): Explicitly include items in the vsix aws#2669

closes aws#1899
Merge staging into feature/vector

Merge branch 'feature/vector' into pentesting_fixes
Skip build/ symbolic link for python project

Telemetry pagination (#4)

* Adding Pagination Telemetry changes

* pagination SuggestionIndex change

* Paginationprogress change

Merge branch 'feature/vector' into pentesting_fixes
Remvoe security scan panel from C9

Merge branch 'pentesting_fixes' of https://github.com/leigaol/aws-toolkit-vscode-staging into pentesting_fixes

BugFix: mark Accept undo/redo stack as false

Merge pull request aws#5 from leigaol/acceptRecomm_fix

BugFix: mark Accept undo/redo stack as false
Merge branch 'pentesting_fixes' into feat/optout
Merge pull request aws#6 from zixlin7/feat/optout

feat: add optout support
Merge branch 'pentesting_fixes' of https://github.com/leigaol/aws-toolkit-vscode-staging into pentesting_fixes

ConsolasTracker Exception fix

* maxReco=1 for C9

Co-authored-by: aws-toolkit-automation <43144436+aws-toolkit-automation@users.noreply.github.com>
Co-authored-by: Zoe Lin <zoelin@amazon.com>
Co-authored-by: Wade Fang <90796612+fangwade007@users.noreply.github.com>
Co-authored-by: Zoe Lin <60411978+zixlin7@users.noreply.github.com>
Co-authored-by: Prateek Chauhan <prateekchauhan091@gmail.com>
Co-authored-by: Meghana Gunuganti <gmeghrao@amazon.com>
Co-authored-by: gmeghrao <92111456+gmeghrao@users.noreply.github.com>
Co-authored-by: Prateek Chauhan <48580344+prateekch91@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awschristou awschristou awschristou requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arebee @awschristou