Added a help button to the sam init wizard's runtime selection step

[bryceitoc9]

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Infrastructure (change which improves the lifecycle management (CI/CD, build, package, deploy, lint, etc) of the application, but does not change functionality.)
• Technical debt (change which improves the maintainability of the codebase, but does not change functionality)
• Testing (change which modifies or adds test coverage, but does not change functionality)
• Documentation (change which modifies or adds documentation, but does not change functionality)

Description

Adding help buttons to our wizards with direct links to documentation. Looking to add more as part of this PR.

DONE:

• Button on runtime selection stage of Create New SAM Application wizard.
  • Links to https://docs.aws.amazon.com/toolkit-for-vscode/latest/userguide/create-sam.html
  • Reads as Lambda runtimes currently supported by the AWS Toolkit for VS Code. Click for more information.

Motivation and Context

Users might be confused by some of our prompts (especially regarding AWS-specific features). This provides direct links to give instant context.

Related Issue(s)

#530

Testing

Tested light and dark themes, icon appears in wizard.

Screenshots (if appropriate)

Checklist

• I have read the README document
• I have read the CONTRIBUTING document
• My code follows the code style of this project
• I have added tests to cover my changes
• All new and existing tests passed
• A short description of the change has been added to the CHANGELOG

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[mpiroc]

We should try to avoid global init functions like this where possible. The init wizard is only used in createNewSamApp, which already has the extension context available. Suggest instead to:

1. Replace context: Pick<vscode.ExtensionContext, 'globalState'> with context: Pick<vscode.ExtensionContext, 'globalState' | 'asAbsolutePath'> in the signature of createNewSamApp.
2. Add the following to samInitWizard.ts:

type CreateNewSamAppWizardArguments = Pick<vscode.ExtensionContext, 'asAbsolutePath'>
...
public constructor(
    private readonly args: CreateNewSamAppWizardArguments,
    ...
) {

3. Pass args.asAbsolutePath to promptUserForRuntime.

[bryceitoc9]

Do we think that this or other custom buttons might be used outside the SAM app? I positioned the buttons.ts file in a way that it can be used in a more generic fashion, and so that way we can add additional buttons with different icons.

Are there any ways we could make this happen with relative paths instead of the extension absolute path?

If the answers are no and no, then a big 👍 to the suggestion.

[bryceitoc9]

Not adding additional tests to the samInitWizard as I don't want to add any tests that open external URLs.

[codecov-io]

Codecov Report

Merging #538 into develop will decrease coverage by 0.01%.
The diff coverage is 48%.

@@             Coverage Diff             @@
##           develop     #538      +/-   ##
===========================================
- Coverage    54.23%   54.21%   -0.02%     
===========================================
  Files          109      110       +1     
  Lines         4276     4296      +20     
  Branches       647      651       +4     
===========================================
+ Hits          2319     2329      +10     
- Misses        1957     1967      +10

Impacted Files	Coverage Δ
src/lambda/lambdaTreeDataProvider.ts	47.36% <0%> (ø)	⬆️
src/shared/ui/buttons.ts	100% <100%> (ø)
src/shared/constants.ts	100% <100%> (ø)	⬆️
src/lambda/wizards/samInitWizard.ts	35.22% <28.57%> (-1.62%)	⬇️
src/lambda/commands/createNewSamApp.ts	18.46% <33.33%> (-0.29%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61d1102...4278776. Read the comment docs.

[awschristou]

Taking PR out of approved state to review latest commit
(Edit: Oops, this comment didn't prevent merge.)

[awschristou]

Taking PR out of approved state to prevent merge until the latest commits are reviewed

[mpiroc]

This is still part of the context for CreateNewSamAppWizard, so it shouldn't be a separate argument.

Option 1: Make the vscode context a property of the wizard context

export interface CreateNewSamAppWizardContext {
    ...
    vscodeContext: Pick<vscode.ExtensionContext, 'asAbsolutePath' | 'globalState'>
}

Option 2: Merge the vscode context into the wizard context

interface CreateNewSamAppWizardContext { /* unchanged */ }
type MergedContext = CreateNewSamAppWizardContext & Pick<vscode.ExtensionContext, 'asAbsolutePath' | 'globalState'>
export { MergedContext as CreateNewSamAppWizardContext }

Option 3: Make CreateNewSamAppWizardContext derive from the extension context.

export interface CreateNewSamAppWizardContext implements Pick<vscode.ExtensionContext, 'asAbsolutePath' | 'globalState'> { /* unchanged */ }