Merge pirocchi/dotnet/merge-develop into develop #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added C# run command with some tests and some refactoring to the localLambdaRunner and pythonCodeRunner files. Additional work deemed out-of-scope for this feature can be found here: #507
…s for local debug and run (#493)' from develop.
…r attach (#496)' from develop.
…ther extension/view menus (#506)' from develop
…nes (#503)' from develop.
… in time (#512)' from develop.
…le (#554)' from develop.
…context menu to disappear (#560)' from develop
…step (#538)' from develop.
…es for result and duration (#562)' from develop.
…itialized before initial credential validation (#577)' from develop.
… are nonexistent (#579)' from develop.
…n. (#585)' from develop
* Instead of installing VSDBG by manually invoking crossSpawn, use existing ChildProcess utility class. * Simplify code by unconditionally installing debugger each time - the script is smart enough to determine if an install is needed. * DockerContext outputs stdout to output channel * Fix installing debugger on non-windows platforms
… Core functions. (#593)
Codecov Report
@@ Coverage Diff @@
## develop #594 +/- ##
==========================================
- Coverage 55.82% 54.9% -0.92%
==========================================
Files 115 117 +2
Lines 4498 4655 +157
Branches 681 692 +11
==========================================
+ Hits 2511 2556 +45
- Misses 1987 2099 +112
Continue to review full report at Codecov.
|
awschristou
reviewed
Jun 5, 2019
awschristou
reviewed
Jun 5, 2019
awschristou
requested changes
Jun 5, 2019
awschristou
approved these changes
Jun 6, 2019
bryceitoc9
approved these changes
Jun 7, 2019
| @@ -271,7 +259,11 @@ function enhanceAwsCloudFormationInstructions( | |||
| // and append region to assist in troubleshooting the error | |||
| // (command uses CLI configured value--users that don't know this and omit region won't see error) | |||
| // tslint:disable-next-line:max-line-length | |||
There was a problem hiding this comment.
Is this still necessary?
| 'java' | | ||
| 'ruby' | | ||
| 'ruby2.5' | ||
| 'dotnetcore2.0' |
There was a problem hiding this comment.
Should this be removed? You can't deploy new dotnetcore2.0 apps.
| 'java', | ||
| 'ruby', | ||
| 'ruby2.5' | ||
| 'dotnetcore2.0' |
| @@ -20,7 +20,7 @@ import { defaultMetricDatum } from '../telemetry/telemetryUtils' | |||
| import { toArrayAsync } from '../utilities/collectionUtils' | |||
| import { localize } from '../utilities/vsCodeUtils' | |||
|
|
|||
| export type Language = 'python' | 'javascript' | |||
| export type Language = 'python' | 'javascript' | 'csharp' | |||
There was a problem hiding this comment.
Nit: should we rename typescriptCodeLensProvider to javascriptCodeLensProvider?
There was a problem hiding this comment.
Out of scope for the feature branch merge
mpiroc
force-pushed
the
pirocchi/dotnet/merge-develop
branch
from
c51fb0f
to
ec8b88b
Compare
|
Due to a series of misteps, we are squashing this entire feature branch into develop.
In the future:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merge the feature branch pirocchi/dotnet/merge-develop back into develop.
Motivation and Context
The feature branch is complete.
Testing
develop, and mergemerge-developinto that branch.Checklist
Note: I will add a CHANGELOG entry and update this PR.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.