Removing unused runtimes #535

bryceitoc9 · 2019-05-06T18:59:54Z

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Infrastructure (change which improves the lifecycle management (CI/CD, build, package, deploy, lint, etc) of the application, but does not change functionality.)
Technical debt (change which improves the maintainability of the codebase, but does not change functionality)
Testing (change which modifies or adds test coverage, but does not change functionality)
Documentation (change which modifies or adds documentation, but does not change functionality)

Description

Removed runtimes that are unsupported by the current version of the AWS Toolkit for VS Code

Motivation and Context

Having additional runtimes in our Create Sam Application wizard gives the impression that we have full-stack support. Removing these removes the confusion; will add these back in as we add support.

Related Issue(s)

#322

Testing

Tests pass successfully. List only presents currently-supported options (see screenshot)

Screenshots (if appropriate)

Checklist

I have read the README document
I have read the CONTRIBUTING document
My code follows the code style of this project
I have added tests to cover my changes
All new and existing tests passed
A short description of the change has been added to the CHANGELOG

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

bryceitoc9 · 2019-05-06T19:04:45Z

src/lambda/models/samLambdaRuntime.ts

@@ -76,15 +53,6 @@ export function getFamily(runtime: string | undefined): SamLambdaRuntimeFamily {
        case 'dotnetcore':


We need to keep the generic names here for backwards compatibility with existing SAM templates since localLambdaRunner has functions that check against the runtime present in the SAM/Cloudformation template.

bryceitoc9 · 2019-05-06T19:06:03Z

src/lambda/models/samLambdaRuntime.ts

-            return SamLambdaRuntimeFamily.Java
-        case 'ruby2.5':
-        case 'ruby':
-            return SamLambdaRuntimeFamily.Ruby
        default:
            throw new Error(`Unrecognized runtime: '${runtime}'`)


I want to change this eventually to something like Unsupported runtime or Unsupported or unrecognized runtime since SAM does support the runtime. Not changing it here because there is a test in develop that depends on the text here: https://github.com/aws/aws-toolkit-vscode/blob/develop/src/test/lambda/utilities/getMainSourceFile.test.ts#L149

I like this idea, and would submit for consideration an UnsupportedRuntime Error class, containing the property runtime.

The more I'm thinking about this, the less I'm sure if it'd be useful. The only time the error would pop would be when the runtime is passed to this function (or something similar), which would mean that the caller should already know what runtime is being used.

mpiroc · 2019-05-06T20:37:57Z

src/lambda/models/samLambdaRuntime.ts

-    'java' |
-    'ruby' |
-    'ruby2.5'
+    'dotnetcore1.0'


Unfortunately, debugging is only supported for .NET Core 2.x.

awschristou · 2019-05-06T23:55:45Z

src/lambda/models/samLambdaRuntime.ts

-            return SamLambdaRuntimeFamily.Java
-        case 'ruby2.5':
-        case 'ruby':
-            return SamLambdaRuntimeFamily.Ruby
        default:
            throw new Error(`Unrecognized runtime: '${runtime}'`)


I like this idea, and would submit for consideration an UnsupportedRuntime Error class, containing the property runtime.

…y. (#599) * Initial codelens implementation for C# (#477) * Open sam template upon sam init (#481) * C# run command (#488) Added C# run command with some tests and some refactoring to the localLambdaRunner and pythonCodeRunner files. Additional work deemed out-of-scope for this feature can be found here: #507 * Prepare for .NET Core Debug implemention. (#513) * Removing unused runtimes (#535) * Implement "Debug Locally" code lens for .NET Core. (#552) * Port changes from develop for eb07933..9c3d7c3. * Fix npm audit issues. * Port 'Switch away from Terminal to using Debug Console and Output tabs for local debug and run (#493)' from develop. * Port 'Added AWS logo with min retina size (#461) (#498)' from develop. * Port 'Handle port-waiting timeout; Catch Python debugging Errors (#494)' from develop. * Python Path Mappings now provide both drive letter casings for Windows (#495) * Port 'Explicitly show the Debug Console after each successful debugger attach (#496)' from develop. * Port 'Prevent AWS Explorer context menu items from getting added to other extension/view menus (#506)' from develop * Port 'Design for operations against resources attached to code pipelines (#503)' from develop. * Port 'childProcess times out and dies if the debugger does not attach in time (#512)' from develop. * Port 'Remove lambda views for Policy and Configuration (#505)' from develop. * Port 'Normalizing telemetry (#534)' from develop. * Port 'SAM calls that use AWS resources now correctly use an AWS profile (#554)' from develop. * Port 'SAM CLI Validation Refactor (#555)' from develop. * Port 'Fixes issue introduced in f9816c1 that caused the AWS Explorer context menu to disappear (#560)' from develop * Port 'Added a help button to the sam init wizard's runtime selection step (#538)' from develop. * Port 'Metrics overrides for result and duration (#562)Metrics overrides for result and duration (#562)' from develop. * Port 'Added vs code task to run lint fixer (#561)' from develop. * Port 'SAM CLI Validation at the start of Create New SAM App flow (#563)' from develop. * Port 'Updated the message shown when SAM CLI is newer than valid range (#569)' from develop. * Port 'SAM CLI Validation at the start of Deploy SAM App flow (#570)' from develop. * Port 'Code Improvement: sam deploy calls (#571)' from develop. * Port 'Code Improvement: sam package calls (#572)' from develop. * Port 'Telemetry data includes active AWS account ID (if configured) (#557)' from develop. * Port 'Code Improvement: sam deploy workflow (#573)' from develop. * Port 'Code Improvement: Error handling on sam cli calls (#574)' from develop. * Port 'Extension throws an error if the toolkitClientBuilder is not initialized before initial credential validation (#577)' from develop. * Port 'addUserDataToContext throws an error if a profile's credentials are nonexistent (#579)' from develop. * Port 'Ensure log folder exists prior to initialization (#583)' from develop. * Port 'Adding help buttons to deploy workflow (#584)' from develop. * Port 'Credentials are now passed to STS client correctly on validation. (#585)' from develop * Port 'Add prettier formatter and git hook (#578)' from develop. * Fix WAIT_FOR_DEBUGGER_MESSAGE for .NET Core. * Disable prettier pre-commit hook, and fix linter issues introduced by prettier. * Fix dotnet debug install issues on Mac, Linux (#592) * Instead of installing VSDBG by manually invoking crossSpawn, use existing ChildProcess utility class. * Simplify code by unconditionally installing debugger each time - the script is smart enough to determine if an install is needed. * DockerContext outputs stdout to output channel * Fix installing debugger on non-windows platforms * Fix issue that caused templates.json to be ignored when invoking .NET Core functions. (#593) * Address feedback from PR.

Due to a series of misteps, we are squashing this entire feature branch into develop. 1. We allowed `feature/dotnet` to drift too far from `develop`, which required significant manual conflict resolution to resolve. 2. We should have squashed the conflict-resolution history *before* merging develop, but we did not. Therefore in order to squash the pre-merge commits, we would need to recreate the merge and re-resolve conflicts. This would reduce our confidence in the quality of the branch. In the future: 1. We will regularly merge into feature branches to prevent drift. 2. If we do encounter a situation that involves manually porting, we will squash the ports *before* merging develop. * Initial codelens implementation for C# (#477) * Open sam template upon sam init (#481) * C# run command (#488) Added C# run command with some tests and some refactoring to the localLambdaRunner and pythonCodeRunner files. Additional work deemed out-of-scope for this feature can be found here: #507 * Prepare for .NET Core Debug implemention. (#513) * Removing unused runtimes (#535) * Implement "Debug Locally" code lens for .NET Core. (#552) * Port changes from develop for eb07933..9c3d7c3. * Fix npm audit issues. * Port 'Switch away from Terminal to using Debug Console and Output tabs for local debug and run (#493)' from develop. * Port 'Added AWS logo with min retina size (#461) (#498)' from develop. * Port 'Handle port-waiting timeout; Catch Python debugging Errors (#494)' from develop. * Python Path Mappings now provide both drive letter casings for Windows (#495) * Port 'Explicitly show the Debug Console after each successful debugger attach (#496)' from develop. * Port 'Prevent AWS Explorer context menu items from getting added to other extension/view menus (#506)' from develop * Port 'Design for operations against resources attached to code pipelines (#503)' from develop. * Port 'childProcess times out and dies if the debugger does not attach in time (#512)' from develop. * Port 'Remove lambda views for Policy and Configuration (#505)' from develop. * Port 'Normalizing telemetry (#534)' from develop. * Port 'SAM calls that use AWS resources now correctly use an AWS profile (#554)' from develop. * Port 'SAM CLI Validation Refactor (#555)' from develop. * Port 'Fixes issue introduced in f9816c1 that caused the AWS Explorer context menu to disappear (#560)' from develop * Port 'Added a help button to the sam init wizard's runtime selection step (#538)' from develop. * Port 'Metrics overrides for result and duration (#562)Metrics overrides for result and duration (#562)' from develop. * Port 'Added vs code task to run lint fixer (#561)' from develop. * Port 'SAM CLI Validation at the start of Create New SAM App flow (#563)' from develop. * Port 'Updated the message shown when SAM CLI is newer than valid range (#569)' from develop. * Port 'SAM CLI Validation at the start of Deploy SAM App flow (#570)' from develop. * Port 'Code Improvement: sam deploy calls (#571)' from develop. * Port 'Code Improvement: sam package calls (#572)' from develop. * Port 'Telemetry data includes active AWS account ID (if configured) (#557)' from develop. * Port 'Code Improvement: sam deploy workflow (#573)' from develop. * Port 'Code Improvement: Error handling on sam cli calls (#574)' from develop. * Port 'Extension throws an error if the toolkitClientBuilder is not initialized before initial credential validation (#577)' from develop. * Port 'addUserDataToContext throws an error if a profile's credentials are nonexistent (#579)' from develop. * Port 'Ensure log folder exists prior to initialization (#583)' from develop. * Port 'Adding help buttons to deploy workflow (#584)' from develop. * Port 'Credentials are now passed to STS client correctly on validation. (#585)' from develop * Port 'Add prettier formatter and git hook (#578)' from develop. * Fix WAIT_FOR_DEBUGGER_MESSAGE for .NET Core. * Disable prettier pre-commit hook, and fix linter issues introduced by prettier. * Fix dotnet debug install issues on Mac, Linux (#592) * Instead of installing VSDBG by manually invoking crossSpawn, use existing ChildProcess utility class. * Simplify code by unconditionally installing debugger each time - the script is smart enough to determine if an install is needed. * DockerContext outputs stdout to output channel * Fix installing debugger on non-windows platforms * Fix issue that caused templates.json to be ignored when invoking .NET Core functions. (#593) * Address feedback from PR.

Removed unused runtimes

cd7fe09

bryceitoc9 requested review from mpiroc and awschristou May 6, 2019 19:00

bryceitoc9 changed the base branch from develop to feature/dotnet May 6, 2019 19:03

bryceitoc9 commented May 6, 2019

View reviewed changes

mpiroc suggested changes May 6, 2019

View reviewed changes

Removing dotnetcore1.0

1eeffd0

mpiroc approved these changes May 6, 2019

View reviewed changes

awschristou approved these changes May 6, 2019

View reviewed changes

mpiroc merged commit c6855f0 into feature/dotnet May 8, 2019

mpiroc deleted the bryceito/cull-runtimes branch May 8, 2019 20:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removing unused runtimes #535

Removing unused runtimes #535

bryceitoc9 commented May 6, 2019

bryceitoc9 May 6, 2019

bryceitoc9 May 6, 2019

awschristou May 6, 2019

bryceitoc9 May 8, 2019

mpiroc May 6, 2019

bryceitoc9 May 6, 2019

awschristou May 6, 2019

		@@ -76,15 +53,6 @@ export function getFamily(runtime: string \| undefined): SamLambdaRuntimeFamily {
		case 'dotnetcore':

Removing unused runtimes #535

Removing unused runtimes #535

Conversation

bryceitoc9 commented May 6, 2019

Types of changes

Description

Motivation and Context

Related Issue(s)

Testing

Screenshots (if appropriate)

Checklist

License

bryceitoc9 May 6, 2019

Choose a reason for hiding this comment

bryceitoc9 May 6, 2019

Choose a reason for hiding this comment

awschristou May 6, 2019

Choose a reason for hiding this comment

bryceitoc9 May 8, 2019

Choose a reason for hiding this comment

mpiroc May 6, 2019

Choose a reason for hiding this comment

bryceitoc9 May 6, 2019

Choose a reason for hiding this comment

awschristou May 6, 2019

Choose a reason for hiding this comment