Move LBP storage handling to library #2015
Merged
+466
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
force-pushed
the
lbp-storage-lib
branch
from
8b2afa4 to
a084144
Compare
TomAFrench
force-pushed
the
lbp-storage-lib
branch
from
a084144 to
2961acd
Compare
11 tasks
* refactor: avoid repeated storage reads by passing explicit state * refactor: inline swap fee helpers
EndymionJkb
approved these changes
Nov 17, 2022
pkg/pool-weighted/contracts/lbp/LiquidityBootstrappingPoolStorageLib.sol
Outdated
Show resolved
Hide resolved
…ageLib.sol Co-authored-by: EndymionJkb <EndymionJkb@gmail.com>
TomAFrench
added a commit
that referenced
this pull request
Nov 22, 2022
* master: Move LBP storage handling to library (#2015) Add new AaveLinearPool deployment (#2012) Lint fix. (#2021) Introduce PoolRecoveryEnabler (#2013) Remove wrong dependency (#2018) Improve deployment signers (#2017) Use hardhat network helpers (#2016) Add index.ts for `deployments/src` (#2014) Split LBP contract into LBP and LBPSettings (#1979) Add IRateProviderPool (#2005) Add ExternalCallLib which checks revert data for malicious data (#2004)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR builds on #1979 to abstract all the logic interacting with pool state into a library.
Type of change
Checklist:
master, or there's a description of how to mergeIssue Resolution