Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint fix #2021

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Lint fix #2021

merged 1 commit into from
Nov 17, 2022

Conversation

jubeira
Copy link
Contributor

@jubeira jubeira commented Nov 17, 2022

@jubeira jubeira requested a review from TomAFrench November 17, 2022 16:25
@TomAFrench
Copy link
Contributor

not sure why the linter complains about this

There's supposed to be something like returns (uint256 rate) before the { for if we needed to use the rate inside the try block. I imagine it's not smart enough to only use one space if we don't have that bit of code.

@TomAFrench TomAFrench marked this pull request as ready for review November 17, 2022 16:28
@TomAFrench TomAFrench merged commit d249d60 into master Nov 17, 2022
@TomAFrench TomAFrench deleted the fix-lint branch November 17, 2022 16:28
TomAFrench added a commit that referenced this pull request Nov 22, 2022
* master:
  Move LBP storage handling to library (#2015)
  Add new AaveLinearPool deployment (#2012)
  Lint fix. (#2021)
  Introduce PoolRecoveryEnabler (#2013)
  Remove wrong dependency (#2018)
  Improve deployment signers (#2017)
  Use hardhat network helpers (#2016)
  Add index.ts for `deployments/src` (#2014)
  Split LBP contract into LBP and LBPSettings (#1979)
  Add IRateProviderPool (#2005)
  Add ExternalCallLib which checks revert data for malicious data (#2004)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants