Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve deployment signers #2017

Merged
merged 7 commits into from
Nov 16, 2022
Merged

Improve deployment signers #2017

merged 7 commits into from
Nov 16, 2022

Conversation

nventuro
Copy link
Contributor

Description

This is just some cleanup of unused features, plus supplying default arguments for the typical usecase.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented, including external interfaces
  • [x Tests are included for all code paths
  • The base branch is either master, or there's a description of how to merge

Issue Resolution

Merge after #2016

@nventuro nventuro requested a review from TomAFrench November 16, 2022 12:05
Base automatically changed from hh-network-helpers to master November 16, 2022 15:04
@nventuro nventuro merged commit ae345be into master Nov 16, 2022
@nventuro nventuro deleted the deploy-signers branch November 16, 2022 17:58
TomAFrench added a commit that referenced this pull request Nov 16, 2022
* master:
  Remove wrong dependency (#2018)
  Improve deployment signers (#2017)
  Use hardhat network helpers (#2016)
  Add index.ts for `deployments/src` (#2014)
TomAFrench added a commit that referenced this pull request Nov 16, 2022
* master:
  Remove wrong dependency (#2018)
  Improve deployment signers (#2017)
  Use hardhat network helpers (#2016)
TomAFrench added a commit that referenced this pull request Nov 22, 2022
* master:
  Move LBP storage handling to library (#2015)
  Add new AaveLinearPool deployment (#2012)
  Lint fix. (#2021)
  Introduce PoolRecoveryEnabler (#2013)
  Remove wrong dependency (#2018)
  Improve deployment signers (#2017)
  Use hardhat network helpers (#2016)
  Add index.ts for `deployments/src` (#2014)
  Split LBP contract into LBP and LBPSettings (#1979)
  Add IRateProviderPool (#2005)
  Add ExternalCallLib which checks revert data for malicious data (#2004)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants