Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hardhat network helpers #2016

Merged
merged 6 commits into from
Nov 16, 2022
Merged

Use hardhat network helpers #2016

merged 6 commits into from
Nov 16, 2022

Conversation

nventuro
Copy link
Contributor

Description

It's better to depend on this package than to send raw RPC requests. Additionally, this provides cleaner access to very handy functions, such as setCode.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented, including external interfaces
  • Tests are included for all code paths
  • The base branch is either master, or there's a description of how to merge

@nventuro nventuro requested a review from TomAFrench November 16, 2022 11:49
This was referenced Nov 16, 2022
@TomAFrench
Copy link
Contributor

Looks like this has caused the fork tests to hang.

@TomAFrench TomAFrench merged commit 2c5c8b1 into master Nov 16, 2022
@TomAFrench TomAFrench deleted the hh-network-helpers branch November 16, 2022 15:04
TomAFrench added a commit that referenced this pull request Nov 16, 2022
* master:
  Use hardhat network helpers (#2016)
TomAFrench added a commit that referenced this pull request Nov 16, 2022
* master:
  Remove wrong dependency (#2018)
  Improve deployment signers (#2017)
  Use hardhat network helpers (#2016)
  Add index.ts for `deployments/src` (#2014)
TomAFrench added a commit that referenced this pull request Nov 16, 2022
* master:
  Remove wrong dependency (#2018)
  Improve deployment signers (#2017)
  Use hardhat network helpers (#2016)
TomAFrench added a commit that referenced this pull request Nov 22, 2022
* master:
  Move LBP storage handling to library (#2015)
  Add new AaveLinearPool deployment (#2012)
  Lint fix. (#2021)
  Introduce PoolRecoveryEnabler (#2013)
  Remove wrong dependency (#2018)
  Improve deployment signers (#2017)
  Use hardhat network helpers (#2016)
  Add index.ts for `deployments/src` (#2014)
  Split LBP contract into LBP and LBPSettings (#1979)
  Add IRateProviderPool (#2005)
  Add ExternalCallLib which checks revert data for malicious data (#2004)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants