Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resurrect VCF conversion code #147

Merged
merged 5 commits into from
Feb 28, 2014
Merged

Resurrect VCF conversion code #147

merged 5 commits into from
Feb 28, 2014

Conversation

nealsid
Copy link

@nealsid nealsid commented Feb 25, 2014

No description provided.

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/161/

fnothaft
fnothaft reviewed Feb 25, 2014
View reviewed changes
adam-core/src/main/scala/edu/berkeley/cs/amplab/adam/converters/VariantContextConverter.scala
}


private case class AttrKey(adamKey: String, attrConverter: (Object => Object), hdrLine: VCFCompoundHeaderLine) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, I like this approach.

@fnothaft
Copy link
Member

Looks good to me! Solid work @nealsid.

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/163/

@nealsid
Copy link
Author

nealsid commented Feb 25, 2014

Jenkins, test this please.

@AmplabJenkins
Copy link

One or more automated tests failed
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/164/

@nealsid
Copy link
Author

nealsid commented Feb 26, 2014

Jenkins, test this please

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/165/

tdanford
tdanford reviewed Feb 27, 2014
View reviewed changes
adam-core/src/main/scala/edu/berkeley/cs/amplab/adam/converters/VariantContextConverter.scala
private def attrAsString(attr: Object):Object = attr match {
case a: String => a
}
// Recall that the mere
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a tail to this comment, that got cut off?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed, thanks for catching that.

This was referenced Feb 27, 2014
Merged
Merged
@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/178/

fnothaft added a commit that referenced this pull request Feb 28, 2014
@fnothaft
Merge pull request #147 from nealsid/vcf-work-vcf-conversion
c836a2d 
Resurrect VCF conversion code
@fnothaft fnothaft merged commit c836a2d into bigdatagenomics:vcf-work Feb 28, 2014
@fnothaft
Copy link
Member

Thanks @nealsid! Merged.

@nealsid nealsid deleted the vcf-work-vcf-conversion branch February 28, 2014 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nealsid @AmplabJenkins @fnothaft @massie @tdanford