Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vcf work concordance and genotype #151

Merged
merged 4 commits into from
Feb 28, 2014
Merged

Vcf work concordance and genotype #151

merged 4 commits into from
Feb 28, 2014

Conversation

nealsid
Copy link

@nealsid nealsid commented Feb 27, 2014

This PR has some utility classes for concordance as well as working with ADAMGenotypes. It is a superset of the other PRs and only the last commit needs to be reviewed for this one.
Thanks,
Neal

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/173/

@tdanford
Copy link
Contributor

It seems like some of the commits share the same name -- @nealsid how is this PR related to #147 ?

@nealsid
Copy link
Author

nealsid commented Feb 27, 2014

I created this branch off of the branch for #147, which is why it shares commits. But once PR #147 is merged, this PR will only contain 363c25a

@fnothaft
Copy link
Member

#147 is only waiting on @tdanford's suggestions before merging, correct? Just want to make sure it isn't sitting out ready to merge with nothing else pending.

@fnothaft
Copy link
Member

Looks good here, I commented on 363c25a. One general overall comment is that I'd like to see more scaladoc, but that's just a nit.

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/179/

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/180/

fnothaft added a commit that referenced this pull request Feb 28, 2014
@fnothaft fnothaft merged commit dfa9aea into bigdatagenomics:vcf-work Feb 28, 2014
@fnothaft
Copy link
Member

Thanks @nealsid! Merged.

@nealsid nealsid deleted the vcf-work-concordance-and-genotype branch February 28, 2014 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants