Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining variant changes for adam2vcf, unit tests, and CLI modifications #150

Merged
merged 2 commits into from
Feb 28, 2014
Merged

Remaining variant changes for adam2vcf, unit tests, and CLI modifications #150

merged 2 commits into from
Feb 28, 2014

Conversation

nealsid
Copy link

@nealsid nealsid commented Feb 26, 2014

FYI, this PR is against vcf-work, but includes vcf-work-vcf-conversion. The most recent commit is the only commit necessary to review in this PR.
Thanks,
Neal

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/172/

@tdanford
Copy link
Contributor

As with #151, I'm still unclear as to how the commits in this PR relate to #147 ?

@fnothaft
Copy link
Member

Looks good here! Excited to see #150 and #151, can't wait to get them and the topic branch merged in.

@nealsid
Copy link
Author

nealsid commented Feb 28, 2014

Great. 150 & 151 are ready to go unless you have more comments.
Thanks, Frank.

On Thu, Feb 27, 2014 at 12:25 PM, Frank Austin Nothaft <
notifications@github.com> wrote:

Looks good here! Excited to see #150https://github.com/bigdatagenomics/adam/pull/150and
#151 #151, can't wait to
get them and the topic branch merged in.


Reply to this email directly or view it on GitHubhttps://github.com//pull/150#issuecomment-36267195
.

fnothaft added a commit that referenced this pull request Feb 28, 2014
Remaining variant changes for adam2vcf, unit tests, and CLI modifications
@fnothaft fnothaft merged commit 96409a6 into bigdatagenomics:vcf-work Feb 28, 2014
@fnothaft
Copy link
Member

Thanks @nealsid! Merged.

@nealsid nealsid deleted the vcf-work-adam2vcf-and-cli branch February 28, 2014 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants