[PM-8372] Generate higher minimum number/special character values #3260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update CODEOWNERS * Update CODEOWNERS
* [PM-3513] Show API error when SSO policy is enforced.
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
* [PM-3545] Fix biometric unlock for autofill * [PM-3545] Reuse existing method
* fix for TDE pref naming collision * fix case
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
…ll. (bitwarden#2713) * [PM-3543] [PM-3507] Fix password re-prompt when editing and on autofill.
…rden#2724) * Migration of data from LiteDB to shared pref storage * tweaks
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
…g SSO (bitwarden#2719) * [PM-3382] Update mobile client to receive and use SsoEmail2faSessionToken * [PM-3382] Fix null 2fa email with local email on MP login.
* Adding build steps for .app * Uploading .app artifact * Fixing ARCHIVE_PATH variable * Fixing missing OutputPath * Fixing Bitwarden .app file name * Fixing wrong .app location * Adding Fede's suggestion * Update .github/workflows/build.yml Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com> --------- Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
* Update AppResources.af.resx * Update AnonAddy references * Reverted AnonAddy to AddyIo refactor, keeping text and url changes --------- Co-authored-by: Andre Rosado <arosado@bitwarden.com>
…2723) * [PM-3606] Fix 2FA for autofill * [PM-3606] Fix autofill when user doesn't have a login method available. * [PM-3606] PR fixes * [PM-3606] Add logout logic to other extension projects * [PM-3606] Move code to base class. * Transform into property instead of field Co-authored-by: Federico Maccaroni <fedemkr@gmail.com> * Remove double ";" Co-authored-by: Federico Maccaroni <fedemkr@gmail.com> * [PM-3606] Fix iOS extension by changing base class of LockPasswordViewController --------- Co-authored-by: Federico Maccaroni <fedemkr@gmail.com>
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
…cally log out TDE users (bitwarden#2747) * [PM-3393] Log user out on biometric exceed attempts * [PM-3393] Move duplicated code to AppHelpers * [PM-3393] Update copy on new pop up * [PM-3393] Moved VaultTimeoutService to LazyResolve. * [PM-3382] Change IVaultTimeoutService for messaging * [PM-3393] Use default values.
…roduction environments (bitwarden#2773)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
* [PM-3726] prevent legacy user login * [PM-3726] prevent unlock or auto key migration if legacy user * [PM-3726] add legacy checks to lock page and refactor * [PM-3726] rethrow exception from pin * formatting * [PM-3726] add changes to LockViewController, consolidate logout calls * formatting * [PM-3726] pr feedback * generate resx * formatting
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
* PM-7877 Added loading dialog when unlocking with PIN * PM-7877 Added exception logging on unlock with PIN
This reverts commit 1f966e6.
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…behavior (bitwarden#3230) * PM-7255 Fix autofill cancelling the request on password autofill because of wrong safeguard * PM-7255 Clear code no longer used
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…the workaround to use Share app window when coming from iOS extension (bitwarden#3239)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…cial character values
|
Thank you for your contribution! We've added this to our internal Community PR board for review. |
bitwarden-bot
changed the title
b02860de585071a2
changed the title
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Fixes bitwarden/mobile#3259
Code changes
Context: see desktop blob and mobile blob for comparison.
src/Core/Pages/Generator/GeneratorPage.xaml: Change max value ofMinNumberandMinSpecial(5 -> 9)I have built and tested this on Android 13 and 14, armeabi-v7a and arm64-v8a. I do not have the ability to test an iOS build, but it should be an equally easy fix.