merge of dev changes to InflowWind #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added omega to UA driver time-series file - added UAMod=4 (HGM model); linearization is incomplete - added DBMET_Mod=3 (continuous form of constant tau); linearization is incomplete - reorganized loops in BEM CalcOutput and UpdateStates for ease of reading/calculations - NEED TO CHECK the Cp/Cavit stuff!!! - added C_lalpha parameter to airfoil input file - NWTC Library: fix fatal issue if ever calling WrOver with more than ConRecL-1 characters - Allow AeroDyn driver to read time-history file as input - Many AeroDyn driver (all output is in one file)
added option to blend BEM/non-BEM solution when the TSR is lower than 2. BEM is totally off when TSR is <= 1
Default has changed from 20 Hz to 0.5 NEED TO DOCUMENT THIS!!!!!
- also a couple of additional robustness checks on DBEMT CCSD (alphaE and Tu)
These get inherited from FASTlib, and it seems to be bothering newer version of Visual Studio (trying to link the FAST executable with the Registry executable)
- Add continuous state for UA in FVW
- change not-Fortran2003 `norm2()` to `TwoNorm()`
- change precision in {x|y|z}_hat_disk to 8-byte
- remove iBladeNode and iBlade from FVW%m_UA
- update `UA_UpdateState_Wrapper` to call UA routines with appropriate arguments
- attempt to call UA_UpdateStates and UA_CalcOutput with correct inputs (NEEDS A REVIEW!!!)
- CHANGED dynamic cl, cd, cm when UA is called
- fixed some error handling in `SetOutputsFromFVW`
- removed extra solution files - modified existing ones with Registry not using Release|Win32 configurations
will need to be updated again soon
The GemoPhi output will be a number between 0 (BEM only) and 1 (no BEM) that indicates if BEM has been turned off due to either no valid value of phi error from the BEM solution or a gradual turning off because TSR is less than 2.
- lists the case number after the time column - removes the ".1" from the file name because all cases are in the same output file now.
- added example UA driver input files (this now has an additional input column), though it doesn't appear to be documented anywhere. - updated AD driver text and fixed a comment that was wrong elsewhere - added example AD driver time-history input file
* Improve Dockerfiles - smaller space and better performance * Add a catch-all unit tests make target * Add a custom regression test CMake target This avoids requiring to compile the OpenFAST Library when running the regression tests since that library takes forever to compile. * Disable existing action * Add workflow for push and pull requests events
The "$" prefix selects the value based on the cursor position, but "@" selects the value based on the data. Docs for reference: https://docs.bokeh.org/en/latest/docs/user_guide/tools.html#hovertool
Updates to AeroDyn
updated baselines for macos-gnu
HD driver: add Morrison mesh and standalone driver cases
* Add NWTC Library infrastructure for parsing string inputs This is useful when parsing mixed-type arrays. Parse them into string elements and then cast the elements into the appropriate type. * Add safety checks and error handling * Correct the allocated size for file list * Return a defered size string array * Improve error handling Co-authored-by: andrew-platt <andy.platt@nrel.gov>
VTK folder and Vx sign for OLAF
Co-authored-by: Jake Nunemaker <jake.d.nunemaker@gmail.com>
* Disable stack-reuse in gfortran Ran into an issue with gfortran 9.1.0 on mac where a function within a subroutine used the same stack location for an integer as a variable of a different name in the subroutine. See commit c35dc09 of the structural control revision for problematic code. The basic issue was that the ErrStat value of subroutine ParseInputFileInfo was sharing stack space with the CurLine variable. The function 'Failed' would check the ErrStat2 value and set the ErrStat accordingly, but in optimization -O2 or -O3, the CurLine variable and ErrStat variable were the same stack location, resulting in very strange behaviour. In this particular case, it caused OpenFAST to abort. Gfortran 7.x and debug compiles do not show this issue. Based on the documentation in section 3.16 from https://gcc.gnu.org/onlinedocs/gcc-9.2.0/gcc.pdf, this may sometimes occur with legacy code and it is possible we've had this happen in the past and never known about it. Impact on memory usage is unknown at this time. * Add link to bug description in PR Co-authored-by: Rafael M Mudafort <rafmudaf@gmail.com>
Incorrect sizing of the FileIndx array
|
One line is missing in UniformWind.f90. Will fix this after the merge. |
bjonkman
pushed a commit
that referenced
this pull request
Apr 14, 2022
seastate: change WtrDpth to ReKi so double precision will compile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
Since a bunch of changes to InflowWind were merged into dev last week, it was conflicting with your branch. Since I was involved in that, I merged dev into your InflowWind updates.
There were conflicts in the UniformWind, and in the main InflowWind file parsing (we had updated both in dev). I think I have now merged all of the changes in your branch and dev together without losing any features of either.
Test results, if applicable
It took a few iterations to sort out, but now all the test cases appear to be passing on macos-gnu. Haven't checked with intel yet, but will do so.
One thing to note: the main IfW input file and the UniformWind input file is now parsed using Marshall's FileInfo parsing method. This requires the keyword to match, so all IfW input files in the linked r-test repo branch (combination of your edits and ours).
NOTE: I did make an update to the
5MW_TLP_DLL_WTurb_WavesIrr_WavesMulticase for macos-gnu. The difference appeared to be just normal noise -- no idea why that changed on me.