Skip to content

fix: support Gemini 3's thought signatures#5806

Merged
michaelneale merged 1 commit intoblock:mainfrom
SalvatoreT:salvatoret/5792/gemini-thought_signature
Nov 20, 2025
Merged

fix: support Gemini 3's thought signatures#5806
michaelneale merged 1 commit intoblock:mainfrom
SalvatoreT:salvatoret/5792/gemini-thought_signature

Conversation

@SalvatoreT
Copy link
Contributor

@SalvatoreT SalvatoreT commented Nov 18, 2025 •
edited by michaelneale
Loading

Summary

Gemini 3 requires Thought Signatures to use it. This PR implements it.

Type of Change

  • Feature
  • Bug fix

AI Assistance

  • This PR was created or reviewed with AI assistance

Testing

Unit tests + using the command line with gemini-3-pro-preview

Related Issues

fixes #5792

@SalvatoreT SalvatoreT force-pushed the salvatoret/5792/gemini-thought_signature branch from 8edbc5d to 741f446 Compare November 18, 2025 23:08
@chatgpt-codex-connector
Copy link

chatgpt-codex-connector bot commented Nov 18, 2025

💡 Codex Review

goose/crates/goose/src/conversation/message.rs

Lines 51 to 57 in 8edbc5d

pub struct ToolRequest {
pub id: String,
#[serde(with = "tool_result_serde")]
#[schema(value_type = Object)]
pub tool_call: ToolResult<CallToolRequestParam>,
#[serde(skip_serializing_if = "Option::is_none")]
pub thought_signature: Option<String>,

P1 Badge Update ToolRequest literals for new thought_signature field

Adding thought_signature: Option<String> to ToolRequest makes every struct literal in the workspace (for example the many test helpers in crates/goose-cli/src/session/export.rs) fail to compile with “missing field thought_signature”. Because the new field has no default and the existing call sites were not updated in this change, running cargo test for crates that construct ToolRequest now fails at compile time. Either supply thought_signature: None at each instantiation or provide a defaulted constructor so downstream code continues to compile.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SalvatoreT SalvatoreT force-pushed the salvatoret/5792/gemini-thought_signature branch 2 times, most recently from 55fc844 to 68550e2 Compare November 18, 2025 23:44
The-Best-Codes
The-Best-Codes reviewed Nov 19, 2025
View reviewed changes
Copy link
Collaborator

@The-Best-Codes The-Best-Codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I didn't test it locally but will soon

@arthurdstark arthurdstark mentioned this pull request Nov 19, 2025
Closed
DOsinga
DOsinga approved these changes Nov 19, 2025
View reviewed changes
Copy link
Collaborator

@DOsinga DOsinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for jumping on this - a friend of mine at google asked me how I was celebrating gemini 3 and I replied by waiting how it will break goose. well, there

if you can remove some of the LLM things, let's get this in

@SalvatoreT SalvatoreT force-pushed the salvatoret/5792/gemini-thought_signature branch from 68550e2 to 20c1512 Compare November 19, 2025 22:58
SalvatoreT
SalvatoreT commented Nov 19, 2025
View reviewed changes
Copy link
Contributor Author

@SalvatoreT SalvatoreT left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated based on feedback

@SalvatoreT
fix: support Gemini 3's thought signatures
512b649 
Gemini 3 requires Thought Signatures to use it. https://ai.google.dev/gemini-api/docs/thought-signatures

Signed-off-by: Salvatore Testa <sal@withpersona.com>
@SalvatoreT SalvatoreT force-pushed the salvatoret/5792/gemini-thought_signature branch from 20c1512 to 512b649 Compare November 19, 2025 22:59
@michaelneale
Copy link
Collaborator

michaelneale commented Nov 20, 2025

just running a live test now (as can't from forks)...

@michaelneale michaelneale merged commit cfdf015 into block:main Nov 20, 2025
16 checks passed
@SalvatoreT SalvatoreT deleted the salvatoret/5792/gemini-thought_signature branch November 20, 2025 07:04
wpfleger96 added a commit that referenced this pull request Nov 20, 2025
@wpfleger96
Merge branch 'main' into wpfleger/persist-provider-config
df0d1bc 
* main: (33 commits)
  fix: support Gemini 3's thought signatures (#5806)
  chore: Add Adrian Cole to Maintainers (#5815)
  [MCP-UI] Proxy and Better Message Handling (#5487)
  Release 1.15.0
  Document New Window menu in macOS dock (#5811)
  Catch cron errors (#5707)
  feat/fix Re-enabled WAL with commit transaction management (Linux Verification Requested) (#5793)
  chore: remove autopilot experimental feature (#5781)
  Read paths from an interactive & login shell (#5774)
  docs: acp clients (#5800)
  Provider error proxy for simulating various types of errors (#5091)
  chore: Add links to maintainer profiles (#5788)
  Quick fix for community all stars script (#5798)
  Document Mistral AI provider (#5799)
  docs: Add Community Stars recipe script and txt file (#5776)
  chore: incorporate LF feedback (#5787)
  docs: quick launcher (#5779)
  Bump auto scroll threshold (#5738)
  fix: add one-time cleanup for linux hermit locking issues (#5742)
  Don't show update tray icon if GOOSE_VERSION is set (#5750)
  ...
@DOsinga DOsinga mentioned this pull request Nov 20, 2025
Closed
michaelneale added a commit that referenced this pull request Nov 24, 2025
@michaelneale
Merge branch 'main' into skillz
89403b7 
* main: (48 commits)
  [fix] generic check for gemini compat (#5842)
  Add scheduler to diagnostics (#5849)
  Cors and token (#5850)
  fix sessions coming back with empty messages (#5841)
  markdown export from URL (#5830)
  Next camp refactor live (#5706)
  Add out of context compaction test via error proxy (#5805)
  fix: Add backward compatibility for conversationCompacted message type (#5819)
  Add /agent/stop endpoint, make max active agents configurable (#5826)
  Handle 404s (#5791)
  Persist provider name and model config in the session (#5419)
  Comment out the flaky mcp callers (#5827)
  Slash commands (#5718)
  fix: remove setx calls to not permanently edit the windows shell PATH (#5821)
  fix: Parse maas models for gcp vertex provider (#5816)
  fix: support Gemini 3's thought signatures (#5806)
  chore: Add Adrian Cole to Maintainers (#5815)
  [MCP-UI] Proxy and Better Message Handling (#5487)
  Release 1.15.0
  Document New Window menu in macOS dock (#5811)
  ...
@github-actions github-actions bot mentioned this pull request Nov 25, 2025
Closed
BlairAllan pushed a commit to BlairAllan/goose that referenced this pull request Nov 29, 2025
@SalvatoreT @BlairAllan
fix: support Gemini 3's thought signatures (block#5806)
25ca0b4 
Signed-off-by: Salvatore Testa <sal@withpersona.com>
Signed-off-by: Blair Allan <Blairallan@icloud.com>
@github-actions github-actions bot mentioned this pull request Dec 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@The-Best-Codes The-Best-Codes Awaiting requested review from The-Best-Codes

@DOsinga DOsinga Awaiting requested review from DOsinga

Assignees

@michaelneale michaelneale

@SalvatoreT SalvatoreT

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Gemini] Function Calls fail with 400 Error: "missing thought_signature in functionCall parts"

4 participants

@SalvatoreT @michaelneale @DOsinga @The-Best-Codes