[fix] generic check for gemini compat#5842
Merged
michaelneale merged 1 commit intomainfrom Nov 24, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in Gemini model detection for the Databricks provider by changing from a prefix check to a substring check, allowing proper detection of both direct Gemini models (e.g., "gemini-2-5-flash") and Databricks-prefixed Gemini models (e.g., "databricks-gemini-3-pro"). This follows the existing pattern used for Claude model detection in the same file.
- Changes model detection from
starts_with("gemini")tocontains("gemini")to handle optional prefixes - Adds test coverage for both naming patterns (direct and prefixed Gemini models)
michaelneale
approved these changes
Nov 24, 2025
michaelneale
added a commit
that referenced
this pull request
Nov 24, 2025
* main: (48 commits) [fix] generic check for gemini compat (#5842) Add scheduler to diagnostics (#5849) Cors and token (#5850) fix sessions coming back with empty messages (#5841) markdown export from URL (#5830) Next camp refactor live (#5706) Add out of context compaction test via error proxy (#5805) fix: Add backward compatibility for conversationCompacted message type (#5819) Add /agent/stop endpoint, make max active agents configurable (#5826) Handle 404s (#5791) Persist provider name and model config in the session (#5419) Comment out the flaky mcp callers (#5827) Slash commands (#5718) fix: remove setx calls to not permanently edit the windows shell PATH (#5821) fix: Parse maas models for gcp vertex provider (#5816) fix: support Gemini 3's thought signatures (#5806) chore: Add Adrian Cole to Maintainers (#5815) [MCP-UI] Proxy and Better Message Handling (#5487) Release 1.15.0 Document New Window menu in macOS dock (#5811) ...
kskarthik
pushed a commit
to kskarthik/goose
that referenced
this pull request
Nov 25, 2025
kskarthik
pushed a commit
to kskarthik/goose
that referenced
this pull request
Nov 26, 2025
Signed-off-by: Sai Karthik <kskarthik@disroot.org>
BlairAllan
pushed a commit
to BlairAllan/goose
that referenced
this pull request
Nov 29, 2025
Signed-off-by: Blair Allan <Blairallan@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Check for gemini models on databricks provider using contains instead of startswith
Type of Change