Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 78.0.3904.108 to Chromium 79.0.3945.56 #7140

Merged
merged 3 commits into from
Dec 2, 2019

Conversation

mkarolin
Copy link
Contributor

@mkarolin mkarolin commented Nov 27, 2019

Fixes #6588
Related PR brave/brave-core#4091

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@mkarolin mkarolin added this to the 1.3.x - Nightly milestone Nov 27, 2019
@mkarolin mkarolin self-assigned this Nov 27, 2019
@mkarolin mkarolin marked this pull request as ready for review November 27, 2019 19:13
yrliou
yrliou previously approved these changes Nov 27, 2019
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

simonhong
simonhong previously approved these changes Nov 27, 2019
bsclifton
bsclifton previously approved these changes Nov 27, 2019
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of my favorite PRs of all time! 😄👍

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit bb3fcd7 into master Dec 2, 2019
@bsclifton bsclifton deleted the 79.0.3945.56 branch December 2, 2019 23:22
mkarolin pushed a commit that referenced this pull request Dec 3, 2019
Upgrade from Chromium 78.0.3904.108 to Chromium 79.0.3945.56
mkarolin pushed a commit that referenced this pull request Dec 3, 2019
Upgrade from Chromium 78.0.3904.108 to Chromium 79.0.3945.56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade from Chromium 78.0.3904.108 to Chromium 79.0.3945.56
4 participants