Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Hide lower button hides all entries in ledger table #11246

Closed
srirambv opened this issue Oct 3, 2017 · 1 comment
Closed

Hide lower button hides all entries in ledger table #11246

srirambv opened this issue Oct 3, 2017 · 1 comment

Comments

@srirambv
Copy link
Collaborator

srirambv commented Oct 3, 2017

Description

Show lower hides all entries in ledger table

Steps to Reproduce

  1. Enable payments on 0.19.25
  2. Visit sites to get entries in ledger table and show the hide lower button
  3. Click hide lower hides all entries
  4. Include/exclude some entries, click hide lower, all entries are hidden
  5. Repeat step 5 for other entries some may show up when you click hide lower

Actual result:

showlower

Expected result:
Should always show enabled entries irrespective of hide/show button toggle

Reproduces how often: [What percentage of the time does it reproduce?]

Brave Version

about:brave info:

Brave 0.19.25
rev d4fd17a
Muon 4.4.25

Reproducible on current live release:

Not checked

Additional Information

cc: @NejcZdovc @cezaraugusto

@NejcZdovc NejcZdovc added this to the 0.19.x (Beta Channel) milestone Oct 4, 2017
@bsclifton bsclifton self-assigned this Oct 4, 2017
bsclifton pushed a commit that referenced this issue Oct 4, 2017
…BAT Mercury.

Details:
Because the settings were renamed, git didn't properly handle changes when cherry-picking backwards.
This caused the code in 0.19.x and 0.20.x to use the naming from 0.21.x

Merge pull request #10164 from luixxiul/polish-hideLower
Replace hideLower with showLess
f0d9c3d

Merge pull request #10441 from brave/10322
add support for legacy ledger settings
052277d

Also includes fixes from 9ad7b4f (most of this commit was already backported, just grabbed the settings migration fixes)

Auditors: @NejcZdovc, @luixxiul, @cezaraugusto

Fixes #11261
Fixes #11260
Fixes #11250
Fixes #11246
Fixes #11263
bsclifton pushed a commit that referenced this issue Oct 4, 2017
…BAT Mercury.

Details:
Because the settings were renamed, git didn't properly handle changes when cherry-picking backwards.
This caused the code in 0.19.x and 0.20.x to use the naming from 0.21.x

Merge pull request #10164 from luixxiul/polish-hideLower
Replace hideLower with showLess
f0d9c3d

Merge pull request #10441 from brave/10322
add support for legacy ledger settings
052277d

Also includes fixes from 9ad7b4f (most of this commit was already backported, just grabbed the settings migration fixes)

Auditors: @NejcZdovc, @luixxiul, @cezaraugusto

Fixes #11261
Fixes #11260
Fixes #11250
Fixes #11246
Fixes #11263
@bsclifton
Copy link
Member

Fixed with be048b8

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.