Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

URL Icon doesn't toggle include/exclude for non-verified publishers #11263

Closed
LaurenWags opened this issue Oct 3, 2017 · 2 comments
Closed

URL Icon doesn't toggle include/exclude for non-verified publishers #11263

LaurenWags opened this issue Oct 3, 2017 · 2 comments
Assignees
@bsclifton
Labels
bug feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Milestone
0.19.x (Beta Chan...

Comments

@LaurenWags
Copy link
Member

Description

When payments are enabled, the URL heart icon doesn't work to toggle include/exclude if the publisher isn't Verified.

Steps to Reproduce

  1. Have a mix of verified/not verified publishers in your ledger list.
  2. Navigate to a verified publisher site.
  3. Click on the heart icon.
  4. Verify that the verified publisher is marked as include/exclude as appropriate.
  5. Navigate to another site where the publisher is not verified but the site is marked as include in the table.
  6. The heart icon is not yellow. Click on the heart icon, no change. (you can still toggle include/exclude from the ledger table).

Actual result:
urliconnotworking01927

Expected result:
Clicking on the icon in the URL bar should work if the publisher is not verified as well as if the publisher is verified.

Reproduces how often: [What percentage of the time does it reproduce?] 100%

Brave Version

about:brave info:
Brave | 0.19.27
rev | e7f3a69
Muon | 4.4.25

Reproducible on current live release:
no

Additional Information

cc @kjozwiak
@LaurenWags LaurenWags added this to the 0.19.x (Beta Channel) milestone Oct 3, 2017
@LaurenWags LaurenWags changed the title URL Icon doesn't work for non-verified publishers URL Icon doesn't toggle include/exclude for non-verified publishers Oct 3, 2017
@LaurenWags
Copy link
Member Author

cc @NejcZdovc

@bsclifton bsclifton self-assigned this Oct 4, 2017
bsclifton pushed a commit that referenced this issue Oct 4, 2017
@cezaraugusto @bsclifton
Manual backport of code changed in 0.21.x which caused conflict with …
3bc7c1f 
…BAT Mercury.

Details:
Because the settings were renamed, git didn't properly handle changes when cherry-picking backwards.
This caused the code in 0.19.x and 0.20.x to use the naming from 0.21.x

Merge pull request #10164 from luixxiul/polish-hideLower
Replace hideLower with showLess
f0d9c3d

Merge pull request #10441 from brave/10322
add support for legacy ledger settings
052277d

Also includes fixes from 9ad7b4f (most of this commit was already backported, just grabbed the settings migration fixes)

Auditors: @NejcZdovc, @luixxiul, @cezaraugusto

Fixes #11261
Fixes #11260
Fixes #11250
Fixes #11246
Fixes #11263
bsclifton pushed a commit that referenced this issue Oct 4, 2017
@cezaraugusto @bsclifton
Manual backport of code changed in 0.21.x which caused conflict with …
be048b8 
…BAT Mercury.

Details:
Because the settings were renamed, git didn't properly handle changes when cherry-picking backwards.
This caused the code in 0.19.x and 0.20.x to use the naming from 0.21.x

Merge pull request #10164 from luixxiul/polish-hideLower
Replace hideLower with showLess
f0d9c3d

Merge pull request #10441 from brave/10322
add support for legacy ledger settings
052277d

Also includes fixes from 9ad7b4f (most of this commit was already backported, just grabbed the settings migration fixes)

Auditors: @NejcZdovc, @luixxiul, @cezaraugusto

Fixes #11261
Fixes #11260
Fixes #11250
Fixes #11246
Fixes #11263
@bsclifton
Copy link
Member

Fixed with be048b8

@srirambv srirambv mentioned this issue Oct 9, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
bug feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

No branches or pull requests
5 participants
@kjozwiak @luixxiul @bsclifton @srirambv @LaurenWags