Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Contribution notification shown on upgrade to 0.19.27 #11250

Closed
bsclifton opened this issue Oct 3, 2017 · 2 comments
Closed

Contribution notification shown on upgrade to 0.19.27 #11250

bsclifton opened this issue Oct 3, 2017 · 2 comments
Assignees
@bsclifton
Labels
feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.19.x (Beta Chan...

Comments

@bsclifton
Copy link
Member

bsclifton commented Oct 3, 2017 •
edited
Loading

Test plan

  1. Install Brave 0.18.x
  2. Have a wallet created. Shouldn't matter if wallet has funds or not (but might be good to try both cases)
  3. Install Brave 0.19.x
  4. Notification should show after launching (when the transition process starts).

Description

Steps to Reproduce

  1. have a profile which has made brave payments before and has a dollar amount not $5 (mine is $10)
  2. install Brave 0.19.27

Actual result:

I immediately got a message about my contribution for $5 was processed. It seems this data being shown is dummy data? When I go to payment history, it only shows the reports for what I expect (ex: no action seems to have been taken)

Expected result:
My contribution amount is $10 and it was last processed on 9/26 (today is 10/3).

Reproduces how often:
I can't reproduce by re-opening. Would have to look deeper

Brave Version

about:brave info:

Brave: 0.19.27
rev: e7f3a69
Muon: 4.4.25
libchromiumcontent: 61.0.3163.100
V8: 6.1.534.41
Node.js: 7.9.0
Update Channel: Beta
OS Platform: macOS
OS Release: 16.7.0
OS Architecture: x64

Reproducible on current live release:
no

Additional Information
@bsclifton bsclifton added this to the 0.19.x (Beta Channel) milestone Oct 3, 2017
@bsclifton bsclifton self-assigned this Oct 3, 2017
bsclifton pushed a commit that referenced this issue Oct 4, 2017
@cezaraugusto @bsclifton
Manual backport of code changed in 0.21.x which caused conflict with …
3bc7c1f 
…BAT Mercury.

Details:
Because the settings were renamed, git didn't properly handle changes when cherry-picking backwards.
This caused the code in 0.19.x and 0.20.x to use the naming from 0.21.x

Merge pull request #10164 from luixxiul/polish-hideLower
Replace hideLower with showLess
f0d9c3d

Merge pull request #10441 from brave/10322
add support for legacy ledger settings
052277d

Also includes fixes from 9ad7b4f (most of this commit was already backported, just grabbed the settings migration fixes)

Auditors: @NejcZdovc, @luixxiul, @cezaraugusto

Fixes #11261
Fixes #11260
Fixes #11250
Fixes #11246
Fixes #11263
bsclifton pushed a commit that referenced this issue Oct 4, 2017
@cezaraugusto @bsclifton
Manual backport of code changed in 0.21.x which caused conflict with …
be048b8 
…BAT Mercury.

Details:
Because the settings were renamed, git didn't properly handle changes when cherry-picking backwards.
This caused the code in 0.19.x and 0.20.x to use the naming from 0.21.x

Merge pull request #10164 from luixxiul/polish-hideLower
Replace hideLower with showLess
f0d9c3d

Merge pull request #10441 from brave/10322
add support for legacy ledger settings
052277d

Also includes fixes from 9ad7b4f (most of this commit was already backported, just grabbed the settings migration fixes)

Auditors: @NejcZdovc, @luixxiul, @cezaraugusto

Fixes #11261
Fixes #11260
Fixes #11250
Fixes #11246
Fixes #11263
@bsclifton
Copy link
Member Author

Fixed with be048b8

@bsclifton
Copy link
Member Author

I was able to repro this by toggling payments on and off

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

No branches or pull requests
5 participants
@kjozwiak @luixxiul @bsclifton @srirambv @LaurenWags