This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
'Allow contributions to non-verified sites' toggle doesn't do anything #11261
Assignees
Labels
Milestone
Comments
bsclifton
pushed a commit
that referenced
this issue
Oct 4, 2017
…BAT Mercury. Details: Because the settings were renamed, git didn't properly handle changes when cherry-picking backwards. This caused the code in 0.19.x and 0.20.x to use the naming from 0.21.x Merge pull request #10164 from luixxiul/polish-hideLower Replace hideLower with showLess f0d9c3d Merge pull request #10441 from brave/10322 add support for legacy ledger settings 052277d Also includes fixes from 9ad7b4f (most of this commit was already backported, just grabbed the settings migration fixes) Auditors: @NejcZdovc, @luixxiul, @cezaraugusto Fixes #11261 Fixes #11260 Fixes #11250 Fixes #11246 Fixes #11263
bsclifton
pushed a commit
that referenced
this issue
Oct 4, 2017
…BAT Mercury. Details: Because the settings were renamed, git didn't properly handle changes when cherry-picking backwards. This caused the code in 0.19.x and 0.20.x to use the naming from 0.21.x Merge pull request #10164 from luixxiul/polish-hideLower Replace hideLower with showLess f0d9c3d Merge pull request #10441 from brave/10322 add support for legacy ledger settings 052277d Also includes fixes from 9ad7b4f (most of this commit was already backported, just grabbed the settings migration fixes) Auditors: @NejcZdovc, @luixxiul, @cezaraugusto Fixes #11261 Fixes #11260 Fixes #11250 Fixes #11246 Fixes #11263
|
Fixed with be048b8 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
In 0.19.27 if you modify the 'Allow contributions to non-verified sites' toggle, nothing happens. You can save this change and it will be retained, but it doesn't seem to do anything.
Steps to Reproduce
Actual result:
Changing the toggle doesn't appear to make any updates:
Expected result:
Was expecting the toggle to work as it did in 0.18.36:
Reproduces how often: [What percentage of the time does it reproduce?] 100%
Brave Version
about:brave info:
Brave | 0.19.27
rev | e7f3a69
Muon | 4.4.25
Reproducible on current live release:
no
Additional Information
Reproduced by @srirambv although I believe he saw slightly different results.
cc @kjozwiak
The text was updated successfully, but these errors were encountered: