Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Wrong favicon is shown for bookmark #1646

Closed
chitza opened this issue May 9, 2016 · 17 comments
Closed

Wrong favicon is shown for bookmark #1646

chitza opened this issue May 9, 2016 · 17 comments
Assignees
@NejcZdovc
Labels
bug misc/favicon QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.20.x (Release C...

Comments

@chitza
Copy link

chitza commented May 9, 2016 •
edited by luixxiul
Loading

Test plan

#10136 (comment)

captura de ecran din 2016 05 09 la 18 13 07

Sometimes favicons get mixed up. In the above screenshot, the favicon for feedly was green while I was reading the RSS feeds. Then I clicked the twitter link and the feedly favicon changed to that of twitter.
@luixxiul luixxiul added the design A design change, especially one which needs input from the design team. label May 26, 2016
@luixxiul
Copy link
Contributor

luixxiul commented Jun 5, 2016

I notice sometimes this too

@johnmarzan
Copy link

happens sometimes in mine

@bbondy bbondy added needs-info Another team member needs information from the PR/issue opener. and removed design A design change, especially one which needs input from the design team. labels Jun 5, 2016
@bbondy
Copy link
Member

bbondy commented Jun 5, 2016

steps to reproduce wanted if anyone can find them.

@dogancelik
Copy link

I can confirm, only step for me is clicking "Show favicon for items in Bookmarks Toolbar"

icons

@ElenaZhuk ElenaZhuk mentioned this issue Jun 18, 2016
Closed
@gravitycrusher7 gravitycrusher7 mentioned this issue Jun 19, 2016
Closed
@garvankeeley
Copy link
Contributor

Is happening for me if you want me to help
screenshot 2016-06-21 17 42 11

@bbondy
Copy link
Member

bbondy commented Jun 23, 2016

I think I found out how to reproduce, you need to click a bookmark item and before it is done loading click another one.

@bbondy bbondy added this to the 0.10.4dev milestone Jun 23, 2016
@bbondy bbondy closed this as completed in e44d45e Jun 23, 2016
@garvankeeley
Copy link
Contributor

garvankeeley commented Jun 23, 2016 •
edited
Loading

Still on 0.10.4
screenshot 2016-06-23 10 19 05

Maybe I have to delete and re-add them?

@garvankeeley garvankeeley reopened this Jun 23, 2016
@bbondy
Copy link
Member

bbondy commented Jun 23, 2016

there's no way to fix your previous entries.

@bbondy
Copy link
Member

bbondy commented Jun 23, 2016

it just won't happen anymore.

@garvankeeley
Copy link
Contributor

Ok, confirmed fixed

@luixxiul luixxiul removed the needs-info Another team member needs information from the PR/issue opener. label Jun 23, 2016
@robfla
Copy link

robfla commented Nov 13, 2016 •
edited
Loading

Still an issue, version 0.12.8.

reddd

@bsclifton bsclifton mentioned this issue Nov 22, 2016
Closed
@bsclifton
Copy link
Member

Re-opening as this is still happening

@bsclifton bsclifton reopened this Nov 22, 2016
@bsclifton bsclifton removed this from the 0.10.4dev milestone Nov 22, 2016
@bsclifton
Copy link
Member

Looked into this briefly; I know the favicons are now updated properly after page visit. My best guess is that the favicon for site A is being updated (an event which fires after page load and sets after looking up site using index) while a site B is being added (and added to the sites array)

@srirambv
Copy link
Collaborator

srirambv commented Dec 6, 2016

+1 from support

@srirambv
Copy link
Collaborator

+1 from support

@eljuno eljuno mentioned this issue Apr 4, 2017
Closed
@luixxiul luixxiul added the bug label May 30, 2017
@bsclifton bsclifton mentioned this issue Jul 28, 2017
Closed
@bsclifton bsclifton marked this as a duplicate of #10176 Jul 28, 2017
@bsclifton bsclifton changed the title Wrong favicon Wrong favicon is shown for bookmark Jul 28, 2017
@bsclifton
Copy link
Member

Possibly related to #10176

@NejcZdovc I believe this will be fixed with your PR (#10136). What do you think?

@NejcZdovc
Copy link
Contributor

Yes this should be fixed with #10136

@NejcZdovc NejcZdovc self-assigned this Jul 28, 2017
@NejcZdovc NejcZdovc added this to the 0.20.x (Nightly Channel) milestone Jul 28, 2017
@NejcZdovc NejcZdovc mentioned this issue Jul 28, 2017
Merged
8 tasks
@NejcZdovc NejcZdovc modified the milestones: 0.21.x (Nightly Channel), 0.20.x (Developer Channel) Aug 4, 2017
NejcZdovc added a commit that referenced this issue Aug 4, 2017
@NejcZdovc
Splits sites object in the app state
c2fd650 
Resolves #1646
Resolves #1856
Resolves #2655
Resolves #2771
Resolves #3646
Resolves #3694
Resolves #4224
Resolves #4260
Resolves #4833
Resolves #4868
Resolves #4929
Resolves #5072
Resolves #5699
Resolves #5382
Resolves #6104
Resolves #6108
Resolves #6585
Resolves #8022
Resolves #9301
Resolves #9326
Resolves #9978
Resolves #10026

Auditors:

Test Plan:
dfperry5 pushed a commit to dfperry5/browser-laptop that referenced this issue Aug 18, 2017
@NejcZdovc @dfperry5
Splits sites object in the app state
33861b7 
Resolves brave#1646
Resolves brave#1856
Resolves brave#2655
Resolves brave#2771
Resolves brave#3646
Resolves brave#3694
Resolves brave#4224
Resolves brave#4260
Resolves brave#4833
Resolves brave#4868
Resolves brave#4929
Resolves brave#5072
Resolves brave#5699
Resolves brave#5382
Resolves brave#6104
Resolves brave#6108
Resolves brave#6585
Resolves brave#8022
Resolves brave#9301
Resolves brave#9326
Resolves brave#9978
Resolves brave#10026

Auditors:

Test Plan:
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
This was referenced Dec 20, 2017
Closed
Closed
This was referenced Dec 27, 2017
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
bug misc/favicon QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests