This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 974
Add automated test for making sure bookmark custom title appears on bookmark toolbar #3694
Milestone
Comments
Can this be closed with bdb5f6a? |
I did the first half and left the second half to @srirambv to wrap up as we were remote pair programming. He'll be afk until 17/10/2016 so I will check with him then. |
This one would be easy to add a test for now; I created a bookmarksToolbar test here: It actually already uses selectors testing against the customTitle... but it would be good to put an explicit test in place 😄 cc: @srirambv @alexwykoff |
8 tasks
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Jul 18, 2017
Resovles brave#9978 Resolves brave#6108 Resovles brave#6585 Resolves brave#6104 Resolves brave#3694 Auditors: @bbondy @ayumi @diracdeltas @bsclifton @darkdh Test Plan:
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Jul 18, 2017
Resovles brave#9978 Resolves brave#6108 Resovles brave#6585 Resolves brave#6104 Resolves brave#3694 Auditors: Test Plan:
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Jul 20, 2017
Resovles brave#9978 Resolves brave#6108 Resovles brave#6585 Resolves brave#6104 Resolves brave#3694 Auditors: Test Plan:
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Jul 20, 2017
Resovles brave#9978 Resolves brave#6108 Resovles brave#6585 Resolves brave#6104 Resolves brave#3694 Auditors: Test Plan:
Custom title will be removed in #9978, so this issue is not relevant anymore |
Will set PR to close it with #10136 😃 |
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Jul 21, 2017
Resovles brave#9978 Resolves brave#6108 Resovles brave#6585 Resolves brave#6104 Resolves brave#3694 Auditors: Test Plan:
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Jul 22, 2017
Resolves brave#1856 Resolves brave#2771 Resolves brave#3646 Resolves brave#3694 Resolves brave#4224 Resolves brave#4260 Resolves brave#4833 Resolves brave#4868 Resolves brave#4929 Resolves brave#5699 Resolves brave#6104 Resolves brave#6108 Resolves brave#6585 Resolves brave#8022 Resolves brave#9301 Resolves brave#9326 Resolves brave#9978 Resolves brave#10026 Auditors: Test Plan:
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Jul 22, 2017
Resolves brave#1856 Resolves brave#2771 Resolves brave#3646 Resolves brave#3694 Resolves brave#4224 Resolves brave#4260 Resolves brave#4833 Resolves brave#4868 Resolves brave#4929 Resolves brave#5699 Resolves brave#6104 Resolves brave#6108 Resolves brave#6585 Resolves brave#8022 Resolves brave#9301 Resolves brave#9326 Resolves brave#9978 Resolves brave#10026 Auditors: Test Plan:
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Jul 25, 2017
Resolves brave#1856 Resolves brave#2771 Resolves brave#3646 Resolves brave#3694 Resolves brave#4224 Resolves brave#4260 Resolves brave#4833 Resolves brave#4868 Resolves brave#4929 Resolves brave#5699 Resolves brave#6104 Resolves brave#6108 Resolves brave#6585 Resolves brave#8022 Resolves brave#9301 Resolves brave#9326 Resolves brave#9978 Resolves brave#10026 Auditors: Test Plan:
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Jul 25, 2017
Resolves brave#1856 Resolves brave#2771 Resolves brave#3646 Resolves brave#3694 Resolves brave#4224 Resolves brave#4260 Resolves brave#4833 Resolves brave#4868 Resolves brave#4929 Resolves brave#5699 Resolves brave#6104 Resolves brave#6108 Resolves brave#6585 Resolves brave#8022 Resolves brave#9301 Resolves brave#9326 Resolves brave#9978 Resolves brave#10026 Auditors: Test Plan:
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Jul 25, 2017
Resolves brave#1856 Resolves brave#2771 Resolves brave#3646 Resolves brave#3694 Resolves brave#4224 Resolves brave#4260 Resolves brave#4833 Resolves brave#4868 Resolves brave#4929 Resolves brave#5699 Resolves brave#6104 Resolves brave#6108 Resolves brave#6585 Resolves brave#8022 Resolves brave#9301 Resolves brave#9326 Resolves brave#9978 Resolves brave#10026 Auditors: Test Plan:
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Jul 26, 2017
Resolves brave#1856 Resolves brave#2771 Resolves brave#3646 Resolves brave#3694 Resolves brave#4224 Resolves brave#4260 Resolves brave#4833 Resolves brave#4868 Resolves brave#4929 Resolves brave#5699 Resolves brave#6104 Resolves brave#6108 Resolves brave#6585 Resolves brave#8022 Resolves brave#9301 Resolves brave#9326 Resolves brave#9978 Resolves brave#10026 Auditors: Test Plan:
8 tasks
NejcZdovc
added a commit
that referenced
this issue
Aug 4, 2017
Resolves #1646 Resolves #1856 Resolves #2655 Resolves #2771 Resolves #3646 Resolves #3694 Resolves #4224 Resolves #4260 Resolves #4833 Resolves #4868 Resolves #4929 Resolves #5072 Resolves #5699 Resolves #5382 Resolves #6104 Resolves #6108 Resolves #6585 Resolves #8022 Resolves #9301 Resolves #9326 Resolves #9978 Resolves #10026 Auditors: Test Plan:
dfperry5
pushed a commit
to dfperry5/browser-laptop
that referenced
this issue
Aug 18, 2017
Resolves brave#1646 Resolves brave#1856 Resolves brave#2655 Resolves brave#2771 Resolves brave#3646 Resolves brave#3694 Resolves brave#4224 Resolves brave#4260 Resolves brave#4833 Resolves brave#4868 Resolves brave#4929 Resolves brave#5072 Resolves brave#5699 Resolves brave#5382 Resolves brave#6104 Resolves brave#6108 Resolves brave#6585 Resolves brave#8022 Resolves brave#9301 Resolves brave#9326 Resolves brave#9978 Resolves brave#10026 Auditors: Test Plan:
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Test plan
Make sure the automated test was added
This test should add a bookmark with a custom title and make sure it shows that custom title.
Code to modify for the test is here:
test/components/bookmarksTest.js
Tests for each React component (UI element) is in
test/components
and it maps tojs/components
code.You'll notice this test is currently split into 2 parts, bookmarking titles of pages with titles, and sites without titles. So you'll add 2 new tests in this issue, one for each.
Most of how tests work is using the DOM inspector with Shift+F8 dev tools to find what the css selector is for a certain DOM element. You can test your CSS selector to make sure it selects the correct element just by opening the browser manually, opening browser dev tools and in the console typing document.querySelector('your-selector-here').
Always try to make sure individual
it
blocks in the test do not depend on each other. Thedescribe
's before block usually sets up the test, and then eachit
tests something about it.The best way to figure out details of the test is just to read other tests but we have some good documentation including debugging information here: https://github.com/brave/browser-laptop/blob/master/docs/tests.md
The text was updated successfully, but these errors were encountered: