Splits sites object in the app state

[NejcZdovc]

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.

Resolves #1646 (Wrong favicon is shown for bookmark)
Resolves #1856 (Removing sites from history - siteUtil functionality)
Resolves #2655 (Bookmark name of a file does not appear in the autocomplete list)
Resolves #2771 (Bookmark folder is created left of bookmark item, not right)
Resolves #3646 (Bookmarks title changes when navigating around the page)
Resolves #3694 (Add automated test for making sure bookmark custom title appears on bookmark toolbar)
Resolves #4224 (Hidden history entries appear by deleting the latest entry)
Resolves #4260 (Edited information of bookmark does not appear on bookmark dialog via star icon)
Resolves #4833 (Bookmark title dynamically changed)
Resolves #4868 (Rebookmarking from context menu does not reset bookmark title)
Resolves #4929 (Bookmark title automatically changes on the bookmark form)
Resolves #5072 (about:history omits recent history)
Resolves #5382 (clicking entries on about:history is laggy)
Resolves #5699 (Last Visited on Bookmark Manager is not recorded for newly created bookmarks)
Resolves #6104 (Address bar should autocomplete from custom bookmark titles)
Resolves #6108 (Bookmark title on bookmark toolbar is renamed)
Resolves #6585 (Remove customTitle from siteDetail object)
Resolves #8022 (Bookmark moved to a folder on the toolbar cannot be removed via the star button)
Resolves #9301 (Changing bookmark location causes duplicate bookmarks)
Resolves #9326 (Custom bookmark title is not being displayed in suggestions)
Resolves #9978 (Split sites into separate entities)
Resolves #10026 (Bookmarks toolbar : imported sorted bookmarks are represented in wacky order)

Auditors: @bbondy @ayumi @diracdeltas @bsclifton @darkdh

Test Plan:
Run general regression tests first: https://github.com/brave/browser-laptop/wiki/Manual-Tests

1. Bookmark

• try to add a bookmark

2. Bookmark

• try to add a bookmark, but into the second level folder

3. Bookmark folder

• try to add a bookmark folder

4. Bookmark

• try to edit a bookmark

5. Bookmark folder

• try to add a bookmark folder

6. Bookmark

• try to remove a bookmark

7. Bookmark folder

• try to remove a bookmark folder

8. Bookmark

• try to add a bookmark into a folder (with a right click on a folder)
• folder should be preselected

9. Bookmark folder

• try to add a bookmark folder into a folder (with a right click on a folder)
• folder should be preselected

10. Navigation bar

• try to bookmark a page via navigation bar star

11. Navigation bar

• try to edit a bookmark via navigation bar star

12. Bookmark manager

• try to add a bookmark folder from a bookmark manager (list, folder tree and button)

13. Bookmark manager

• try to add a bookmark from a bookmark manager (list, folder tree and button)

14. Bookmark manager

• try to edit a bookmark from a bookmark manager (list and folder tree)

15. Bookmark manager

• try to edit a bookmark folder from a bookmark manager (list and folder tree)

16. Bookmark link

• try to bookmark a link (right click on a link in the page)

17. Bookmark manager

• try to dnd bookmark into another folder

18. Bookmark manager

• try to dnd multiple bookmarks into another folder

19. Bookmark manager

• try to dnd folder into another folder

20. Bookmark manager

• try to reorder bookmarks in bookmark manager

21. Bookmark toolbar

• try to dnd bookmark into the folder

22. Bookmark toolbar

• try to dnd folder into another folder

23. Bookmark toolbar

• try to to reorder bookmarks with dnd (try it with folders as well)

24. History manager

• check if history is successfully added

25. History manager

• right click on a history item
• try to delete it

26. Pinned tabs

• try to pin a site
• restart the browser
• check if pinned tab is still there

27. Importer

• try to import HTML file

27. Importer

• try to import from chrome

27. Importer

• try to import from FF

28. Exporter

• check if export is working

29. Url bar suggestions

• check if bookmark is shown in suggestion list

30. Url bar suggestions

• check if history site is shown in suggestion list

31. Ledger

• enabled ledger
• visit some site
• check if site is added to the ledger

32. New tab

• check if top sites are displayed correctly

33. New tab

• check if you can remove top site

34. New tab

• check if you can pin top site

35. New tab

• check if you can bookmark and edit bookmark already bookmarked top site

36. New tab

• check if you can reorder top sites

Reviewer Checklist:

Tests

• Adequate test coverage exists to prevent regressions
• Tests should be independent and work correctly when run individually or as a suite ref
• New files have MPL2 license header

[NejcZdovc]

Pinned sites

• create utils
• create upgrade script

Default sites

• remove from state
• refactor newTab to use topSites directly

History sites (current sites object)

• create utils
• create upgrade script
• fix about:history

Bookmarks sites

• create utils
• remove customTitle
• create index-order table
• create upgrade script
• fix about:bookmarks
• try to add a bookmark (star icon) while page is still loading
• new tab bookmark is not working
• changing bookmark folder location is not working for already bookmarked item
• right click on a bookmark and clicking add site deletes all bookmarks

Bookmark folder sites

• create utils
• remove customTitle
• create index-order table
• create upgrade script

General

• check how sites (no tags) array is working in other places
• update sync related code, ask for help from @ayumi @diracdeltas
• update import related code, ask for help from @darkdh
• update suggestions related code, ask for help from @bbondy
• alphabetize state docs
• keep only general functions in js/state/siteUtil.js
• remove app/common/state/siteState.js
• remove app/browser/reducers/sitesReducer.js
• make sure that import order is preserved
• go through all getSiteKey calls and see where we can remove them, because key is now inside bookmarks object

Questions

• can we remove site from sites when we pin it?
• should we be saving keys in string format? Otherwise every time you want to use key in .get(), you need to add toString()
• we have last visited time in about:bookmarks. Is this needed? @bradleyrichter if so we need to to update bookmark entry when we add history entry.

Known issues

• improve import, because now it's taking too long to finish (maybe the problem is that we are calling action inside action)
• if you add a site via dialog, we need to add favicon somehow if it's not in the history
• import from chrome is not working
• sync is not working
• site cache is broken
• if you delete a history item and then bookmark active frame you will lose favicon and theme color
• when importing from chrome last accessed time is not imported correctly
• add sort values for upgrade process
• bookmarks don't get favicon if you bookmark top sites on a fresh profile
• bookmark star status is not displayed correctly on a new tab
• fix dnd for top sites in new tab
• more bookmarks doesn't work on bookmark toolbar

Tests 10/20

• app/browser/reducers/bookmarkFoldersReducer.js
• app/browser/reducers/bookmarksReducer.js
• app/browser/reducers/historyReducer.js
• app/browser/reducers/pinnedSitesReducer.js
• app/browser/reducers/sitesReducer.js (this file was removed, move things around)
• app/common/cache/bookmarkLocationCache.js (before it was siteCache.js)
• app/common/cache/bookmarkOrderCache.js
• app/common/lib/bookmarkFoldersUtil.js
• app/common/lib/bookmarkUtil.js
• js/state/siteUtil.js (test file needs to be updated)
• app/common/lib/historyUtil.js
• app/common/lib/pinnedSitesUtil.js
• app/common/state/aboutHistoryState.js
• app/common/state/aboutNewTabState.js
• app/common/state/bookmarkFoldersState.js
• app/common/state/bookmarksState.js
• app/common/state/historyState.js
• app/common/state/pinnedSitesState.js
• app/common/state/tabState.js
• js/stores/windowStore.js

[ayumi]

👍

[bsclifton]

++++! ❤️