Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Edited information of bookmark does not appear on bookmark dialog via star icon #4260

Closed
luixxiul opened this issue Sep 24, 2016 · 4 comments
Closed

Edited information of bookmark does not appear on bookmark dialog via star icon #4260

luixxiul opened this issue Sep 24, 2016 · 4 comments
Assignees
@NejcZdovc
Labels
bug feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.20.x (Release C...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Sep 24, 2016 •
edited
Loading

Test plan

#10136 (comment)

Describe the issue you encountered: The edited information (title and URL) of bookmark does not appear on bookmark dialog opened via star icon. This issue does not happen if you click the icon on the toolbar to select Edit Bookmark.

Expected behavior: The edited information (title and url) of bookmark should be filled in these input fields.

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10
  • Brave Version: 0.12.2 RC3
  • Steps to reproduce:
    1. Open Manual tests for Windows ia-32 0.12.2 RC4 #4255
    2. Click the star icon next to the url bar
    3. Edit Title and click Save
    4. Click the star icon again
    5. The initial title appears instead of the edited one
  • Any related issues:

Please set a milestone if necessary.
@jonepatr
Copy link

I can confirm that it does the same thing on macOS. It's not only the title, but the whole add/edit bookmarks window doesn't update when opened a second time.

@luixxiul luixxiul changed the title Edited title of bookmark does not appear on bookmark dialog Edited information of bookmark does not appear on bookmark dialog via star icon Sep 24, 2016
@alexwykoff alexwykoff added this to the 0.12.3dev milestone Sep 25, 2016
@alexwykoff alexwykoff mentioned this issue Sep 25, 2016
Closed
@bbondy bbondy removed this from the 0.12.3dev milestone Sep 26, 2016
@bbondy
Copy link
Member

bbondy commented Sep 26, 2016

To fix this we need to first try to find the information in appState sites, and if it is not found then use the current frame.
https://github.com/brave/browser-laptop/blob/master/js/components/navigationBar.js#L42

@jonepatr
Copy link

jonepatr commented Oct 3, 2016

I'll give it a go, to try to fix this!

@luixxiul luixxiul mentioned this issue May 29, 2017
Closed
7 tasks
@NejcZdovc NejcZdovc self-assigned this Jul 20, 2017
@NejcZdovc NejcZdovc added this to the 0.20.x (Developer Channel) milestone Jul 20, 2017
@NejcZdovc
Copy link
Contributor

NejcZdovc commented Jul 20, 2017 •
edited
Loading

Should be fixed with #10136

@NejcZdovc NejcZdovc mentioned this issue Jul 20, 2017
Closed
8 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jul 22, 2017
@NejcZdovc
Splits sites object in the app state
1678bf9 
Resolves brave#1856
Resolves brave#2771
Resolves brave#3646
Resolves brave#3694
Resolves brave#4224
Resolves brave#4260
Resolves brave#4833
Resolves brave#4868
Resolves brave#4929
Resolves brave#5699
Resolves brave#6104
Resolves brave#6108
Resolves brave#6585
Resolves brave#8022
Resolves brave#9301
Resolves brave#9326
Resolves brave#9978
Resolves brave#10026

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jul 22, 2017
@NejcZdovc
Splits sites object in the app state
0802623 
Resolves brave#1856
Resolves brave#2771
Resolves brave#3646
Resolves brave#3694
Resolves brave#4224
Resolves brave#4260
Resolves brave#4833
Resolves brave#4868
Resolves brave#4929
Resolves brave#5699
Resolves brave#6104
Resolves brave#6108
Resolves brave#6585
Resolves brave#8022
Resolves brave#9301
Resolves brave#9326
Resolves brave#9978
Resolves brave#10026

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jul 25, 2017
@NejcZdovc
Splits sites object in the app state
6696e4b 
Resolves brave#1856
Resolves brave#2771
Resolves brave#3646
Resolves brave#3694
Resolves brave#4224
Resolves brave#4260
Resolves brave#4833
Resolves brave#4868
Resolves brave#4929
Resolves brave#5699
Resolves brave#6104
Resolves brave#6108
Resolves brave#6585
Resolves brave#8022
Resolves brave#9301
Resolves brave#9326
Resolves brave#9978
Resolves brave#10026

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jul 25, 2017
@NejcZdovc
Splits sites object in the app state
bda4f31 
Resolves brave#1856
Resolves brave#2771
Resolves brave#3646
Resolves brave#3694
Resolves brave#4224
Resolves brave#4260
Resolves brave#4833
Resolves brave#4868
Resolves brave#4929
Resolves brave#5699
Resolves brave#6104
Resolves brave#6108
Resolves brave#6585
Resolves brave#8022
Resolves brave#9301
Resolves brave#9326
Resolves brave#9978
Resolves brave#10026

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jul 25, 2017
@NejcZdovc
Splits sites object in the app state
94a95b0 
Resolves brave#1856
Resolves brave#2771
Resolves brave#3646
Resolves brave#3694
Resolves brave#4224
Resolves brave#4260
Resolves brave#4833
Resolves brave#4868
Resolves brave#4929
Resolves brave#5699
Resolves brave#6104
Resolves brave#6108
Resolves brave#6585
Resolves brave#8022
Resolves brave#9301
Resolves brave#9326
Resolves brave#9978
Resolves brave#10026

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jul 26, 2017
@NejcZdovc
Splits sites object in the app state
da5b46b 
Resolves brave#1856
Resolves brave#2771
Resolves brave#3646
Resolves brave#3694
Resolves brave#4224
Resolves brave#4260
Resolves brave#4833
Resolves brave#4868
Resolves brave#4929
Resolves brave#5699
Resolves brave#6104
Resolves brave#6108
Resolves brave#6585
Resolves brave#8022
Resolves brave#9301
Resolves brave#9326
Resolves brave#9978
Resolves brave#10026

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Jul 26, 2017
Merged
8 tasks
NejcZdovc added a commit that referenced this issue Jul 27, 2017
@NejcZdovc
Splits sites object in the app state
ed72c5d 
Resolves #1856
Resolves #2771
Resolves #3646
Resolves #3694
Resolves #4224
Resolves #4260
Resolves #4833
Resolves #4868
Resolves #4929
Resolves #5699
Resolves #6104
Resolves #6108
Resolves #6585
Resolves #8022
Resolves #9301
Resolves #9326
Resolves #9978
Resolves #10026

Auditors:

Test Plan:
NejcZdovc added a commit that referenced this issue Jul 27, 2017
@NejcZdovc
Splits sites object in the app state
ea28b4d 
Resolves #1856
Resolves #2771
Resolves #3646
Resolves #3694
Resolves #4224
Resolves #4260
Resolves #4833
Resolves #4868
Resolves #4929
Resolves #5699
Resolves #6104
Resolves #6108
Resolves #6585
Resolves #8022
Resolves #9301
Resolves #9326
Resolves #9978
Resolves #10026

Auditors:

Test Plan:
NejcZdovc added a commit that referenced this issue Jul 27, 2017
@NejcZdovc
Splits sites object in the app state
d808cb9 
Resolves #1856
Resolves #2771
Resolves #3646
Resolves #3694
Resolves #4224
Resolves #4260
Resolves #4833
Resolves #4868
Resolves #4929
Resolves #5699
Resolves #6104
Resolves #6108
Resolves #6585
Resolves #8022
Resolves #9301
Resolves #9326
Resolves #9978
Resolves #10026

Auditors:

Test Plan:
NejcZdovc added a commit that referenced this issue Jul 28, 2017
@NejcZdovc
Splits sites object in the app state
c754a56 
Resolves #1856
Resolves #2771
Resolves #3646
Resolves #3694
Resolves #4224
Resolves #4260
Resolves #4833
Resolves #4868
Resolves #4929
Resolves #5699
Resolves #6104
Resolves #6108
Resolves #6585
Resolves #8022
Resolves #9301
Resolves #9326
Resolves #9978
Resolves #10026

Auditors:

Test Plan:
NejcZdovc added a commit that referenced this issue Jul 28, 2017
@NejcZdovc
Splits sites object in the app state
23ee608 
Resolves #1856
Resolves #2771
Resolves #3646
Resolves #3694
Resolves #4224
Resolves #4260
Resolves #4833
Resolves #4868
Resolves #4929
Resolves #5699
Resolves #6104
Resolves #6108
Resolves #6585
Resolves #8022
Resolves #9301
Resolves #9326
Resolves #9978
Resolves #10026

Auditors:

Test Plan:
NejcZdovc added a commit that referenced this issue Jul 28, 2017
@NejcZdovc
Splits sites object in the app state
5efcb2c 
Resolves #1856
Resolves #2771
Resolves #3646
Resolves #3694
Resolves #4224
Resolves #4260
Resolves #4833
Resolves #4868
Resolves #4929
Resolves #5699
Resolves #6104
Resolves #6108
Resolves #6585
Resolves #8022
Resolves #9301
Resolves #9326
Resolves #9978
Resolves #10026

Auditors:

Test Plan:
NejcZdovc added a commit that referenced this issue Jul 31, 2017
@NejcZdovc
Splits sites object in the app state
744a3ad 
Resolves #1856
Resolves #2771
Resolves #3646
Resolves #3694
Resolves #4224
Resolves #4260
Resolves #4833
Resolves #4868
Resolves #4929
Resolves #5699
Resolves #6104
Resolves #6108
Resolves #6585
Resolves #8022
Resolves #9301
Resolves #9326
Resolves #9978
Resolves #10026

Auditors:

Test Plan:
NejcZdovc added a commit that referenced this issue Jul 31, 2017
@NejcZdovc
Splits sites object in the app state
daa7474 
Resolves #1856
Resolves #2771
Resolves #3646
Resolves #3694
Resolves #4224
Resolves #4260
Resolves #4833
Resolves #4868
Resolves #4929
Resolves #5699
Resolves #6104
Resolves #6108
Resolves #6585
Resolves #8022
Resolves #9301
Resolves #9326
Resolves #9978
Resolves #10026

Auditors:

Test Plan:
NejcZdovc added a commit that referenced this issue Aug 1, 2017
@NejcZdovc
Splits sites object in the app state
9d83149 
Resolves #1856
Resolves #2771
Resolves #3646
Resolves #3694
Resolves #4224
Resolves #4260
Resolves #4833
Resolves #4868
Resolves #4929
Resolves #5699
Resolves #6104
Resolves #6108
Resolves #6585
Resolves #8022
Resolves #9301
Resolves #9326
Resolves #9978
Resolves #10026

Auditors:

Test Plan:
NejcZdovc added a commit that referenced this issue Aug 3, 2017
@NejcZdovc
Splits sites object in the app state
f618f0e 
Resolves #1856
Resolves #2771
Resolves #3646
Resolves #3694
Resolves #4224
Resolves #4260
Resolves #4833
Resolves #4868
Resolves #4929
Resolves #5699
Resolves #6104
Resolves #6108
Resolves #6585
Resolves #8022
Resolves #9301
Resolves #9326
Resolves #9978
Resolves #10026

Auditors:

Test Plan:
@NejcZdovc NejcZdovc modified the milestones: 0.21.x (Nightly Channel), 0.20.x (Developer Channel) Aug 4, 2017
NejcZdovc added a commit that referenced this issue Aug 4, 2017
@NejcZdovc
Splits sites object in the app state
c2fd650 
Resolves #1646
Resolves #1856
Resolves #2655
Resolves #2771
Resolves #3646
Resolves #3694
Resolves #4224
Resolves #4260
Resolves #4833
Resolves #4868
Resolves #4929
Resolves #5072
Resolves #5699
Resolves #5382
Resolves #6104
Resolves #6108
Resolves #6585
Resolves #8022
Resolves #9301
Resolves #9326
Resolves #9978
Resolves #10026

Auditors:

Test Plan:
dfperry5 pushed a commit to dfperry5/browser-laptop that referenced this issue Aug 18, 2017
@NejcZdovc @dfperry5
Splits sites object in the app state
33861b7 
Resolves brave#1646
Resolves brave#1856
Resolves brave#2655
Resolves brave#2771
Resolves brave#3646
Resolves brave#3694
Resolves brave#4224
Resolves brave#4260
Resolves brave#4833
Resolves brave#4868
Resolves brave#4929
Resolves brave#5072
Resolves brave#5699
Resolves brave#5382
Resolves brave#6104
Resolves brave#6108
Resolves brave#6585
Resolves brave#8022
Resolves brave#9301
Resolves brave#9326
Resolves brave#9978
Resolves brave#10026

Auditors:

Test Plan:
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
This was referenced Dec 20, 2017
Closed
Closed
This was referenced Dec 27, 2017
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
bug feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
7 participants
@bbondy @jonepatr @alexwykoff @luixxiul @NejcZdovc @srirambv @LaurenWags