Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging from main #1

Merged
merged 17 commits into from
Nov 4, 2022
Merged

Merging from main #1

merged 17 commits into from
Nov 4, 2022

Conversation

olemartinorg
Copy link

Make sure not to squash this while merging (I suspect that will interfere with how github detects how far ahead/behind you are). You seem to have two remaining typescript errors after this:

src/components/base/ListComponent.tsx:4:3 - error TS2459: Module '"@altinn/altinn-design-system"' declares 'SortDirection' locally, but it is not exported.

4   SortDirection,
    ~~~~~~~~~~~~~

  ../node_modules/@altinn/altinn-design-system/dist/index.d.ts:217:14
    217 declare enum SortDirection {
                     ~~~~~~~~~~~~~
    'SortDirection' is declared here.

src/components/base/ListComponent.tsx:12:28 - error TS2459: Module '"@altinn/altinn-design-system"' declares 'SortProps' locally, but it is not exported.

12 import type { ChangeProps, SortProps } from '@altinn/altinn-design-system';
                              ~~~~~~~~~

  ../node_modules/@altinn/altinn-design-system/dist/index.d.ts:228:11
    228 interface SortProps {
                  ~~~~~~~~~
    'SortProps' is declared here.

This should probably be fixed in the design system..? 🤔

olemartinorg and others added 17 commits November 2, 2022 10:33
Co-authored-by: Ole Martin Handeland <git@olemartin.org>
Co-authored-by: Ole Martin Handeland <git@olemartin.org>
* at least it works 😅

* updated tests

* cleanup

* update jsDoc comments

* Added unit tests

* added cypress test

* Fixing nullable values

* fix

Co-authored-by: Ole Martin Handeland <git@olemartin.org>
Co-authored-by: Ivar <ivar.nesje@finanstilsynet.no>
Co-authored-by: Ole Martin Handeland <git@olemartin.org>
Co-authored-by: Kylstad <acn-nkyls@ai-dev.no>
Co-authored-by: EKEBERG Steffen <steffen.ekeberg@soprasteria.com>
Co-authored-by: Steffen Lorang Ekeberg <steffen.ekeberg@gmail.com>
Co-authored-by: Terje Holene <terje.holene@gmail.com>
Co-authored-by: Ole Martin Handeland <git@olemartin.org>
Co-authored-by: Martin Joakim Ulstein <mjulstein@users.noreply.github.com>
Co-authored-by: tba76 <70642698+tba76@users.noreply.github.com>
Co-authored-by: Nina Kylstad <nkylstad@gmail.com>
Co-authored-by: Ivar Nesje <ivarne@users.noreply.github.com>
Co-authored-by: FTLems <90687291+FTLems@users.noreply.github.com>
Co-authored-by: DanRJ <daniel.rustadj@gmail.com>
Co-authored-by: Håkon <2082481+haakemon@users.noreply.github.com>
Co-authored-by: Truls Gunnerød <Truls.Gunnerod@no.experis.com>
Co-authored-by: Martin Joakim Ulstein <6736558+mjulstein@users.noreply.github.com>
Co-authored-by: Magnus Revheim Martinsen <mrmartinsen.96@gmail.com>
Co-authored-by: Rune Tømmerås Larsen <rune@hjemmekino.no>
Co-authored-by: = <bjosttveit@gmail.com>
* Added missing schema-definitions

* fix default value for maxDate
Co-authored-by: Ole Martin Handeland <git@olemartin.org>
Co-authored-by: Ole Martin Handeland <git@olemartin.org>
Co-authored-by: Prettier <prettier-commits@example.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
# Conflicts:
#	src/altinn-app-frontend/src/features/form/containers/Form.tsx
#	src/altinn-app-frontend/src/features/form/layout/formLayoutSlice.ts
#	src/altinn-app-frontend/src/features/form/layout/index.ts
#	src/altinn-app-frontend/src/shared/resources/options/fetch/fetchOptionsSagas.ts
#	src/altinn-app-frontend/src/utils/options.ts
@caroliss caroliss merged commit 933cf94 into caroliss:listComponent Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants