Fix Isolation Test Failure in isolation_multiuser_locking in PG17 #7714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-13.0 #7714 +/- ##
===============================================
Coverage ? 89.60%
===============================================
Files ? 274
Lines ? 59730
Branches ? 7451
===============================================
Hits ? 53520
Misses ? 4076
Partials ? 2134 |
onurctirtir
reviewed
Nov 8, 2024
|
|
||
| step s1-insert: | ||
| UPDATE test_table SET column2 = 1; | ||
| <waiting ...> |
There was a problem hiding this comment.
this seems a bit suspicious as we were throwing a permission-check error in the older test output
There was a problem hiding this comment.
I suppose that because of this commit:
git.postgresql.org Git - postgresql.git/commitdiff
If you think that it is unrelated, ı Will looked into that more.
naisila
force-pushed
the
naisila/pg17_support
branch
from
70cf729 to
e4040dd
Compare
naisila
force-pushed
the
naisila/pg17_support
branch
from
04a8f6a to
b29c332
Compare
m3hm3t
force-pushed
the
m3hm3t/pg17_isolation_multiuser_lock
branch
from
1fbdd9f to
94bbb2e
Compare
naisila
force-pushed
the
naisila/pg17_support
branch
3 times, most recently
from
e12686a to
46dc966
Compare
naisila
force-pushed
the
naisila/pg17_support
branch
7 times, most recently
from
e108bb8 to
c396ce6
Compare
naisila
force-pushed
the
naisila/pg17_support
branch
from
c396ce6 to
a12026b
Compare
naisila
force-pushed
the
naisila/pg17_support
branch
6 times, most recently
from
1e55f40 to
1c39f95
Compare
naisila
force-pushed
the
naisila/pg17_support
branch
2 times, most recently
from
e8352a8 to
5ce353b
Compare
45 tasks
naisila
force-pushed
the
naisila/pg17_support
branch
2 times, most recently
from
7cee81c to
ab8221a
Compare
m3hm3t
changed the base branch from
naisila/pg17_support
to
m3hm3t/pg17_support
naisila
reviewed
Dec 20, 2024
naisila
approved these changes
Dec 23, 2024
naisila
force-pushed
the
m3hm3t/pg17_isolation_multiuser_lock
branch
from
ee04da6 to
332828e
Compare
naisila
added a commit
that referenced
this pull request
Dec 24, 2024
This is the final commit that adds PG17 compatibility with Citus's current capabilities. You can use Citus community, release-13.0 branch, with PG17.1. --------- Specifically, this commit: - Enables PG17 in the configure script. - Adds PG17 tests to CI using test images that have 17.1 - Fixes an upgrade test: see below for details In `citus_prepare_upgrade()`, don't drop any_value when upgrading from PG16+, because PG16+ has its own any_value function. Attempting to do so results in the error seen in [pg16-pg17 upgrade](https://github.com/citusdata/citus/actions/runs/11768444117/job/32778340003?pr=7661): ``` ERROR: cannot drop function any_value(anyelement) because it is required by the database system CONTEXT: SQL statement "DROP AGGREGATE IF EXISTS pg_catalog.any_value(anyelement)" ``` When 16 becomes the minimum supported Postgres version, the drop statements can be removed. --------- Several PG17 Compatibility commits have been merged before this final one. All these subtasks are done #7653 See the list below: Compilation PR: #7699 Ruleutils PR: #7725 Sister PR for tests: citusdata/the-process#159 Helpful smaller PRs: - #7714 - #7726 - #7731 - #7732 - #7733 - #7738 - #7745 - #7747 - #7748 - #7749 - #7752 - #7755 - #7757 - #7759 - #7760 - #7761 - #7762 - #7765 - #7766 - #7768 - #7769 - #7771 - #7774 - #7776 - #7780 - #7781 - #7785 - #7788 - #7793 - #7796 --------- Co-authored-by: Colm <colmmchugh@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances
isolation_multiuser_locking.spectest compatibility across multiple PostgreSQL versions by handling differences in error messages and behavior. Key updates include:Error Message Handling: Adjustments to manage version-specific error messages, ensuring consistent test results.
Modified to address variations in locking behavior across PostgreSQL versions, ensuring test stability in multiuser scenarios.
REINDEX Behavior Adjustment: This PR accounts for a behavioral change introduced in PostgreSQL by commit ecb0fd337, which alters how REINDEX interacts with system catalogs.
https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=ecb0fd337