PG17 compatibility: fix diffs in create_index, privileges vanilla tests

[colm-mchugh]

PG17 regress sanity (#7653) fix; address diffs in vanilla tests create_index and privileges. Fix change from permission denied to must be owner of, seen in create_index:

@@ -2970,21 +2970,21 @@
 REINDEX TABLE pg_toast.pg_toast_1260;
 ERROR:  permission denied for table pg_toast_1260
 REINDEX INDEX pg_toast.pg_toast_1260_index;
-ERROR:  permission denied for index pg_toast_1260_index
+ERROR:  must be owner of index pg_toast_1260_index

and privileges:

@@ -2945,41 +2945,43 @@
ERROR:  permission denied for table maintain_test
 REINDEX INDEX maintain_test_a_idx;
-ERROR:  permission denied for index maintain_test_a_idx
+ERROR:  must be owner of index maintain_test_a_idx
 REINDEX SCHEMA reindex_test;

 REINDEX INDEX maintain_test_a_idx;
+ERROR:  must be owner of index maintain_test_a_idx
 REINDEX SCHEMA reindex_test;

The diff in behavior appears related to how Citus handles propagation of ROLE commands. Disabling enable_ddl_propagation for vanilla enables the tests to produce the expected messages.

The relevant Postgres commits are this commit for privileges, which added MAINTAIN privileges, and this commit for create_index which modified the test.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.54%. Comparing base (c396ce6) to head (bcc1b97).

Additional details and impacted files

@@                   Coverage Diff                    @@
##           naisila/pg17_support    #7766      +/-   ##
========================================================
- Coverage                 89.62%   89.54%   -0.09%     
========================================================
  Files                       274      274              
  Lines                     59689    59691       +2     
  Branches                   7446     7446              
========================================================
- Hits                      53495    53448      -47     
- Misses                     4065     4094      +29     
- Partials                   2129     2149      +20     

---- 🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests