PG17 compatibility: fix some tests outputs #7765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-13.0 #7765 +/- ##
===============================================
Coverage ? 89.59%
===============================================
Files ? 274
Lines ? 59584
Branches ? 7436
===============================================
Hits ? 53382
Misses ? 4057
Partials ? 2145 |
hanefi
reviewed
Dec 2, 2024
Comment on lines
95
to
96
| 16: "12.1devel", | ||
| 17: "12.1devel", |
There was a problem hiding this comment.
The current version on main branch as well as this feature branch is 12.2devel. We no longer care about 12.1devel at all.
Suggested change
| 16: "12.1devel", | |
| 17: "12.1devel", | |
| 16: "12.1.0", | |
| 17: "12.2devel", |
There was a problem hiding this comment.
Makes sense. I will fix that, but not in this PR, because the first commit of this PR is not to be merged.
onurctirtir
approved these changes
Dec 2, 2024
Relevant PG commit: postgres/postgres@78806a9 78806a95095c4fb9230a441925244690d9c07d23
Relevant PG commits: fix idea from postgres/postgres@6ab1dbd 6ab1dbd26bbf307055d805feaaca16dc3e750d36
naisila
force-pushed
the
naisila/pg17_tests
branch
from
d3bb1e1 to
303bc6c
Compare
naisila
added a commit
that referenced
this pull request
Dec 24, 2024
This is the final commit that adds PG17 compatibility with Citus's current capabilities. You can use Citus community, release-13.0 branch, with PG17.1. --------- Specifically, this commit: - Enables PG17 in the configure script. - Adds PG17 tests to CI using test images that have 17.1 - Fixes an upgrade test: see below for details In `citus_prepare_upgrade()`, don't drop any_value when upgrading from PG16+, because PG16+ has its own any_value function. Attempting to do so results in the error seen in [pg16-pg17 upgrade](https://github.com/citusdata/citus/actions/runs/11768444117/job/32778340003?pr=7661): ``` ERROR: cannot drop function any_value(anyelement) because it is required by the database system CONTEXT: SQL statement "DROP AGGREGATE IF EXISTS pg_catalog.any_value(anyelement)" ``` When 16 becomes the minimum supported Postgres version, the drop statements can be removed. --------- Several PG17 Compatibility commits have been merged before this final one. All these subtasks are done #7653 See the list below: Compilation PR: #7699 Ruleutils PR: #7725 Sister PR for tests: citusdata/the-process#159 Helpful smaller PRs: - #7714 - #7726 - #7731 - #7732 - #7733 - #7738 - #7745 - #7747 - #7748 - #7749 - #7752 - #7755 - #7757 - #7759 - #7760 - #7761 - #7762 - #7765 - #7766 - #7768 - #7769 - #7771 - #7774 - #7776 - #7780 - #7781 - #7785 - #7788 - #7793 - #7796 --------- Co-authored-by: Colm <colmmchugh@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two commits in this PR:
Remove domain_default column since it has been removed from PG17
Relevant PG commit:
postgres/postgres@78806a9
78806a95095c4fb9230a441925244690d9c07d23
pg_stat_statements reset output diff fix
Relevant PG commits:
pg_stat_statements reset output changed in PG17, fix idea from
postgres/postgres@6ab1dbd
6ab1dbd26bbf307055d805feaaca16dc3e750d36