Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge dev-de in main #2421

Merged
merged 78 commits into from
Sep 27, 2023
Merged

Merge dev-de in main #2421

merged 78 commits into from
Sep 27, 2023

Conversation

iamNoah1
Copy link
Collaborator

Describe your changes

In order to get the completed terms online, we want to merge dev-de into main

seokho-son and others added 30 commits February 3, 2022 01:43
* first shot

* WIP german contribution index file

* finalized contribution index, add de.toml

* add contentDir to de config section in config.toml

* change request from catherine

* finalizing style guide

* change request from David and Catherine
[de] translation for agile software dev
* [de] Add localization cloud computing

* [de] Add missing title meta inf

* [de] Adjust wording in cloud computing

* [de] Adjust wording cloud computing

Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>

Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
* update terms to completed

* Update content/de/agile_software_development.md

Co-authored-by: Jihoon Seo <46767780+jihoon-seo@users.noreply.github.com>

* Update cloud_computing.md

Co-authored-by: Jihoon Seo <46767780+jihoon-seo@users.noreply.github.com>
Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
* Add german translation for API Gateway

Add german translation for API Gateway. Solves #507

* Update api_gateway.md

fixed all found typos by

* Update api_gateway.md

small wording adjustment, changes state

Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
[de] Add localization cloud native tech
DaveVentura and others added 7 commits July 13, 2023 14:55
Co-authored-by: Noah Ispas <Noahispas@gmail.com>
Signed-off-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>
* first shot

Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com>

* Update content/de/cluster.md

Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>
Signed-off-by: Noah Ispas <Noahispas@gmail.com>

* Update content/de/cluster.md

Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>
Signed-off-by: Noah Ispas <Noahispas@gmail.com>

* Update content/de/cluster.md

Signed-off-by: Noah Ispas <Noahispas@gmail.com>

---------

Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com>
Signed-off-by: Noah Ispas <Noahispas@gmail.com>
Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>
Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com>
[DE] merge main into dev-de
Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com>
Update status to completed for some terms
@netlify
Copy link

netlify bot commented Sep 18, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 28b4ab5
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/6510109643c7d30008172c1f
😎 Deploy Preview https://deploy-preview-2421--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the lang/de for German label Sep 18, 2023
@seokho-son
Copy link
Collaborator

There are several commits without sign-off. I guess they have been included before we applied DCO in this repo.
Let me manually set pass DCO here. And I am going to use squash merge method.

@@ -68,6 +68,7 @@ description = "The CNCF Cloud Native Glossary Project is intended to be used as
#time_format_default = "02.01.2006"
#time_format_blog = "02.01.2006"


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have to modify this part, but I guess it was from previous manual rebase.

In order to minimize mixed up situation, we'd better update dev-de first, and then, let's merge this PR.

@seokho-son seokho-son added the hold Wait, please do not proceed this yet label Sep 19, 2023
@seokho-son seokho-son mentioned this pull request Sep 19, 2023
2 tasks
@github-actions
Copy link

Wait, please do not proceed with this yet.

@iamNoah1
Copy link
Collaborator Author

@jihoon-seo @seokho-son I guess we can proceed here?!

@seokho-son seokho-son removed the hold Wait, please do not proceed this yet label Sep 27, 2023
@seokho-son
Copy link
Collaborator

Hi @iamNoah1 :)

I had hoped that #2422 would help discard the minor change in the config.toml. However, it didn't work as expected. I suspect the change originated from a previous rebase of the dev-de branch.

We could potentially discard the change by altering the commit history, but the hassle might outweigh the benefits.
I'll go ahead and merge this PR as is.

Copy link
Collaborator

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seokho-son seokho-son merged commit 581109e into main Sep 27, 2023
1 check passed
sestegra added a commit to juliafmorgado/CNCFglossary that referenced this pull request Oct 29, 2023
sestegra added a commit to juliafmorgado/CNCFglossary that referenced this pull request Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/de for German
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants