-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings and initial contents for German localization #347
Conversation
✔️ Deploy Preview for cncfglossary ready! 🔨 Explore the source changes: 0311af5 🔍 Inspect the deploy log: https://app.netlify.com/sites/cncfglossary/deploys/620b8a128e6e5c00081e60cc 😎 Browse the preview: https://deploy-preview-347--cncfglossary.netlify.app |
@iamNoah1 please use https://github.com/cncf/glossary/tree/dev-de for this configuration. For instance, Korean team uses "dev-ko" branch. (#291) |
@seokho-son of course, thanks. Changed the target branch. |
ok just recognized that the style guide is still missing |
@iamNoah1 It looks good to me except the style guide :) It seems you are working on adding style guide.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Made a few comments.
@CathPag thanks for feedback, adjusted everything and added the style guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you, Noah! I think I found two typos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Liest sich sehr gut.
Ich habe noch zwei Anmerkungen da gelassen.
In den Dokumenten habe ich noch Fehler gefunden, die aber diesen PR nicht direkt betreffen. Ich habe sie mir aufgeschrieben. Vielleicht können wir in unserem Kickoff-Meeting mit klären, wie wir damit umgehen, da man leider nur betroffene Zeilen kommentieren kann.
Ich habe mir die Fehler aber aufgeschrieben.
@CathPag @DaveVentura implemented the change requests :) |
@@ -0,0 +1,127 @@ | |||
--- | |||
title: Style Guide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iamNoah1
Do we need to localize the title ? :)
Anyway all configuration look good to me ;) I am ready to approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO we can leave it like it is. There are a lot of english words that are used in german language as well and sound strange if we force-translate them ^^. What you think @DaveVentura, @CathPag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Are we ready to merge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…n) (#1463) * Settings and initial contents for German localization (#347) * first shot * WIP german contribution index file * finalized contribution index, add de.toml * add contentDir to de config section in config.toml * change request from catherine * finalizing style guide * change request from David and Catherine Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com> * [de] Fix typo in _index.md * first shot * change requests * [de] Add localization cloud computing (#711) * [de] Add localization cloud computing * [de] Add missing title meta inf * [de] Adjust wording in cloud computing * [de] Adjust wording cloud computing Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> * update terms to completed (#725) * update terms to completed * Update content/de/agile_software_development.md Co-authored-by: Jihoon Seo <46767780+jihoon-seo@users.noreply.github.com> * Update cloud_computing.md Co-authored-by: Jihoon Seo <46767780+jihoon-seo@users.noreply.github.com> * localize feedback section * [de] Fix template title for agile software dev (#731) * Add german translation for API Gateway (#732) * Add german translation for API Gateway Add german translation for API Gateway. Solves #507 * Update api_gateway.md fixed all found typos by * Update api_gateway.md small wording adjustment, changes state Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> * [de] Add localization for "abstraction" * [de] Remove whitespaces * [de] Remove redundant information * [de] Rephrase sentence * [de] Rephrase sentence * [de] Remove white spaces * [de] Add localization cloud native tech * Incorporate suggested change Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> * Incorporate suggested change Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> * Incorporate suggested change Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> * Incorporate suggested change to title * Update cloud_native_tech.md * rename files, add semantic line breaks, empty lines (#974) * rename files, add semantic line breaks, empty lines Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com> * [DE] Take Over Cloud Native Security localization (#990) * add cloud native sec Signed-off-by: Max Körbächer <m.koerbaecher@reply.de> Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com> * edits, semantic line breaks Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com> * change requests from Jihoon Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com> * change requests from david Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com> * change requests from david Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com> * Update content/de/cloud-native-security.md Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com> * Update content/de/cloud-native-security.md Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com> Co-authored-by: Max Körbächer <m.koerbaecher@reply.de> Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com> * german localize cloud native apps (#1085) * add german localisation for cloud native apps * add .md * Apply suggestions from code review Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> Signed-off-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com> * apply change requests - remove redundancy * Update content/de/cloud-native-apps.md Signed-off-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> * Update content/de/cloud-native-apps.md Signed-off-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> Signed-off-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com> Signed-off-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> Co-authored-by: David Wagner <daw@dataone.de> Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> * [DE] Add german definition for canary deployment (#1247) * [de] Add german definition for canary deployment Signed-off-by: Baris Cubukcuoglu <cubukcuoglu.baris@gmail.com> Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> * Update content/de/canary_deployment.md Signed-off-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> * Update content/de/canary_deployment.md Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com> Signed-off-by: Noah Ispas <Noahispas@gmail.com> * Update content/de/canary_deployment.md Signed-off-by: Noah Ispas <Noahispas@gmail.com> Signed-off-by: Baris Cubukcuoglu <cubukcuoglu.baris@gmail.com> Signed-off-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> Signed-off-by: Noah Ispas <Noahispas@gmail.com> Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> Co-authored-by: Noah Ispas <Noahispas@gmail.com> Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com> * german autoscaling localization (#1111) * add german autoscaling localisation * Update content/de/autoscaling.md Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> Signed-off-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com> * Update content/de/autoscaling.md Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> Signed-off-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com> * Update content/de/autoscaling.md Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> Signed-off-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com> * change requests * Update content/de/autoscaling.md Signed-off-by: Noah Ispas <Noahispas@gmail.com> Signed-off-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com> Signed-off-by: Noah Ispas <Noahispas@gmail.com> Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> Co-authored-by: Noah Ispas <Noahispas@gmail.com> * corrects filename Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com> * correct wording (#1355) Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com> Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com> * [localization/german] Add localization for API (#1055) * [localization/german] Add localization for API Co-authored-by: Noah Ispas <Noahispas@gmail.com> Signed-off-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com> * fix filename Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com> * [DE] Localization of Blue Green Deployment (#1342) * first shot Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com> * localize headers Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com> * Update content/de/blue-green-deployment.md Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com> Signed-off-by: Noah Ispas <Noahispas@gmail.com> * Update content/de/blue-green-deployment.md Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com> Signed-off-by: Noah Ispas <Noahispas@gmail.com> * Update content/de/blue-green-deployment.md Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com> Signed-off-by: Noah Ispas <Noahispas@gmail.com> * Update content/de/blue-green-deployment.md Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com> Signed-off-by: Noah Ispas <Noahispas@gmail.com> * add change requests from Baris Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com> Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com> Signed-off-by: Noah Ispas <Noahispas@gmail.com> Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com> * change every article state to completed Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com> * extend information about initializing members of german content Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com> Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com> Signed-off-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com> Signed-off-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> Signed-off-by: Baris Cubukcuoglu <cubukcuoglu.baris@gmail.com> Signed-off-by: Noah Ispas <Noahispas@gmail.com> Co-authored-by: Dennis Groß <gdennis91@googlemail.com> Co-authored-by: Jihoon Seo <46767780+jihoon-seo@users.noreply.github.com> Co-authored-by: Christian Hüning <christianhuening@users.noreply.github.com> Co-authored-by: Oliver L <oliver@pattern.engineer> Co-authored-by: Max Körbächer <m.koerbaecher@reply.de> Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com> Co-authored-by: David Wagner <daw@dataone.de> Co-authored-by: Baris Cubukcuoglu <cubukcuoglu.baris@googlemail.com>
…n) (cncf#1463) * Settings and initial contents for German localization (cncf#347) * first shot * WIP german contribution index file * finalized contribution index, add de.toml * add contentDir to de config section in config.toml * change request from catherine * finalizing style guide * change request from David and Catherine Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com> * [de] Fix typo in _index.md * first shot * change requests * [de] Add localization cloud computing (cncf#711) * [de] Add localization cloud computing * [de] Add missing title meta inf * [de] Adjust wording in cloud computing * [de] Adjust wording cloud computing Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> * update terms to completed (cncf#725) * update terms to completed * Update content/de/agile_software_development.md Co-authored-by: Jihoon Seo <46767780+jihoon-seo@users.noreply.github.com> * Update cloud_computing.md Co-authored-by: Jihoon Seo <46767780+jihoon-seo@users.noreply.github.com> * localize feedback section * [de] Fix template title for agile software dev (cncf#731) * Add german translation for API Gateway (cncf#732) * Add german translation for API Gateway Add german translation for API Gateway. Solves cncf#507 * Update api_gateway.md fixed all found typos by * Update api_gateway.md small wording adjustment, changes state Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> * [de] Add localization for "abstraction" * [de] Remove whitespaces * [de] Remove redundant information * [de] Rephrase sentence * [de] Rephrase sentence * [de] Remove white spaces * [de] Add localization cloud native tech * Incorporate suggested change Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> * Incorporate suggested change Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> * Incorporate suggested change Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> * Incorporate suggested change to title * Update cloud_native_tech.md * rename files, add semantic line breaks, empty lines (cncf#974) * rename files, add semantic line breaks, empty lines Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com> * [DE] Take Over Cloud Native Security localization (cncf#990) * add cloud native sec Signed-off-by: Max Körbächer <m.koerbaecher@reply.de> Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com> * edits, semantic line breaks Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com> * change requests from Jihoon Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com> * change requests from david Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com> * change requests from david Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com> * Update content/de/cloud-native-security.md Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com> * Update content/de/cloud-native-security.md Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com> Co-authored-by: Max Körbächer <m.koerbaecher@reply.de> Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com> * german localize cloud native apps (cncf#1085) * add german localisation for cloud native apps * add .md * Apply suggestions from code review Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> Signed-off-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com> * apply change requests - remove redundancy * Update content/de/cloud-native-apps.md Signed-off-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> * Update content/de/cloud-native-apps.md Signed-off-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> Signed-off-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com> Signed-off-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> Co-authored-by: David Wagner <daw@dataone.de> Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> * [DE] Add german definition for canary deployment (cncf#1247) * [de] Add german definition for canary deployment Signed-off-by: Baris Cubukcuoglu <cubukcuoglu.baris@gmail.com> Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> * Update content/de/canary_deployment.md Signed-off-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> * Update content/de/canary_deployment.md Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com> Signed-off-by: Noah Ispas <Noahispas@gmail.com> * Update content/de/canary_deployment.md Signed-off-by: Noah Ispas <Noahispas@gmail.com> Signed-off-by: Baris Cubukcuoglu <cubukcuoglu.baris@gmail.com> Signed-off-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> Signed-off-by: Noah Ispas <Noahispas@gmail.com> Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> Co-authored-by: Noah Ispas <Noahispas@gmail.com> Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com> * german autoscaling localization (cncf#1111) * add german autoscaling localisation * Update content/de/autoscaling.md Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> Signed-off-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com> * Update content/de/autoscaling.md Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> Signed-off-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com> * Update content/de/autoscaling.md Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> Signed-off-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com> * change requests * Update content/de/autoscaling.md Signed-off-by: Noah Ispas <Noahispas@gmail.com> Signed-off-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com> Signed-off-by: Noah Ispas <Noahispas@gmail.com> Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> Co-authored-by: Noah Ispas <Noahispas@gmail.com> * corrects filename Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com> * correct wording (cncf#1355) Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com> Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com> * [localization/german] Add localization for API (cncf#1055) * [localization/german] Add localization for API Co-authored-by: Noah Ispas <Noahispas@gmail.com> Signed-off-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com> * fix filename Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com> * [DE] Localization of Blue Green Deployment (cncf#1342) * first shot Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com> * localize headers Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com> * Update content/de/blue-green-deployment.md Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com> Signed-off-by: Noah Ispas <Noahispas@gmail.com> * Update content/de/blue-green-deployment.md Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com> Signed-off-by: Noah Ispas <Noahispas@gmail.com> * Update content/de/blue-green-deployment.md Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com> Signed-off-by: Noah Ispas <Noahispas@gmail.com> * Update content/de/blue-green-deployment.md Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com> Signed-off-by: Noah Ispas <Noahispas@gmail.com> * add change requests from Baris Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com> Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com> Signed-off-by: Noah Ispas <Noahispas@gmail.com> Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com> * change every article state to completed Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com> * extend information about initializing members of german content Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com> Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com> Signed-off-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com> Signed-off-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> Signed-off-by: Baris Cubukcuoglu <cubukcuoglu.baris@gmail.com> Signed-off-by: Noah Ispas <Noahispas@gmail.com> Co-authored-by: Dennis Groß <gdennis91@googlemail.com> Co-authored-by: Jihoon Seo <46767780+jihoon-seo@users.noreply.github.com> Co-authored-by: Christian Hüning <christianhuening@users.noreply.github.com> Co-authored-by: Oliver L <oliver@pattern.engineer> Co-authored-by: Max Körbächer <m.koerbaecher@reply.de> Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com> Co-authored-by: David Wagner <daw@dataone.de> Co-authored-by: Baris Cubukcuoglu <cubukcuoglu.baris@googlemail.com>
No description provided.