-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge main
into branch dev-ja
#2738
Conversation
Signed-off-by: Guillaume Bernard <guillaume.bernard@live.fr>
[zh-tw] localize 'DevOps'
Signed-off-by: Ludovic Logiou <ludovic.logiou@gmail.com>
Signed-off-by: Ludovic Logiou <ludovic.logiou@gmail.com>
Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>
Signed-off-by: Stéphane Este-Gracias <sestegra@gmail.com>
Signed-off-by: Ludovic Logiou <ludovic.logiou@gmail.com>
[tw] Add content/zh-tw/continuous-integration.md
[FR] Traduction de Loosely Coupled Architecture into French
[fr] Localize Reliability
Signed-off-by: Guillaume Bernard <guillaume.bernard@live.fr>
Signed-off-by: Guillaume Bernard <guillaume.bernard@live.fr>
Signed-off-by: Guillaume Bernard <guillaume.bernard@live.fr>
Signed-off-by: Guillaume Bernard <guillaume.bernard@live.fr>
Signed-off-by: Guillaume Bernard <guillaume.bernard@live.fr>
Signed-off-by: Stéphane Este-Gracias <sestegra@gmail.com>
Signed-off-by: Stéphane Este-Gracias <sestegra@gmail.com>
Signed-off-by: Guillaume Bernard <guillaume.bernard@live.fr>
Signed-off-by: Stéphane Este-Gracias <sestegra@gmail.com>
Traduction de scalability.md
Signed-off-by: Guillaume Bernard <guillaume.bernard@live.fr>
Signed-off-by: Guillaume Bernard <guillaume.bernard@live.fr>
Signed-off-by: Christophe Sauthier <christophe.sauthier@gmail.com>
Signed-off-by: Guillaume Bernard <guillaume.bernard@live.fr>
Signed-off-by: Guillaume Bernard <guillaume.bernard@live.fr>
Signed-off-by: Guillaume Bernard <guillaume.bernard@live.fr>
…pps-2 [FR] localize Distributed Apps
[fr] Localize Virtualization
[fr] Localize vertical scaling
[fr] Localize horizontal scaling
I think the easiest way to resolve the issue is to merge this PR instead of a rebase, and then merge #2677. (And then, I believe we will be able to close #2695 and #2700.) @seokho-son @jihoon-seo @naonishijima @kaitoii11 What do you think about this approach? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Thank you @Okabe-Junya !
It appears that there is a failure in the DCO check. Why might this be? How should this be resolved?... Executing the following commands might resolve the issue, but there could be side effects git rebase HEAD~250 --signoff
git push --force-with-lease origin merge-main |
@Okabe-Junya You can manually DCO on via Details. |
I think there are several problems with making DCO changes (following the instructions written in the details) in this PR.
Therefore, I am hoping for this CI to pass, but... |
@seokho-son @jihoon-seo Do you have any idea or advice to merge this PR? |
Hello @Okabe-Junya, I apologize for the delayed response due to personal circumstances. Reflecting on it now, it seems that resolving merge conflicts through rebase might not always be necessary. I will go through a brief review and confirmation process with the other maintainers regarding this matter and then proceed with handling this PR. Regarding the DCO issue, since the problematic commits originated not in the dev-ja branch but from the main branch, it looks like I'll have to manually pass them. You don't need to worry about this part. |
Thank you for your thoughtful response. This issue seems a bit difficult. I respect the opinions of reviewers and other maintainers(of course, including you). if this PR is not necessary, I'm fine with closing it or creating another PR. I hope this issue will be resolved successfully. (It seems that there are not enough reviews from CODEOWNERS to merge this PR. Since @.kaitoii11 is not a CODEOWNER, it appears that there are not enough approvers.) |
There are no objections from the maintainers, so I am going to merge the PR. (@Okabe-Junya, regarding the reviews from CODEOWNERS, it's hard to get all approvals for special PRs like this, which do not require a code review. Maintainers use their authority (bypass branch protections) to merge these kinds of PRs.) |
Describe your changes
merge upstream/main into upstream/dev-ja
Background
There are several ways to merge the dev-ja branch into the main branch, but this has become complicated due to a number of PRs being created.
Currently, since main and dev-ja are conflicting, we cannot be merged directly. I think the easiest way to resolve this is to merge the main branch into dev-ja and then merge #2677.
Related issue number or link (ex:
resolves #issue-number
)no issue related in this PR
Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.