update #1
Merged
update #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Great job! LGTM! (Looks good to me)
Everything looks good for quick fix! reverting to old json
* Moved events.html to an events folder * add permalinks and change title * Add style and render days of week with liquid * Adjust size/margin of Our Events and Our Locations * Change css for .event-title * change padding in .getting-started-page-card-hack-nights * change css for .title-meetup class * put subheading and paragraphs in same div and align righ of image * Constraint fixes - 72px margin between between each Meetup category - 16px margin between subheadings and paragraphs - 80px margin between last paragraph and Meetup button * componentize left col * Change heading spacing - Add 72px margin between heading and first paragraph (same as in the Meetup column card) * Fix Onboarding Link - Onboarding link leads to wrong url- should be to Getting Started page (https://www.hackforla.org/getting-started) * Make time zone text bold - Make time zone text bold, should be font-weight: 700 - In .userTimeZone class * Change css for .day-header-1 class - Make all of the days of week ALL CAPS (MONDAY, TUESDAY, etc. - in the html), bold, and 18px - should be- font-size: 1.125rem (18px) font-weight: 700 + in HTML: all-caps titles - In .day-header-1 class - Add 30px margin above the days of week and 10px margin belo margin: 30px 0 10px 0 * Remove padding from .day-header-1 class - Remove the padding that pushes the meeting times to the right- Add: padding: 0 - Add to .day-header-1 class * css changes and refactors - created new yml files to loop over events in left-col-container.html - Adjust banner font size, weight, and margin - should be - font-size: 1rem (16px) font-weight: 700 margin: auto 29% * Add mobile view css overrides - Decrease the padding of the page cards in their collapsed form- should be- padding: 5px 15px - Adjust the border radius- should be - border-radius: 20px * Some css changes * Moved Javascript - Moved content in the previously second script tag into righ-col-content.html. Because everything the code within that script tag is doing is very tighty tied to everything within the right-col-content.html, i.e the scheduler. * path to refactor * Major refactor of existing js. This can now be separated into its own .js file * Please align the images with the text in both left and right column cards * In .notification-banner p class please remove the line-height property (it should go to default line height) * Addresses point 4 made in the change request * Addresses point 5 in the change request * Adresses point 6 * Adress point 1 made in change request - Can you please actually remove the content-section class? It's causing the yellow banner to have 16px margin on both sides, which makes it look especially weird in mobile- * I was promised these are the last changes * Multi column events display now working * Add time zone text
* removed add . * added the text to remove a staged file
* renamed about-us page to about * renamed "assets/images/about-us" directory to "assets/images/about"
Project cards display fixed.
* changed Under Developmetn to Social Safety Net on line 61 * changed Under Development to Social Safety Net on line 33
…#1147) * fixes the issue where if clickeed the page would stop displaying information (like meetup events, and team meetings) * fixed cute little carrot thing * fixed function name * fixed issue where desktop to mobile would leave accordions open.
* Move inline styling to stylesheet * Fix inline styling
* Centered dropdowns on Events page * styles: tweaked Events card width
* Fix buggy header nav * Rename function
* About us grid more aligned * windowWidth bug fixed in about.js page * Another window.innerWidth Bug fixed
change https to http on the demo site so that it will work correctly.
Updated the file to use the correct categories for the looking for
* added la city to dept of personnel * added "& County" to LA City Attorney's Homeless Engagement and Response Team in Partners section
* edited h1 styling and added underlined class * edited text and added p tag for spacing * updated span tag & removed class * updated span tag * commented out non remote locations * adjusted hero image height to show button
* Made updates to communities of practice page based on issue 1331 * Updated COP card descriptions and changed file names for engineering assets * Updated recruiting messages and behavior of recruiting message display * Made viewport changes for card's tablet view and removed unused class
* Some scss changes - Got rid of .outer-link class - Added a tag in the toolkit-flex-item.section-container * Removed not-clickable scss
* Styled communities of practice page * Changed hex code to variable
* banner to full width + spacing on side images * removed my comments * added missing e in class name * variable name added * all scss color variable friendly now * added that pesky semicolon Co-authored-by: erikaBell <67438372+erikaBelll@users.noreply.github.com>
* wip: standardizing project meetings styles * wip-2: Standardizing project meetings styles * Standardized Project Meetings styles
* Fix styling syntax in code Fixes #1389 - Needed to make .content-section a child of .events-page so that it does not act out during css compile. * Fix class names
* previous ballot-nav.png replaced with ballotnav.jpg * previous ballot-nav.png replaced with ballotnav.jpg * updated Images folder to include new path
* adjust styling of wins page * cleaned up code * one more clean up * adjusted font size to 15px, in rem unites, for team(s)/role(s) Co-authored-by: erikaBell <67438372+erikaBelll@users.noreply.github.com>
* 2FA alt edit * modified decorative image alt on event page * modified decorative image alt on event page * edit small image alt * hide decorative img alt * added alt="" and alt text for partners * added alt="" , need further updated text * added alt="" , need further updated text * modified brigade organizer playbook's alt according to the front img * edited civic opportunity project alt * modified civic tech index's alt according to the front img * modified civic tech structure's alt according to the front img * edits * edit * edit * edit * edit * edit * edited project cards * finished alt text audit for hackforla website march 2021 version * edited-conflicts * edited parsing
* update * Update changes not meant to be in this PR * Update config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.