-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve constraint violation visualization #125
Improve constraint violation visualization #125
Conversation
Is setting the x tick labels at 90 degree rotation better, in general? If so, maybe adjust that while you are at it. |
I don't like those ticks in general, they always make a mess especially if a constraint is a longer equation. In this case, if you would choose |
It is that you like to see which one it approximately is, but otherwise I would just throw them all together in a single boxplot |
We can go with this as is and address formatting later. |
Forgot about this. Merging. |
Also isn't as small. |
Fixes #123 and #53
Changes
Correct the slicing of the constraints_violation vector.
The constraint vector is formatted as (refer to the creation of the constraint function and the wrapper:
where
con_1_2, ..., con_1_N
the constraint violation is at every node for the first discrete equation of motion.Only create a single axis for showing the EoM violation, as they are not officially coupled to specific states. Yes, it is correct to say that most will specify the first n//2 as kinematic differential equations, but that is not required.
Only plot the constraint violations of the instance constraints if there are any instance constraints.