-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow separate eom violation plots. replaces PR #273 #310
base: master
Are you sure you want to change the base?
Conversation
This puts each equation on a new row: Note that we switched to the single axis deliberately here: #125 |
In general, one is needing to know if any constraints are violated at all. What is the reason to make the default plot show the relative differences in the equation of motion violations? Secondly , have you tested this with very large # of EoMs? Does it always make a plot that isn't extremely squished vertically? I prefer that the plot functions just work and have few to no knobs to turn. Anyone can create their own plotting functions or manipulate the returned axes. I'd like these to give a default average plot to quickly view with simple function calls. |
As I remember, with some simulation I wanted to see which eom was violated severely, but I must admit I do not remember exactly. I just thought it does not hurt having it.
I tested it with many of my simulations, and never noticed this. Max number maybe 15 or 20 probably not more.
The optional detailed_eoms is set to false. So, the knob need not be turned. Then everything is exactly like the current version. |
This only happens if the eoms should be printed individually, otherwise nothng changes. |
This allows to see the violations of the equations of motion in detail, each in a separate plot, if the new optional keyword detailed_eoms is set to True. If set to False or not set, the eom violations will be displayed as before.
This replaces PR #273 which does not meet the last test.
I have tried it on many simulations, and at times found substantial differences in the violations of the eoms, say 10^(-8) for the worst to 10^(-18) for the best is no unusual.