-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a build for Apple Silicon #55
Conversation
I've amended the commit with There's a sister issue at cyberark/homebrew-tools#41 - I can create a PR for the |
Do you want me to rebase off of master, so you can try to re-run the CI builds? |
Hi @fangel , Yes please rebase and can you also add a comment in the changelog? Added
|
4e5be3c
to
dcd1360
Compare
Based on the changes to the main summon `.goreleaser.yml` file, I've added the same changes to this configuration. Signed-off-by: Morten Fangel <fangel@sevengoslings.net>
I've rebased off of main and added the changelog modifications now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Perfect! What's the procedure for actually merging? Will you do that, or? |
Hi @fangel , I merged it. Thanks for submitting this PR! |
Wonderful - then the next step for full Apple Silicon support is cyberark/homebrew-tools#41 (and possibly also adding the ARM-build url to the summon-aws-secrets formulae. |
Based on the changes to the main summon
.goreleaser.yml
file, I've added the same changes to this configuration.I was able to do a
./bin/build.sh
locally, and could manually copy over the result to/usr/local/lib/summon
which seems to work.Note, I've never done any work with either Go or GoReleaser, so this might be the wrong approach. So feel free to suggest a completely different approach to solve the issue of adding support for Apple Silicon.
Desired Outcome
A release for Apple Silicon powered macOS computers to run is created along side all of the existing releases.
Implemented Changes
.goreleaser.yml
in cyberark/summon@d8e955cChangelog
CHANGELOG update
Test coverage
changes, or
Documentation
README
s) were updated in this PRBehavior
Security