-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
To polkadot-stable2407
#1643
Merged
Merged
To polkadot-stable2407
#1643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xavier Lau <x@acg.box>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jiguantong
previously approved these changes
Dec 30, 2024
XCM related changes LGTM |
aurexav
force-pushed
the
x/stable2407
branch
from
December 30, 2024 06:50
8384cfd
to
47d8cb5
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Check a3443f0
|
This was referenced Dec 31, 2024
Closed
aurexav
commented
Jan 14, 2025
// For each foreign asset, the fee is computed based on its relative price (also | ||
// stored in the XcmWeightTrader pallet) against the native asset. | ||
// For the native asset fee is computed using WeightToFee implementation. | ||
type Trader = pallet_xcm_weight_trader::Trader<Runtime>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add migration.
Closed
aurexav
added
S-Audited
[Security] Audited
and removed
S-Need Audit
PR contains changes to fund-managing logic that should be properly reviewed and externally audited
labels
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bk-API
[Break] This changes API; next release should be major.
Bk-Storage
[Break] This changes Storage; next release should be major.
C-Pallet
[Component] Something about pallet
C-Runtime
[Component] Something about runtime
C-Test
[Component] Something about test
C-XCM
[Component] Something about XCM
D-Crate
[Dependency] From crates.io
D-Frontier
[Dependency] From Frontier
D-Moonbeam
[Dependency] From Moonbeam
D-PolkadotSDK
[Dependency] From polkadot-sdk
S-Audited
[Security] Audited
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.