Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add release notes for v22.0.0 #6459

Merged

Conversation

PastaPastaPasta
Copy link
Member

Issue being fixed or feature implemented

Release notes for v22

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@UdjinM6 UdjinM6 added this to the 22 milestone Dec 7, 2024
doc/release-notes.md Outdated Show resolved Hide resolved
- Kittywhiskers Van Gogh
- Konstantin Akimov
- Odysseas Gabrielides
- PastaPastaPasta
- UdjinM6
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- **Behavior:** `-statsprefix` enforces the usage of a delimiter between the prefix and key.
- It will be removed in version **23.x**.

## GUI Changes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider including some minor changes to release notes:
Merge #6444: fix: add platform transfer to "most common" filter
Merge bitcoin-core/gui#740: Show own outputs on PSBT signing window
Merge bitcoin-core/gui#365: Draw "eye" sign at the beginning of watch-only addresses
69a1305 Merge bitcoin-core/gui#309: Add access to the Peers tab from the network icon (Hennadii Stepanov)
Merge bitcoin-core/gui#256: Save/restore column sizes of the tables in the Peers tab

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any recommended text?

Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PastaPastaPasta left some review suggestions

- `getpeerinfo` no longer returns the following fields: `addnode` and `whitelisted`, which were previously deprecated in v21.
- Instead of `addnode`, the `connection_type` field returns `manual`.
- Instead of `whitelisted`, the `permissions` field indicates if the peer has special privileges.
- *(#20755)*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If including PR number, it should probably be an actual link to the PR for anyone not looking at the releases notes on Github. Do we typically include PR numbers for RPC changes?

- **`getblockfrompeer` Parameter Renaming**
- The named argument `block_hash` has been renamed to `blockhash` to align with the rest of the codebase.
- **Breaking Change:** If using named parameters, ensure to update them accordingly.
- *(#6149)*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If including PR number, it should probably be an actual link to the PR for anyone not looking at the releases notes on Github. Do we typically include PR numbers for RPC changes?


- **`getblockfrompeer` Parameter Renaming**
- The named argument `block_hash` has been renamed to `blockhash` to align with the rest of the codebase.
- **Breaking Change:** If using named parameters, ensure to update them accordingly.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **Breaking Change:** If using named parameters, ensure to update them accordingly.
- **Breaking Change:** If using named parameters, make sure to update them accordingly.

- `getcoinjoininfo` will no longer report `keys_left` and will not incorrectly warn about keypool depletion with descriptor wallets.

- **`creditOutputs` Format Change**
- `creditOutputs` entries in various RPCs that output transaction JSON are now shown as objects instead of strings.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `creditOutputs` entries in various RPCs that output transaction JSON are now shown as objects instead of strings.
- `creditOutputs` entries in various RPCs that output transactions as JSON are now shown as objects instead of strings.

- Nodes with onion connectivity will attempt to maintain at least **two outbound onion connections** and will protect these connections from eviction.
- **Benefit:** Ensures nodes capable of accessing the onion network maintain a few onion connections, allowing network messages to propagate even if non-onion IPv4 traffic is blocked.
- **Security Enhancement:** Enables P2P encryption for these peers.
- *(#6147)*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If including PR number, it should be an actual link to the PR for anyone not looking at the release notes on Github.

- **DSQ Message Broadcast Update**
- Starting in protocol version **70234**, DSQ messages are broadcast using the inventory system instead of relaying to all connected peers.
- **Benefit:** Reduces bandwidth needs for all nodes, especially noticeable on highly connected masternodes.
- *(#6148)*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If including PR number, it should be an actual link to the PR for anyone not looking at the release notes on Github.

- *(#6148)*

- **Compressed Block Headers Request Limit**
- Starting in protocol version **70235**, The maximum number of compressed block headers that can be requested at once has been increased from **2000** to **8000**.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Starting in protocol version **70235**, The maximum number of compressed block headers that can be requested at once has been increased from **2000** to **8000**.
- Starting in protocol version **70235**, the maximum number of compressed block headers that can be requested at once has been increased from **2000** to **8000**.

- **BIP324 Encrypted Communication (Experimental)**
- Dash Core now experimentally implements [BIP324](https://github.com/bitcoin/bips/blob/master/bip-0324.mediawiki), introducing encrypted communication for P2P network traffic.
- **Opt-In Adoption**
- **Enable Encryption:** Users can opt-in to use BIP324 by adding the `-v2transport=1` flag to their Dash Core configuration.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would only be -v2... if passing as cli arg

Suggested change
- **Enable Encryption:** Users can opt-in to use BIP324 by adding the `-v2transport=1` flag to their Dash Core configuration.
- **Enable Encryption:** Users can opt-in to use BIP324 by adding the `v2transport=1` to their Dash Core configuration.


## New RPCs

- **`quorum platformsign`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **`quorum platformsign`
- **`quorum platformsign`**

UdjinM6
UdjinM6 previously approved these changes Dec 10, 2024
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 21e8a77

- Allows using all **24 active quorums** and the most recent inactive quorum.
- Previous versions may refuse withdrawals with `bad-assetunlock-not-active-quorum` even if the quorum is active.
- **Withdrawal Limits Increased:**
- Flat **2000 Dash** per **576 latest blocks**.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention the previous limit?

Suggested change
- Flat **2000 Dash** per **576 latest blocks**.
- Flat **2000 Dash** per **576 latest blocks**. The previous limit was 1000 Dash.

@@ -61,6 +237,7 @@ debug the release candidates.

These release are considered obsolete. Old release notes can be found here:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
These release are considered obsolete. Old release notes can be found here:
These releases are considered obsolete. Old release notes can be found here:


# Notable changes
- **Asset Unlock Transactions (Platform Transfer)**
- Introduces a new fork `withdrawals` that changes consensus rules.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Introduces a new fork `withdrawals` that changes consensus rules.
- Introduces a new fork, `withdrawals`, that changes consensus rules.

Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 3404fa0

@PastaPastaPasta PastaPastaPasta merged commit 2727e77 into dashpay:develop Dec 10, 2024
20 of 21 checks passed
@PastaPastaPasta PastaPastaPasta deleted the doc-add-release-notes branch December 10, 2024 15:29
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this pull request Dec 10, 2024
3404fa0 docs: add release notes for v22.0.0 (pasta)

Pull request description:

  ## Issue being fixed or feature implemented
  Release notes for v22

  ## What was done?

  ## How Has This Been Tested?

  ## Breaking Changes

  ## Checklist:
    _Go over all the following points, and put an `x` in all the boxes that apply._
  - [ ] I have performed a self-review of my own code
  - [ ] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_

Top commit has no ACKs.

Tree-SHA512: b1fca9297814ab3497cc87512eb2a66daff22a17802c6cd87ef9af75c48fbecda8963c332191c3e3e7abdf495817da3e505b12baa646e97d388cb1aee74a67a7
PastaPastaPasta added a commit that referenced this pull request Dec 10, 2024
c90339e Merge #6459: docs: add release notes for v22.0.0 (pasta)
a6f1fc5 Merge #6475: chore: bumped chain assumed sizes based on latest usage (pasta)
d7cd9f1 Merge #6464: chore: update man pages for v22 (pasta)
212f91c Merge #6461: docs: update supported versions in SECURITY.md (pasta)
9a8b685 Merge #6460: chore: Translations 2024-12 (pasta)
2f71f4d Merge #6458: chore: bump MIN_MASTERNODE_PROTO_VERSION to latest proto (pasta)

Pull request description:

  ## Issue being fixed or feature implemented
  Batch of backports going into v22.0.x recently merged into develop

  ## What was done?
  See commits

  ## How Has This Been Tested?
  compiles

  ## Breaking Changes
  see release notes

  ## Checklist:
    _Go over all the following points, and put an `x` in all the boxes that apply._
  - [ ] I have performed a self-review of my own code
  - [ ] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_

ACKs for top commit:
  kwvg:
    utACK c90339e
  UdjinM6:
    utACK c90339e

Tree-SHA512: 124643d4b17f126c56225269d291672adf567848f440cd33f53358b3f76f0e5cf801c618493e1e24162e00c525a5d43f1bfa461e8928e04e046b37a94d13ae1c
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this pull request Dec 14, 2024
1c7bfcb chore: set release true (pasta)
c90339e Merge dashpay#6459: docs: add release notes for v22.0.0 (pasta)
a6f1fc5 Merge dashpay#6475: chore: bumped chain assumed sizes based on latest usage (pasta)
d7cd9f1 Merge dashpay#6464: chore: update man pages for v22 (pasta)
212f91c Merge dashpay#6461: docs: update supported versions in SECURITY.md (pasta)
9a8b685 Merge dashpay#6460: chore: Translations 2024-12 (pasta)
2f71f4d Merge dashpay#6458: chore: bump MIN_MASTERNODE_PROTO_VERSION to latest proto (pasta)
fa29ed5 Merge dashpay#6456: fix(qt): allow refreshing wallet data without crashing (pasta)
758cd64 Merge dashpay#6452: fix: store ready queues on the mixing masternode (pasta)
395447b Merge dashpay#6451: depends: update 'src/dashbls' to dashpay/bls-signatures@7e747e8a as 62fa665 (pasta)
c7b0d80 Merge dashpay#6441: fix: hold wallet shared pointer in CJ Manager/Sessions to prevent concurrent unload (pasta)
c074e09 Merge dashpay#6444: fix: add platform transfer to "most common" filter (pasta)
cb04114 Merge dashpay#6442: fix: coin selection with `include_unsafe` option should respect `nCoinType` (pasta)
db5b53a Merge dashpay#6434: fix: early EHF and buried EHF are indistinguish (pasta)
8b88ff7 Merge dashpay#6414: chore: bump seeds for v22 (pasta)
02ad523 Merge dashpay#6411: chore: update nMinimumChainWork, defaultAssumeValid, checkpointData, chainTxData for mainnet and testnet (pasta)
3bbcd3d Merge dashpay#6393: docs: mention building for some HOSTs only in `release-process.md` (pasta)
18f636f Merge dashpay#6426: fix: respect SENDDSQUEUE message, move DSQ relay into net processing / peerman (pasta)
9fed456 Merge dashpay#6407: fix: dataraces (pasta)
86105da Merge dashpay#6408: refactor: removed pre-MN_RR logic of validation of CL (pasta)
a1f7e96 Merge dashpay#6406: ci: use `actions/cache` to manage depends cache (pasta)
90a3807 Merge dashpay#6402: ci: cache built (pasta)
66f6787 Merge dashpay#6401: ci: deduplicate depends building (pasta)
7ca5663 Merge dashpay#6397: ci: add powerpc64 to GH Guix job matrix (pasta)

Pull request description:

  ## Issue being fixed or feature implemented

  ## What was done?
  Suppressed changes from 1c7bfcb and resolved merge conflicts.

  ```
  Auto-merging .github/workflows/build.yml
  Auto-merging configure.ac
  Auto-merging src/chainparams.cpp
  Auto-merging src/coinjoin/client.cpp
  CONFLICT (content): Merge conflict in src/coinjoin/client.cpp
  Auto-merging src/coinjoin/client.h
  CONFLICT (content): Merge conflict in src/coinjoin/client.h
  Auto-merging src/coinjoin/util.cpp
  CONFLICT (content): Merge conflict in src/coinjoin/util.cpp
  Auto-merging src/coinjoin/util.h
  CONFLICT (content): Merge conflict in src/coinjoin/util.h
  Auto-merging src/evo/specialtxman.cpp
  Auto-merging src/init.cpp
  Auto-merging src/net_processing.cpp
  CONFLICT (content): Merge conflict in src/net_processing.cpp
  Auto-merging src/net_processing.h
  Auto-merging src/qt/transactiontablemodel.cpp
  Auto-merging src/wallet/wallet.cpp
  Auto-merging src/wallet/wallet.h
  CONFLICT (content): Merge conflict in src/wallet/wallet.h
  Auto-merging test/functional/feature_llmq_chainlocks.py
  CONFLICT (content): Merge conflict in test/functional/feature_llmq_chainlocks.py
  ```

  ## How Has This Been Tested?

  ## Breaking Changes

  ## Checklist:
  - [ ] I have performed a self-review of my own code
  - [ ] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_

ACKs for top commit:
  PastaPastaPasta:
    utACK d108579; no diff to develop

Tree-SHA512: 3f063011224880fee35edb04ce265dff33a52273c3d45ef1dbcebcecb22c25d8ad7c91b83514f36142716a6fbd0ddd3a8a3f2a9b59ce78ce975bbce69a2a13b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants