Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert DashboardPlugins to WidgetPlugins #1573

Closed
5 tasks
mattrunyon opened this issue Oct 12, 2023 · 0 comments · Fixed by #1598 or deephaven/deephaven-core#4770
Closed
5 tasks

Convert DashboardPlugins to WidgetPlugins #1573

mattrunyon opened this issue Oct 12, 2023 · 0 comments · Fixed by #1598 or deephaven/deephaven-core#4770
Assignees
@mattrunyon
Labels
enhancement New feature or request

Comments

@mattrunyon
Copy link
Collaborator

Some of our dashboard plugins should actually be widget plugins. They don't need to have listeners mounted globally and we will need to be able to use them as widget plugins for deephaven ui.

Definitely can convert

  • GridPlugin
  • ChartPlugin
  • PandasPlugin

Possibly can convert

  • MarkdownPlugin (doesn't listen to PanelEvent.Open)
  • FilterPlugin (uses other global events that might not be simple conversions)
@mattrunyon mattrunyon added the enhancement New feature or request label Oct 12, 2023
@mattrunyon mattrunyon self-assigned this Oct 12, 2023
@mattrunyon mattrunyon mentioned this issue Oct 25, 2023
Merged
mattrunyon added a commit that referenced this issue Oct 30, 2023
@mattrunyon
feat: Convert DashboardPlugins to WidgetPlugins (#1598)
a260842 
Fixes #1573
@mofojed mofojed mentioned this issue Nov 3, 2023
Merged
mofojed pushed a commit to deephaven/deephaven-core that referenced this issue Nov 3, 2023
@github-actions @deephaven-internal
Update web version 0.53.0 (#4770)
77b25b0 
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.53.0

# [0.53.0](deephaven/web-client-ui@v0.52.0...v0.53.0) (2023-11-03)


### Bug Fixes

* DH-15864: Scroll position StuckToBottom shouldn't trigger sharing dot ([#1617](deephaven/web-client-ui#1617)) ([3d4499b](deephaven/web-client-ui@3d4499b))
* Panel focus throwing an exception ([#1609](deephaven/web-client-ui#1609)) ([9e8b7ae](deephaven/web-client-ui@9e8b7ae))
* Plugins were re-registering on every re-render ([#1613](deephaven/web-client-ui#1613)) ([5977389](deephaven/web-client-ui@5977389))


### Features

* Add support for multi-partition parquet:kv tables ([#1580](deephaven/web-client-ui#1580)) ([d92c91e](deephaven/web-client-ui@d92c91e)), closes [#1143](deephaven/web-client-ui#1143) [#1438](deephaven/web-client-ui#1438)
* Babel Plugin - Mock css imports ([#1607](deephaven/web-client-ui#1607)) ([787c542](deephaven/web-client-ui@787c542)), closes [#1606](deephaven/web-client-ui#1606)
* Convert DashboardPlugins to WidgetPlugins ([#1598](deephaven/web-client-ui#1598)) ([a260842](deephaven/web-client-ui@a260842)), closes [#1573](deephaven/web-client-ui#1573)


### Reverts

* "fix: stuck to bottom on filter clear" ([#1616](deephaven/web-client-ui#1616)) ([806a6b6](deephaven/web-client-ui@806a6b6)), closes [deephaven/web-client-ui#1579](deephaven/web-client-ui#1579) [#1615](deephaven/web-client-ui#1615)

Co-authored-by: deephaven-internal <deephaven-internal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattrunyon mattrunyon

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@mattrunyon